14 Commits (1538666c237316763fcef43167441ba1d795a4e2)

Author	SHA1	Message	Date
Oliver Günther	6c75e16dc4	[37140] Use acts_as_url to generate unique slug for identifier (#9250) ... * Use acts_as_url to generate unique slug for identifier * Re-enable project identifier spec now handled in backend * Add integration spec for set attribute service * Adapt spec for new empty identifier * Avoid double error messages for empty identifier acts_as_url may return an empty string depending on the name, but the empty presence validation will suffice in this case, we don't need the invalid validation * Fix stubbed errors object accessed by acts_as_url * Avoid trying to get the upstream unique attribute in case of errors * Remove sequential_project_identifiers setting * Adapt spec to review feedback	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043) ... Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	bf89e934b3	set the default value for newly build custom values ... Most of the time, the getter #custom_field_values is used with unbeknown to the caller will build custom values for not covered custom values. This method always assigned nil to the value of the newly build custom value when it should have used the default value. Once that is fixed, all models including acts_as_customizable will again have set the default values for custom fields correctly. This is true regardless of wether the custom value is added before or after the creation of the model. Only for work_packages is the additional method #set_default_values! required as the availble_custom_field might change during a request upon a switch in project and/or type.	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	dccd6c0b92	wip - bcf api topic#create	5 years ago
ulferts	cd3ffe0cc5	adapt specs to altered interface	5 years ago
Oliver Günther	7fb86810db	Fix status and status attribute parsing in representer oncemore	5 years ago
Oliver Günther	42d34a56c3	Fix status parsing when nil ... Unfortunately, representable is broken when passing null values into the parsing representer. This will result in `property :foo` to be output as `{ foo: nil }` despite having a reader that writes other stuff.	5 years ago
Oliver Günther	e1e9edd668	Fix tests after status / explanation breakup	5 years ago
ulferts	2366d12809	add status to create project form	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
ulferts	57f7da4f39	reuse project services in controller	5 years ago