134 Commits (16d1f5785720bfe87491cc781a3ede67563335a5)

Author	SHA1	Message	Date
Wieland Lindenthal	496253d029	WIP Add migration for flipping clipping planes that were created in OP (#9446)	3 years ago
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431) ... * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
Oliver Günther	d2ce834e23	[37866] Add attachment_created event and webhook (#9418) ... * [37866] Add attachment_created event and webhook * Remove other usages of direct attachment creation * Add attachment webhook spec * Fix other webhook specs * Fix attachment adding in mail_handler * Don't set content_type outside attachment#file= * Fix unrelated spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	3 years ago
Wieland Lindenthal	31c1bdc9f9	Feature #37401: Bump XEOKIT to use XKT files version 8. Migrate all IFC models. (#9300) ... * bump xeokit to xkt version 8 * Bump @xeokit/xeokit-gltf-to-xkt to version 1.3.1 - Remove all logic for extracting and providing metadata JSON - Update seeder - Update seeded XKT demo hospital model files - Update conversion service to join GLTF and metadata into XKT file - Fix feature spec for viewpoints. * Remove specs for metadata attachment checking * Update modules/bim/db/migrate/20210521080035_update_xkt_to_version8.rb Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
Wieland Lindenthal	700d9c5488	Bug #34452: Colors not according to IFC file	4 years ago
Wieland Lindenthal	33443c154e	Update IFC Viewer with latest Xeokit updates (#9207) ... * Bump @xeokit/xeokit-gltf-to-xkt to version 1.0.0 * Bump Xeokit SDK and Xeokit BIM Viewer * Overwrite XEOKIT orthogonal/perspective toggle icon * Add styles for section tool and its menu * Remove SAO deactivation for non default models. Performance of SAO has improved ever since Xeokit's FastNavPlugin was created. * bump xeokit sdk and bim viewer * IFC viewer toolbar adoption for section plane tool. * Fix spec after xeokit bump * Feature 33880 Add Edit/Delete/Add model buttons in Models tab * Paths to xeokit's bim viewer code changed * Bumping xeokit packages * Fix default_spec.rb for scopes	4 years ago
Oliver Günther	e8a0ead6e4	Fix selector on bim theme seeder	4 years ago
Oliver Günther	76eab2f5f4	Change selector on theme seeder ... [ci skip]	4 years ago
Oliver Günther	bee673f6f8	[37037] Fix bim seeder overriding existing theme ... https://community.openproject.org/wp/37037	4 years ago
ulferts	d1f419385f	Feature/member custom notifications (#9173) ... * include custom message in membership forms * keep pristine params to be able to pass it to the state * fix indentation on projects api docs * pass grape instance around in default endpoints The grape instance has readily available access to all the objects (params, current_user) so less individual parameters need to be passed. This also avoids having to store the grape endpoint in a potentials not thread safe variable * send custom message out on membership creation * send custom message on membership update * send custom message even if setting disabled * restore params interface * add custom message description to schema * describe notificationMessage in the api documentation * extract meta payload functionality into mixin * ensure password in spec meets requirements * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	6dc662b1e4	[36243][30226] Different avatars for placeholders and groups (#9169) ... * Fix members autocompleter to allow hrefs * Add rendering of different avatar types * Remove unused code in backend avatar rendering * Add very basic test that the avatar gets customized per type * Allow avatar rendering in the CreateAutocompleter * Restructure avatars into BEM css * Remove avatar-classes in favor of passing size from backend * Remove to avoid confusion We use tracking with both href and , and was introduced to avoid a property called href to be overridden, but that was never a problem before. So from now we can safely use .href * Fix broken principal avatar in user activity * Ensure filters get updated even if the form is not reloaded There was a bug in conditionallyLoadForm that checked the property of link (always undefined) and would thus always reload a form. What we actually need is a form that gets reloaded only when the query link changes, but still update services from the updated query, such as filters * Adapt specs to changes classes * Rename op-principal-avatar to op-avatar	4 years ago
ulferts	f0cf90d7e1	Fix the rails cell not using the content_tag helper of ActionView with escaping (#9067) ... * fixes show links for project members * Properly escapes the name. The cells gem does not escape strings unlike rails * Fixes the case statement for links and includes the link for placeholder users * Fix escaping of content_tag in rails cell and add spec for that Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043) ... Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961) ... * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	a112999dcc	fix ruby 2.7 deprecations (#8867)	4 years ago
Wieland Lindenthal	5b084dccd7	Fix: Always allow custom styles when in BIM edition (#8813) ... This fixes the following bug with BIM Community Editions (in other words: no Enterprise Edition, but BIM Edition). A package based installation in which the "bim" edition was selected did not show the BIM theme. Instead it showed the normal OP theme. This PR - extracts the check if custom styles shall be applied to a helper. - adds a spec for the new helper.	4 years ago
ulferts	4dd8e433b4	Fix/bump gems (#8770) ... * bump aws-sdk-core * bump danger * bump parser * bump grape - stream related header setting bug has been fixed * reapply cache headers on stream as grape insists on niling them * bump aws-partitions * bump regexp_parser * bump rubocop * bump webmock	4 years ago
Markus Kahl	35d5759397	require login to finish direct upload (and set file name) (#8796) ... * require login to finish direct upload (and set file name) * require login to upload ifc model (redirect to login if needed)	4 years ago
Wieland Lindenthal	e31cdfbec2	Fix updating of IFC models (#8791) ... * Fix: Correct version pinning for gltf2xkt and improved BIM setup_dev script (inspired by Cyril's docker/setup/preinstall-common.sh * Fix: libSass conform @extend * Fix IfcModelController when updating a model * Refactor IFC Model Update Service and adopt spec.	4 years ago
Wieland Lindenthal	e5dd5dbc5b	Fix: Files can be empty	4 years ago
Wieland Lindenthal	1cebc5d282	Fix: On direct upload the file name could be empty ... when updating a model's title only.	4 years ago
Wieland Lindenthal	4f64591d89	Fix: Wrong existence check for a jQuery object.	4 years ago
Wieland Lindenthal	da876e4fec	Fix: Remove obsolete required params when using direct upload	4 years ago
Wieland Lindenthal	848b412225	Fix: On update of IFC model don't lose title changes.	4 years ago
Wieland Lindenthal	f40f57af9d	Fix: Trigger IFC conversion for model updates	4 years ago
Wieland Lindenthal	c860b5df42	Renaming return value from service to service_result ... The name before "call" was confusing me with the method call.	4 years ago
Wieland Lindenthal	07febc9f0f	Extract printing and putting the status to of seeding	4 years ago
ulferts	3b0f7367fd	move to proper module	4 years ago
ulferts	27b41a313c	replace custom i18n function in views	4 years ago
Wieland Lindenthal	a93bf6d336	Order viewpoints by creation date asc. ... A BCF issue lists viewpoint. We need to make sure that the order stays predictable.	4 years ago
Markus Kahl	0b291528e8	make sure to compare strings since comparing a path and a string will ... fail	4 years ago
Markus Kahl	bbae15a6cf	fixed 'same file' error that occured when trying to convert a file called 'model.ifc'	4 years ago
Markus Kahl	0199dcdf5d	only show actual IFC files	4 years ago
Markus Kahl	f9c32e4a05	do not delete tmp file if storage is local because it has yet to be copied	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling ... Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models ... Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	2de6c6ee82	[33867] Remove old bim seeder ... The bim plugin was extended with a theme seeder that sets the new BIM theme. It however also had a seeder that seeded the dark theme for whatever reason. Probably because a CustomStyle was needed for the (now removed) patch to work. https://community.openproject.com/work_packages/33867	4 years ago
Oliver Günther	623f8c772e	Move module assets to frontend	4 years ago
Oliver Günther	250466db5a	Use a seeder for the BIM theme	4 years ago
Oliver Günther	07f023c71d	Replace sass variables with css variables ... We output CSS variables for easier styling anyway, so we can remove sass variables and the `varprop` mixin now that all supported browsers also support CSS variables.	4 years ago
Henriette Darge	2f8c303df2	WiP: update some paths and start resolving sass vs. css variable problem (both were previously generated in ruby)	4 years ago
Inga Mai	2e5d4e249b	Align toolbar with other elements on mobile and prevent viewer from overlapping page	4 years ago
Inga Mai	00a3a02dba	Hide some toolbar buttons, keyboard and nav cube on mobile	4 years ago
Wieland Lindenthal	6ba3e4d744	Fix double render bug in BCF XML import	4 years ago
Wieland Lindenthal	6a8c60a524	Fixing several issues with the BCF XML import ... - Enforce uniqueness of BCF GUIDs throughout an OP instance. - Regression: The configuration dialogue can now have multiple steps again. - Regression: The importer gets propperly configured with default options when no configuration steps get triggerd.	4 years ago
Wieland Lindenthal	9cf38041ff	Fix-Regression: BCF-XML import adding existing users ... https://community.openproject.com/projects/bim/work_packages/33540	5 years ago
Wieland Lindenthal	5fc190b40e	update xeokit bim viewer and xeokit sdk	5 years ago
Markus Kahl	28a15d2665	allow 512MB attachments in BIM edition by default	5 years ago