7369 Commits (18e4c37cf380cc58de5b778ee0606389ec4e2187)

Author	SHA1	Message	Date
Oliver Günther	5365c53f31	[37729] Avoid manually serializing the filters object ... https://community.openproject.org/wp/37729	3 years ago
Oliver Günther	61e3c9bfe3	Run SettingMacros as a manual filter before markdown ... The markdown filter will break on creating links from the new syntax	3 years ago
Oliver Günther	c3e57f79ea	Use alternative {{ ... }} syntax	3 years ago
Henriette Darge	8190aee87f	Wait for close icon to appear before registering the click handler	3 years ago
Oliver Günther	a0841ac6cf	[38323] Remove linebreak for shorter journal diffs ... https://community.openproject.org/work_packages/38323	3 years ago
Oliver Günther	edfe2fe68c	Add spec that errors object differs	3 years ago
Oliver Günther	ca0629f5cf	Fix service specs	3 years ago
Oliver Günther	83253981d2	[38325] Using existing gem for email validations ... Our email validation is too strict for RFC compliant emails. Instead of trying to do it ourselves (email validation regexps are hard!), let's just use a gem to do that for us. Note: The gem also has a strict mode that could be optionally enabled. This however results in some emails on community to become invalid. I left it on the default mode for now. https://community.openproject.org/work_packages/38325	3 years ago
Oliver Günther	d4bba680a3	[38121] Fix logic when datepicker today link is shown ... When the end date is empty, always show the start date today button and vice versa. https://community.openproject.org/wp/38121	3 years ago
Oliver Günther	5ccb5af99e	Use the setting formatter to replace the static base url	3 years ago
Oliver Günther	ee95ed34ed	Add macro helper to format settings and base url	3 years ago
Oliver Günther	a1f1bf2c50	Add status to mail digest	3 years ago
Oliver Günther	4667ba0aee	[37729] Avoid manually serializing the filters object ... https://community.openproject.org/wp/37729	3 years ago
ulferts	c0452ca90e	prevent self notification unless activated	3 years ago
Oliver Günther	b7874852ec	Delete the notification when the WP gets destroyed	3 years ago
Oliver Günther	b415c3771f	Fix specs using a nil user context	3 years ago
Oliver Günther	a87031982b	[38077] Skip rendering initial journal details in notifications ... https://community.openproject.org/wp/38077	3 years ago
Oliver Günther	60989f7532	[38135] Improve no-results message for unread notifications ... https://community.openproject.org/wp/38135	3 years ago
Oliver Günther	5d52ac0a26	Replace and delete users in notifications once deleted ... https://sentry2.openproject.com/organizations/sentry/issues/480	3 years ago
Oliver Günther	4bb8b9c325	Avoid returning all users for watcher_recipients (#9513) ... * Avoid returning all users for watcher_recipients * test #watcher_recipients of acts_as_watchable Co-authored-by: ulferts <jens.ulferts@googlemail.com>	3 years ago
Henriette Darge	030d3a2be2	Add type "OnboardingStep" to avoid use of "any" and calm eslint	3 years ago
ulferts	0761a98b4c	exclude deleted work packages from digest rendering	3 years ago
Henriette Darge	25fd8542e3	Add test case for users who lack permission to see certain tour parts && User localised strings in tests, too	3 years ago
luzpaz	2ae53bd252	Fix typos in user facing and non-user facing code (#9497) ... * Fix typos in user facing and non-user facing code Found via `codespell -q 3 -S ./config/locales -L ba,nd,parms,sur,varius` * Fix strings in specs	3 years ago
Oliver Günther	c683af254c	[38066] Use the services to update the user ... https://community.openproject.org/wp/38066	3 years ago
Oliver Günther	d103b709ca	[38072] Disable already selected projects in notification settings ... https://community.openproject.org/wp/38072	3 years ago
Oliver Günther	7382822e12	[38085] Also send ATTACHMENT_CREATED on direct upload completed ... https://community.openproject.org/wp/38085	3 years ago
ulferts	2b43c550b3	avoid creating a journal for a to be destroyed work package ... Work packages with attachments where saved once for every attachment upon destruction. This led to custom fields being rewritten and a journal being created. Those created records where removed right away, since the work package was destroyed so the problem was only perceivable as poor performance. On the other hand, we had reports of users not being able to destroy work packages. While it is pure speculation that this change fixes the problem it at least makes deadlocks less likely since journaling is performed with a mutex and that no longer takes place now. The `after_remove` callback is no longer necessary as journaling is triggered in the services now.	3 years ago
ulferts	938c6e5619	exclude full text columns from attachment model ... Currently, the fulltext columns `fulltext`, `fulltext_tsv` and `file_tsv` are never displayed in the application. As such they are currently purely used internally when the are involved in the fulltext search. Having them included in the AR model Attachment will lead to a lot of data being loaded. Such a column can contain megabytes of data. This is costly twice: when fetching the data from the database and when instantiating the model in ruby. As the data is never displayed, they can be ignored for now using `ignored_columns`. This changes the SQL for fetching from `SELECT "attachments"."*" ...` to `SELECT "attachments"."id", "attachments"."file" ...` (without the excluded columns) The alternative would have been to create a new table for the fulltext information and this might still be an option once the requirements on the columns increase. For now, this change is simpler.	3 years ago
Oliver Günther	31726649d4	[38062] Avoid sending notifications with no ian reason	3 years ago
Oliver Günther	351cc7f969	[38062] Avoid sending notifications with no ian reason	3 years ago
Henriette Darge	76a6cf3208	Allow editing list CustomFields even if they do not allow MultiValues (#9474)	3 years ago
Henriette Darge	3589f74858	Avoid that `replace()` is called on a boolean as it causes an error	3 years ago
Oliver Günther	f7c2644f53	Fix auth source login when user changes	3 years ago
Oliver Günther	b75fbcfc4e	Render error pages using our own templates (#9455)	3 years ago
Oliver Günther	b7696a6c5c	[37553] Make user run through authentication stages after header SSO (#9458) ... https://community.openproject.org/wp/37553	3 years ago
Behrokh Satarnejad	133c0136c1	Using BEM methodology to change the styles (#9401) ... * change some of stylesheets * change the style naming * resolve the error * improving the previous commit with Ben's comments * improve the styles of breadcrumb * change the stylesheet related to status button * refactoring css stylesheets of wp single card * fixing the errors of PR, correct selector * change some of stylesheets * change the style naming * resolve the error * improving the previous commit with Ben's comments * improve the styles of breadcrumb * change the stylesheet related to status button * refactoring css stylesheets of wp single card * fixing the errors of PR, correct selector * resolve the error on PR related to boards onboarding * wp relation and list view style changes * resolve the errors of previous commit * fix error in selecting wp relation * fix the errors of wp relations ruby tests * change the stylesheets of autocompleter and wp calendar * change the style of grid page * Some improvements to the BEM styling * Prefix draggable-autocomplete BEM block with op- * Fix spec selector * Fix spec selector Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	3 years ago
Oliver Günther	843779c483	[38017] Don't remove group users if no replacement provided ... https://community.openproject.org/wp/38017	3 years ago
ulferts	75bb809ad6	Feature/1899 send daily email summaries (#9430) ... * email digests * use time for notification digest setting * safeguard against empty digest	3 years ago
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431) ... * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
Birthe	452df1fc8e	Updating texts for onboarding tour (#9393) ... * Updating texts for onboarding tour [#37656] Online Trial - Review onboarding guide -… …Demo project - English https://community.openproject.org/work_packages/37656 * Fix spec Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
ulferts	0666c89828	Feature/35708 wp typeahead filter (#9426) ... * breakup wp resource specs into separate files * introduce and employ typeahead filter on work packages Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Oliver Günther	c35c81d60b	[32867] Generalize me associated action for custom fields (#9443) ... https://community.openproject.org/work_packages/32867	3 years ago
Henriette Darge	daebe0e9e4	* Update modal class and remove old/obsolete styles (#9438) ... * Fix appearance of time entry configuration modal	3 years ago
Henriette Darge	d34b4517d9	[37939] Pagination style is lost (#9433) ... * Apply BEM styling rules for paginations && fix styling for ruby-created paginations * Add class for actual clickable element in the pagination * Introduce modifiers for positioning items at the start or end	3 years ago
bsatarnejad	8bf215678b	change styles of members widget	3 years ago
ulferts	8be49d1c62	only store notification resons for in app (#9419) ... We currently only diplay it for in app. This might change once digests are introduced	3 years ago
ulferts	bd3f182c3d	adapt specs	3 years ago
ulferts	7779ac9e2b	correct expected links to docs	3 years ago
Oliver Günther	d2ce834e23	[37866] Add attachment_created event and webhook (#9418) ... * [37866] Add attachment_created event and webhook * Remove other usages of direct attachment creation * Add attachment webhook spec * Fix other webhook specs * Fix attachment adding in mail_handler * Don't set content_type outside attachment#file= * Fix unrelated spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	3 years ago