35 Commits (1913775611eacf1eef9024b13a548604e3fccd88)

Author	SHA1	Message	Date
Oliver Günther	2e51c140ad	Avoid additional watcher on display fields ... We can now simply wait for the cache service to return the WP + loaded schema	8 years ago
Oliver Günther	611e42238c	[23896] Submit and close edit mode on enter for most edit fields ... When editing a single field (except select, checkbox), pressing enter triggers the `submit` handler of the surrounding form. This form submit is disabled when in edit mode, since the wp-edit-field uses that submit also for saving on blur, which we deliberately disable in this case. We can instead capture another event on those fields where it makes sense that submits the field after pressing enter, but only IN edit mode (since without it, submit handles it). https://community.openproject.com/work_packages/23896	8 years ago
Oliver Günther	3ce2a2a807	Do not show overflow in table edit-fields	8 years ago
ulferts	344c0c92ab	Fix/activate inplace edit in ie (#4560) ... * no longer require an isolated scope for clickOnKeypress As that directive is so small and is oftentimes used on the root element of a directive, having an isolated scope limits the usage of directive * reapply click-on-keypress to trigger inplace edit Otherwise, the IE will not be able to trigger the element	9 years ago
ulferts	1d99206232	Fix/accessible error messages (#4529) ... * add error messages to each field * move role=alert up so that success messages are also covered * remove focus code from notification-box directive The box does not need to be focused as it has the role=alert which will lead to it being read out. * remove specific focusing behaviour for accessibility mode The mode was introduced to present error messages to user requiring assistive technology e.g. screen readers. By setting role=alert on the error fields and additionally labeling the fields with the errors, this should no longer be necessary	9 years ago
Jens Ulferts	43a4ecce5d	remove wpEditField dependency from wpDisplayAttr	9 years ago
ulferts	104f918796	provide role attribute so that ngAria does not set it to "button" (#4518)	9 years ago
Roman Roelofsen	ae6087e9f0	Removed timeout defer	9 years ago
Roman Roelofsen	57e98024bb	WIP reducing watcher count	9 years ago
Roman Roelofsen	210379367f	WIP reducing watcher count	9 years ago
Oliver Günther	67c1cc154c	Cherry pick @og refactoring	9 years ago
Roman Roelofsen	e0bf811f77	Reduced watchers count, needs review!	9 years ago
Roman Roelofsen	8985c910f7	Reduced Watcher Count	9 years ago
Oliver Günther	a1755f3ef3	Avoid click propagation from active edit-fields (#4428) ... Avoid clicks within the form to bubble up to the row handler. Otherwise, clicks within wp-edit-fields may cause the split / full view to open.	9 years ago
Oliver Günther	650b5f4159	Implement edit-all through wpEditForm	9 years ago
Jens Ulferts	23515190cb	restyle subject on the wp.show	9 years ago
Jens Ulferts	e5d874a966	Accessibility for wp-edit fields ... * Hidden label for all fields once they are activated * aria-labelledby for all fields when they are in read mode * turned visible attribute text on split/fullscreen to be clickable so that it behaves like a label	9 years ago
Oliver Günther	2c26ecdeec	Toggle preview without saving the description	9 years ago
manuschiller	999ea625e4	-small class removed for formattable fields	9 years ago
Alex Dik	9c65e7d7d5	Fix wp-edit-field directive template	9 years ago
manuschiller	6b1d45ac00	textile service adaption	9 years ago
Oliver Günther	cdbcf7c439	Fix subject-editor spec ... This does not yet fix the focussing tests, which rely on functionality not yet existant here.	9 years ago
Oliver Günther	f9fe1a5d79	[22916] Inline edit only on attribute text, double click to fullscreen ... * Reduce editable field to wp-table--cell-span * Allow macs to CMD-click for multiselect * Set double click to full screen * Set focus expectation to anchor * Fix flickering in inline expectation * Update selector for double clicks * Simplify innerMostSpan * Add spec for double click full view	9 years ago
Oliver Günther	c2d0828c98	Make escape cancel edition and restore pristine value	9 years ago
Henriette Dinger	3fa34c38c5	Introduce -small class for smaller inplace editing fields	9 years ago
Henriette Dinger	0631162702	Fix bug with column width and avoid overflow of text	9 years ago
Oliver Günther	cc315c2194	Add very basic error styling	9 years ago
Jens Ulferts	aa0a0d28b3	remove wp-edit directive instance if field is not active	9 years ago
Oliver Günther	3043fcae79	Add very basic error styling	9 years ago
Jens Ulferts	2c939e631c	split up wp-edit-field.directive.html into separate files	9 years ago
Oliver Günther	1647a8ecc1	Track by 'null' object which is transformed before saving ... The track by causes a 'null' href to land in the wp resource for changed links which is not accepted by the API.	9 years ago
Oliver Günther	b1a307ef96	Track objects by href and set self link ... This adds the self href attribute to a HALResource whenever the object has a self link. This is used for tracking, e.g., selected objects.	9 years ago
Oliver Günther	09beabdaea	Show default placeholder when no value in td	9 years ago
Jens Ulferts	08da8ef7bf	prevent trying to get into edit mode when user is not allowed to edit	9 years ago
Alex Dik	332822376a	Prevent selection click when editing field	9 years ago
Alex Dik	4a9702f614	Move the wp-edit-field files in their own directory	9 years ago
Jens Ulferts	0a9cd71f09	add aria-required on inputs ... This is based on the work_package schema. There is a dedicated directive for this so that we can easily extend this to also have additional attributes (e.g. required, maxlength, ...). For now those restrictions have not been added because we have no way as of now to present them in the way we present other errors as well. Therefore, we are waiting for the api to return the errors for now.	9 years ago
Alex Dik	e8132be44b	Rename the select field's allowedValues property to options	9 years ago
Alex Dik	fcc2cd39a6	Implement first version of the WP edit module ... Disable links in the WP td directive as to prevent opening the details view. Also disable the table single-click handler to prevent confusion. This actually might be introduced back again, but can stay disabled for development.	9 years ago