217 Commits (19f3279b807f04fdc8df0f8c7404da7f738036ad)

Author	SHA1	Message	Date
Oliver Günther	612572190a	Remove notified events	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	edf0189809	Remove legacy preferences specs as doubled	3 years ago
ulferts	1f024e5796	remove no_self_notified user preference	3 years ago
ulferts	63ad2e8dd1	Generate IAN near real time (#9570) ... * destroy notifications upon journal destruction * breakup spec by journable * have a dedicated job for scheduling journal completed events * generate notifications in delayed job * route wiki journal events through notifications * combine mail sending for notifications into single job * robustness if a journal is deleted * linting * differentiate BaseJournal and AssociatedJournal BaseJournal holds the data of a journal that reflects the columns in the journaled model while AssociatedJournal reflects the columns of a model associated to the journaled model via a has_many/one association * route news journal events through notifications This does not yet include notifications for comments on news * include news comment in notification workflow * have the whole workflow in a single state machine job * include forum message in notification workflow * include document in notification workflow * less dependencies from acts as watchable * fix, test and document workflow job	3 years ago
ulferts	a1074bcb93	add work package created notification setting	3 years ago
luzpaz	2ae53bd252	Fix typos in user facing and non-user facing code (#9497) ... * Fix typos in user facing and non-user facing code Found via `codespell -q 3 -S ./config/locales -L ba,nd,parms,sur,varius` * Fix strings in specs	3 years ago
ulferts	8be49d1c62	only store notification resons for in app (#9419) ... We currently only diplay it for in app. This might change once digests are introduced	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399) ... * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit e29dced646 Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit 1a45c26c1a Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit 0ea21e90c1 Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in 0d6c0b6bc7 * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
ulferts	9e66604dec	allow project identifier to begin with numbers (#9377)	3 years ago
Oliver Günther	c9a80b8653	[#37299] Remove validation for project identifier presence (#9296) ... [OP#37299](https://community.openproject.org/wp/37299)	4 years ago
Oliver Günther	6c75e16dc4	[37140] Use acts_as_url to generate unique slug for identifier (#9250) ... * Use acts_as_url to generate unique slug for identifier * Re-enable project identifier spec now handled in backend * Add integration spec for set attribute service * Adapt spec for new empty identifier * Avoid double error messages for empty identifier acts_as_url may return an empty string depending on the name, but the empty presence validation will suffice in this case, we don't need the invalid validation * Fix stubbed errors object accessed by acts_as_url * Avoid trying to get the upstream unique attribute in case of errors * Remove sequential_project_identifiers setting * Adapt spec to review feedback	4 years ago
ulferts	5cb227796c	Fix/hook service to openproject (#9214) ... * move specs from legacy * move Hook into OpenProject namespace * replace class variables	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958) ... * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	15f5c21594	replace legacy specs	4 years ago
ulferts	a1a37d31bb	replace legacy spec	4 years ago
ulferts	7e68bd8ce1	avoid nil for wiki page slugs as they would be invalid (#9081) ... * avoid nil for wiki page slugs as they would be invalid Also explicitly enables having "!" for a wiki title but fails hard for all cases, which are not handled by default or custom. * move legacy specs over	4 years ago
schuemann	b577ed62ec	[#36518] respect hide mail preference in member list (#9072) ... * [#36518] respect hide mail preference in member list The member table should hide the email address if the user has the "Hide my email address" box checked in their profile. * [#36518] respect hide mail preference in member list Updating feature spec * Updating feature spec * Add transient preference object * Include preference to avoid n+1 query * Correctly pass user_id= to super * Fix now invalid usages of user_preference factory * Rewrite attribute check to include user attribute_present? does not return true for relations such as user_id * Only save a preference if the transient factory got used Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961) ... * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	e4c9506e56	[36081] Increase max lengths of user/group names (#8948) ... * Unset DB limits for user attributes * Validate groups in synchronized groups * Extend limitations and fix specs	4 years ago
Wieland Lindenthal	efbd3e9b41	Placeholder user backend (#8935) ... * Add missing copyright note to AnonymousUser [ci skip] * Addin PlaceholderUser model and its associations * Ensure PlaceholderUser do not "leak out" uncontrolled * Extract Associations for User and PlaceholderUser. - remove obsolete #assigned_issues - remove obsoete #:responsible_for_issues - add specs and factory for PlaceholderUser Adding specs to PlaceholderModel * Migration: enforce uniqueness of lastname for Group and PlaceholderUser * Remove obsolete callback `after_add` on groups association. The association of principals and groups still had a callback `after_add` that called a method `user_added` on the group. That method was not defined anymore as it was removed in commit d93ff52a27. * Move validation for #groupname to the right spec. * Cleanup placeholder and group specs * Remove Setting `workpackage_group_assignment` * Refactoring: Extract assignable scope from Project to Member * Refactor: Add Member scope not_locked. * deprecate hacky scope * remove wp_group_assignment specific test case Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	7e10047827	Fix removed LdapError error class	4 years ago
ulferts	a27440eed4	remove legacy spec covered by current specs	4 years ago
ulferts	7da7cfc398	replace removed update_attributes method	4 years ago
ulferts	17239f6e99	adapt to altered view initialize interface	4 years ago
ulferts	a112999dcc	fix ruby 2.7 deprecations (#8867)	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765) ... * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	5968c0b18a	Fix/replace custom i18n function (#8681) ... * replace custom i18n function calls * remove custom i18n method	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557) ... * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
Oliver Günther	95d1549858	Move legacy project copy spec to service spec	4 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
Oliver Günther	80e747e0c6	Fix test by calling service with system user ... Adds this to the factory to avoid using the system user all over the place	5 years ago
Oliver Günther	e4dcc6c5ea	Avoid usage of `users <<` pattern in group ... This will no longer trigger the addition	5 years ago
Oliver Günther	a8c6e45a92	Add LDAP auth source filter functionality	5 years ago
ulferts	cf735714d3	order independent contains operator (#8315) ... * order independent contains operator This for example affects the search which relies on the subject filter with the contains operator being active. * remove legacy query spec The query is generally covered rather well in the new specs. [ci skip]	5 years ago
ulferts	e5749d9817	order independent contains operator (#8315) ... * order independent contains operator This for example affects the search which relies on the subject filter with the contains operator being active. * remove legacy query spec The query is generally covered rather well in the new specs. [ci skip]	5 years ago
ulferts	973ebd1fac	replace legacy specs	5 years ago
ulferts	64d0f57d85	Feature/aggregated activities (#8221) ... * use cte for aggregated journal * Revert "use cte for aggregated journal" This reverts commit 5fedefefdd. * add another subselect that could later on be provided from the outside * allow passing a nukleous sql to aggregated journals * wip - using aggregated journal for activity * new sql for aggregated journals * start implementing new aggregated query * additional documentation * consolidate activity functionality * simplify by turing into instance methods * move activity fetcher out of redmine * remove verb verification made obsolete Without catchall routes, the dispatching handles it * remove duplicate authorize check * refactor activities controller * refactory activity fetcher * cache avatar file * sort choosable events * remove legacy spec covered by contemporary * speed up aggregated journals via CTE * instance var might never have been set * ensure the event_types are always transmitted * correctly reset the avatar cache * fix avatar fetcher expectation regarding wiki pages * adapt spec [ci skip]	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
Oliver Günther	da52a19bab	Remove duplicate type_standard "None" and "none" in legacy spec	5 years ago
ulferts	399e8c3ed9	rename according to zeitwerk	5 years ago
Oliver Günther	fa25c0ec21	Remove magic start_date applied to version, but not saved to DB ... [ci skip]	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	7d4a4a19e7	use join table for storing activites active in project	5 years ago
ulferts	4ed1dbe7f7	rewrite legacy specs for wiki_content	5 years ago
ulferts	1d7f013f89	rewrite legacy status specs	5 years ago
ulferts	c73fc1b772	rewrites #format_date legacy specs	5 years ago