160 Commits (1a071e69f2c13844afb51c3a8f6b311b9bab329b)

Author	SHA1	Message	Date
Oliver Günther	612a1809f4	Confirmed that UTF-16 incorrectly returns nil ... This commit adds a spec for the UTF-16 invalid detection as binary, which is consistent with previous behavior, but the whole content encoding problem should be addressed.	9 years ago
Oliver Günther	bfa0c4d69d	Extend repository with UTF-16 encoded file, extend specs accordingly	9 years ago
Oliver Günther	86f847043b	Allow configuration to disable arbitrary SCM types ... This commit provides: - Configuration options for disabling any number of available types of that particular SCM vendor. - Changes to the underlying structure to allow determination of which types are available on a class level.	9 years ago
Oliver Günther	9336cff8bb	Extended specs ... This commit adds / extends the following specs: RepositoriesController: Ensure empty repository page is shown for empty repositories adapters/subversion: Test correct use of --login, --password arguments	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter ... This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	61d77c721b	Fix TextFormatting#format_text specs w/requests ... * Make intent slightly clearer with a shared context. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Florian Kraft	ccb2a6032e	repair legacy specs ... fix the application helper legacy spec fix text formatting spec to reflect anchors only mode w/o request Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jan Sandbrink	c4e51404c2	move uploaded file creation out of api endpoint	10 years ago
Markus Kahl	2a465785d1	allow digit-only but not empty passwords	10 years ago
Markus Kahl	7e40c11ca4	moved strategies; refactoring	10 years ago
Alex Coles	3276c4ebb5	Add/update Copyright headers in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	8e32063189	Minor whitespace fix in FormTagHelper spec ... [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	3de4f651c3	Fix #styled_label_tag default titles without block ... With content passed as an argument this never worked as planned (see commits 178e2825, f2cb3805). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	c5161ae0ef	Add spec for TextFormatting {{toc}} macro parsing ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	fce72938e3	prevent path traversal via filesystem scm ... Setting up a filesystem scm now requires to specify a whitelist via the configuration	10 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Florian Kraft	178e282576	update the form tag helper to allow for default title in label	10 years ago
Alex Coles	3785fdc9ed	Use #describe, #context with String arg not symbol ... The semantics of `describe` have changed in RSpec 3: passing a symbol rather than a string will change the value of the described object. See discussion here: https://github.com/rspec/rspec-core/issues/1114 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	944b89d83e	Convert specs to RSpec 3.2.0 syntax with Transpec ... This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 34 conversions from: it { should ... } to: it { is_expected.to ... } * 14 conversions from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: be_true to: be_truthy * 3 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: failure_message_for_should { } to: failure_message { } * 2 conversions from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: Klass.any_instance.stub(:message => value) to: allow_any_instance_of(Klass).to receive_messages(:message => value) * 1 conversion from: be_false to: be_falsey * 1 conversion from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: stub('something') to: double('something') * 1 addition of: RSpec.configure { |c| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Jan Sandbrink	365f7d78b4	disable a test that is a evergreen	10 years ago
Alex Coles	7ab52030e3	Use #be_html_eql matcher in FormTagHelper spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	3193fc6d31	Move PrincipalAllowanceEvaluator spec into place ... * Replace deprecated ChiliProject constant. See e3913ac8. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	dd67b3bf8e	hide the real name of the plain format	10 years ago
Jan Sandbrink	6b3ee56936	add more specs	10 years ago
Markus Kahl	c84b80bd8c	make array always return an array	10 years ago
Jan Sandbrink	497f084e5d	fix flickering repository tests	10 years ago
Solotchi Veaceslav	19a8e31833	Spec tests	10 years ago
Alex Coles	21503e89e5	Add OpenProject::FormTagHelper with styled helpers ... Provides most of the helper methods provided by `ActionView::Helpers:: FormTagHelper`, but with relevant CSS classes, wrappers applied. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Markus Kahl	2e4b80daab	whitespace/quotes	10 years ago
Markus Kahl	f18f896a1a	spec OpenProject::Files	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Markus Kahl	63957c55f7	more flexible prefix	10 years ago
Markus Kahl	ea52b14756	don't hardcode ENV as source for config override	10 years ago
Markus Kahl	661d89f5fe	allow nested config env override and addition of new values	10 years ago
Alex Coles	d99fcef54e	Update asset paths in Themes specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	349031315f	Update HTML attribute order in TextFormatting spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Martin Linkhorst	a2754921dd	make Hound happy (and Markus)	10 years ago
Martin Linkhorst	c43f84ad1b	#after_login can now receive a context variable (usually the controller)	10 years ago
kgalli	3e2cdf1ca7	Add quick fix for load_config_from_file ... The whole test should be refactored. I suggest using a real life example of the configuration.yml instead of stubbing its content.	10 years ago
Alex Coles	879fcd49f6	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.6 with the following command: transpec -f * 66 conversions from: it { should ... } to: it { is_expected.to ... } * 53 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 20 conversions from: == expected to: eq(expected) * 19 conversions from: obj.should to: expect(obj).to * 7 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 7 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 7 conversions from: its(:attr) { } to: describe '#attr' do subject { super().attr }; it { } end * 5 conversions from: obj.should_not to: expect(obj).not_to * 4 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 3 conversions from: be_true to: be_truthy * 2 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 2 conversions from: its([:key]) { } to: describe '[:key]' do subject { super()[:key] }; it { } end * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: be_false to: be_falsey * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 1 conversion from: it { should_not ... } to: it { is_expected.not_to ... } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Hagen Schink	5aa71b8a6b	Fix API representer extension	10 years ago
Alex Coles	1633e0f419	[wip] Add .extend_api_response to ActsAsOpEngine ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	1ea5637b8f	Add skeleton spec for OP::Plugins::ActsAsOpEngine ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago