267 Commits (1b5fc3236688bbdca855a50296769390991ff734)

Author	SHA1	Message	Date
Oliver Günther	5de0b9a2d8	Go through brakeman warnings	6 years ago
Wieland Lindenthal	9be3d50029	Remove more "titles only" logic and adopts specs	6 years ago
Wieland Lindenthal	57d86b4a3f	WIP: Add attachment fulltext and filename to old rails search. ... - add "All" tab - remove "titles only" - remove "all words" option and make it default.	6 years ago
Oliver Günther	326a9f5430	Block attachment modification	6 years ago
Jens Ulferts	060e2ea692	linting	6 years ago
Jens Ulferts	f3622b2ac8	remove code duplication	6 years ago
Jens Ulferts	77b4863d09	fix journalizing detection for multi field cfs	6 years ago
Oliver Günther	42584aeae3	[28186] Fix formatting journal details in no_html_mode ... https://community.openproject.com/wp/28186 [ci skip]	6 years ago
Jens Ulferts	0d22112e0e	replace rails based attachment forms and lists completely	6 years ago
Jens Ulferts	abda9056cd	add attachment on new resource via rails form	6 years ago
Oliver Günther	be81613e27	[27947] Filter by commit date for changeset activity provider ... Currently, changesets are filtered for to/from values by their created_at date. That however is the time of the import to the database, not the actual commit data. Instead, we should filter for the commit date to get proper responses. https://community.openproject.com/wp/27947	6 years ago
Jens Ulferts	01c4fcc7f3	linting	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Jens Ulferts	d04b86da9c	introduce custom eager loading for work package list ... Reduces the amount of AR models instantiated when handing wp#index requests by: * Calculating part of the checksum for caching in the db. This is done by using the id and the updated_at/on field of associated models whose representation is cached in the wp representer. * Reusing instantiated models for multiple associations. e.g instances of Project are used in various places (the work package itself, it's ancestors and children). Instead of using Rails' eager loading which would instantiate a project potentially once for every association path, the code now assigns the same instance to all those associations. Additionally, the commit streamlines the creation of custom field injected representers. Now only one class is created for all work packages when before it would be one class for every uniq set of custom fields. On top of that, the class can be reused if the set of custom fields does not change.	7 years ago
Henriette Dinger	e064bb7af8	Increase contrast between differences in journal (#6194) ... [ci skip]	7 years ago
Oliver Günther	3a16ef53c9	Fix invalid / outdated events causing internal errors ... https://community.openproject.com/wp/27285	7 years ago
Jens Ulferts	b3a11a0fd9	replace deprecated references to changes in after_save hooks	7 years ago
ulferts	ffb99fad6e	remove locked users from possible watcher list (#6202) ... [ci skip]	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
ulferts	e8930af3e9	Fix/copy project with required custom fields (#6083) ... * remove no longer required before_action * fill custom_field_values on project copy The option, whether to copy custom_values is replaced by always filling in the values from the copied from project * copy wp custom fields on wp copy * refactor projects copy controller [ci skip]	7 years ago
ulferts	a8c1953cf5	always return a custom value if it is available in the customizable (#6075) ... [ci skip]	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag ... Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533) ... * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
ulferts	9414241dfb	show error message if activity cannot be saved (#5678) ... [ci skip]	7 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	8fcfc834a3	[25269] Add typed_custom_value_for to retrieve CF value names ... To provide a common interface to get _ALL_ values for the given custom field id (either multi or single value), this PR adds `typed_custom_value_for` which maps all custom_values (if any) to their `typed_value`s. This is a requirement to output all values in `QueryCustomFieldColumn`.	8 years ago
ulferts	c9bd9c238e	replace some occurances of alias_method_chaining (#5449) ... [ci skip]	8 years ago
Jens Ulferts	56b41a8b95	fix altering values of multi list cf	8 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	7fff018c17	avoid repeated custom_field getter/setter method creation	8 years ago
Jens Ulferts	ba37136379	enforce project association on acts_as_watchable	8 years ago
Jens Ulferts	f833cd2753	add test for mysql flag	8 years ago
Jens Ulferts	2dd3a9a339	use AR .arel_table to avoid deprecation	8 years ago
Jens Ulferts	78cdd9c720	replace vendored acts_as_tree by gem	8 years ago
Oliver Günther	fe0e8dd919	Rename before_filter to before_action	8 years ago
Jens Ulferts	3246747ae0	adapt to newly introduced query	8 years ago
Jens Ulferts	ff3ecc9e59	employ sql based user allowed scope for acts as watchable	8 years ago
Oliver Günther	2454624fde	Retain partial message for custom field to customizable	9 years ago
Oliver Günther	01e1141139	Use pre-generated error message from custom field ... Instead of generating a new error message when applying custom field errors on the customizable model, simply copy the already existing error message from the custom field, and save the symbol for later API processing. This saves both time and avoids errors when CFs require additional attributes for humanizing the error messages.	9 years ago
Markus Kahl	cac89c8b27	dropped rfpdf to use prawn instead (#4388) ... Dropped the ancient, embedded rfpdf plugin for PDF generation. PDFs generated through that were corrupt and could not be processed by SharePoint for instance. The PDFs are now generated using prawn. May make an update of the openproject-pdf_export plugin necessary which uses an also ancient version of prawn itself (0.14, the current version being 2.1).	9 years ago
Oliver Günther	bb53e2bf0d	Fix Wiki const lookup	9 years ago
Jens Ulferts	cadc397239	create all custom field acessors on representer injection	9 years ago
Oliver Günther	f03728c156	Retain partial message for custom field to customizable	9 years ago
Oliver Günther	9a1ccce4e3	Use pre-generated error message from custom field ... Instead of generating a new error message when applying custom field errors on the customizable model, simply copy the already existing error message from the custom field, and save the symbol for later API processing. This saves both time and avoids errors when CFs require additional attributes for humanizing the error messages.	9 years ago
Jens Ulferts	0980f01a95	copy over symbol in custom value to customizable ... We need to have access to the original symbol so that the API v3 can post process the errors on the custom fields just like it does every other field. When only a string is provided, the symbol :unknown is stored which will lead to the API rendering error messages like "can't be blank" (without the erroneous field name).	9 years ago
Mohamed Wael Khobalatte	46eed651ed	Delete files that do not even parse ... This give us a very low score, to no benefit.	9 years ago
Jens Ulferts	2264d5a345	format floats in journals accoriding to the locale	9 years ago
Stefan Botzenhart	af224c7b82	Ensure spec and features directories exist	9 years ago
Stefan Botzenhart	d68c40366d	Refactor plugin load path helper methods ... As we need to make plugin parallel testable we need to know about loaded plugin paths	9 years ago