openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	90d8dec296	Rewrite duplicated CreateService specs (#8959 ) * Add common base service create service examples * Rewrite user service spec into the common service * Rewrite CustomFields::CreateService spec into common * Rewrite Messages::CreateService into common * Rewrite Projects::CreateService with common example * Rewrite Grids::CreateService spec with common examples * Rewrite BIM::IfcModels::CreateService with common examples * Rewrite Bim::Bcf::Issues::CreateService with new common examples	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	2ad215fed1	add milestone type filter for default project gantt query (#8869 )	4 years ago
ulferts	428d23f267	disregard readonly status on project copy (#8873 ) By moving the readonly status restriction into the `reduce_by_writable_permissions` method, that functionality is disabled (as it is overwritten) when copying projects.	4 years ago
ulferts	f511f8d4f5	set default role when copying project as non admin (#8824 )	4 years ago
ulferts	d5e490efda	set the copying user to be the author of attachments (#8822 )	4 years ago
ulferts	ae2edad19b	Fix/copy project wiki notifications (#8777 ) * rename to convey applicability to all journal notifications * adapt journal completed job to handle wiki content * remove empty module * create wiki_content mail service * introduce copy/create service and contract for wiki pages * specify set attributes and create contract for wiki pages * copy the content attributes * use wiki page create service when copying wiki * introduce specifc service for copying wiki pages The contract disables checks for permissions on the wiki page. The copy_projects permission should suffice to copy everthing in a project * copy wiki pages top down to rewrite hierarchy * limit copied attachments to copied type	4 years ago
ulferts	bf89e934b3	set the default value for newly build custom values Most of the time, the getter #custom_field_values is used with unbeknown to the caller will build custom values for not covered custom values. This method always assigned nil to the value of the newly build custom value when it should have used the default value. Once that is fixed, all models including acts_as_customizable will again have set the default values for custom fields correctly. This is true regardless of wether the custom value is added before or after the creation of the model. Only for work_packages is the additional method #set_default_values! required as the availble_custom_field might change during a request upon a switch in project and/or type.	4 years ago
Oliver Günther	24005a9e6d	[34000] Ensure user custom fields can be copied User CFs were not copiable because they depend on project members being copied. They need to be overridable in the copy form however, so we need to be able to set this before and after members are copied. The only option is to allow visible members to be selected there. https://community.openproject.com/wp/34000	4 years ago
Oliver Günther	6526ca2814	Map filters from api and queries in one filter mapper object This allows mapping the parent filter and other foreign key references that should be updated during copy.	4 years ago
Oliver Günther	4aad0c8b72	Generate URL params for gantt view and insert projects	4 years ago
Oliver Günther	65fe7ce06f	Return the unmapped work package ID in case of wp not copied When a foreign work package is linked, it will not get copied during the project copy service. In this case, just use the original to retain it.	4 years ago
Oliver Günther	cbe57a9e32	Add common \`should_copy?\` method for the project copy service	4 years ago
Oliver Günther	e6a4b1c05c	Add spec for manually sort order	4 years ago
Oliver Günther	95d1549858	Move legacy project copy spec to service spec	4 years ago
Oliver Günther	bbeb911216	Pass contract_options in stubs	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	dccd6c0b92	wip - bcf api topic#create	5 years ago
ulferts	cd3ffe0cc5	adapt specs to altered interface	5 years ago
Oliver Günther	a7ed2e9da0	Rewrite jobs to use ActiveJob syntax	5 years ago
Oliver Günther	7fb86810db	Fix status and status attribute parsing in representer oncemore	5 years ago
Oliver Günther	42d34a56c3	Fix status parsing when nil Unfortunately, representable is broken when passing null values into the parsing representer. This will result in `property :foo` to be output as `{ foo: nil }` despite having a reader that writes other stuff.	5 years ago
Oliver Günther	e1e9edd668	Fix tests after status / explanation breakup	5 years ago
ulferts	fbb6c9dc8f	implement project status updating	5 years ago
ulferts	2366d12809	add status to create project form	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
ulferts	18d0450ee9	use default rails autosave If the custom values are saved (i.e. created) in an after save block, their saved_changes are empty	5 years ago
ulferts	05ac3af1ee	add projects delete end point to api	5 years ago
ulferts	57f7da4f39	reuse project services in controller	5 years ago
ulferts	fc0e5bdfd2	user update service for update identifier action	5 years ago
ulferts	e0dda422e5	add basic specs for project update service	5 years ago
ulferts	821c624d4a	add projects create end point to api	5 years ago
ulferts	0c14477ba4	update project on custom field change	5 years ago
Oliver Günther	369b668e64	Make ProjectsController#destroy use background worker + service [ci skip]	6 years ago

40 Commits (1b725728828458cb9b6609187592ff7782529f97)