openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	0c947da528	remove invalid notifications before setting constraint	3 years ago
ulferts	98d74e00de	ensure notifications are linked to existing journals There can be a race condition when a user continues to alter a work package or other resource after a first change has been made resulting in a journal and the background process creating a notification for that journal. If the second journal caused by the users continued interaction removes the first journal after the job for creating a notification has already started, all checks within ruby are blind. Therefore a foreign key constraint is needed.	3 years ago
Wieland Lindenthal	178e8abe50	WIP Add migration for flipping clipping planes that were created in OP (#9682 )	3 years ago
Eric Schubert	d6b87a2210	[#38833 ] BCF API Comments Service - https://community.openproject.org/work_packages/38833 - added requests tests - added check for expected body length - added representer and api for bcf_comments - added create and set attributes service for bcf_comments - added migration for comment hierarchy - added create and update service for journals	3 years ago
ulferts	57ed3c8fd3	add indices to support finding notification recipients	3 years ago
Oliver Günther	6647c4489f	[38712] Immediate reminder options	3 years ago
Oliver Günther	614de339f0	Remove all unused keys from the settings json	3 years ago
ulferts	062e33be30	have boolean values for warn_on_leaving_unsaved	3 years ago
ulferts	0cee545248	adapt the json_validator from activerecord_json_validator The error messages need to be more fine grained than what can be achieved with the original gem	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
ulferts	d7c399320b	rename batch size env var for migrations	3 years ago
Oliver Günther	1fa9230c8e	Fix default value for hide_mail	3 years ago
Oliver Günther	a75bbb078a	Migrate UserPreference to JSON storage	3 years ago
ulferts	2a6ab15101	add work package scheduled notification setting	3 years ago
ulferts	aabe286e4b	add index on notification settings columns expected to have be distributed unevenly	3 years ago
ulferts	8cfb94be7d	remove work_package_updated from notified_events	3 years ago
ulferts	09f1a37f3c	add work package prioritized notification setting	3 years ago
ulferts	61357f5091	add work package processed notification setting	3 years ago
ulferts	a1074bcb93	add work package created notification setting	3 years ago
ulferts	f246346014	add work package commented notification setting	3 years ago
Oliver Günther	db401c553f	Fix executing the removal of journal_versions The original version does not work correctly.	3 years ago
ulferts	13e418e34e	env var for aggregate journal migration batch size	3 years ago
ulferts	b88fe2349a	increase author as watchers migration performance Instead of instantiating every work package and relying on the watcher model to check whether the adding the user as a watcher is allowed, the code now uses plain SQL	3 years ago
ulferts	e506993c6b	improve performance of polymporphic journal data migration Removing the indices before inserting the data and then readding them later on is faster than updating them while inserting	3 years ago
ulferts	b3bd780c2c	improve performance of aggregate journals migration The purpose of the rather low batch size (the default is 1000) does no longer apply. It was important before the journals where cast to an array in the next line.	3 years ago
Wieland Lindenthal	496253d029	WIP Add migration for flipping clipping planes that were created in OP (#9446 )	3 years ago
ulferts	75bb809ad6	Feature/1899 send daily email summaries (#9430 ) * email digests * use time for notification digest setting * safeguard against empty digest	3 years ago
Oliver Günther	991380b7e5	Extend error message when migration fails due to two schemas	3 years ago
Oliver Günther	a8652d7483	Remove length restriction on CustomField#name	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399 ) * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit `e29dced646` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit `1a45c26c1a` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit `0ea21e90c1` Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in `0d6c0b6bc7` * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
ulferts	2a015eeac3	Feature/journal aggregation on write (#9396 ) * aggregate journals on write - simple implementation * remove references to aggregated journals on read * rewrite existing journals to be aggregated * remove aggregated journal reference * only delete predecessor if it can be aggregated * fix aggregation condition * adapt specs * remove aggregated journal functionality from production code The code is still necessary in a migration for the time being * adapt specs * use polymorphic belongs_to for journal data The association can then be employed for eager loading * eager load for activity rendering	3 years ago
ulferts	c1672f239c	remove reply from message journaling (#9293 ) The columns: * last_reply_id * replies_count are columns that exist for performance reasons only. They do not contain information about the message itself. If they are journaled, adding a message to a forum updates the last_reply_id of the parent message. The user replying will then be shown to have updated the replied to message	4 years ago
Oliver Günther	245b0ebbd7	[35999] Add DB constraint on project identifiers (#9265 ) https://community.openproject.org/wp/35999	4 years ago
Oliver Günther	6c75e16dc4	[37140] Use acts_as_url to generate unique slug for identifier (#9250 ) * Use acts_as_url to generate unique slug for identifier * Re-enable project identifier spec now handled in backend * Add integration spec for set attribute service * Adapt spec for new empty identifier * Avoid double error messages for empty identifier acts_as_url may return an empty string depending on the name, but the empty presence validation will suffice in this case, we don't need the invalid validation * Fix stubbed errors object accessed by acts_as_url * Avoid trying to get the upstream unique attribute in case of errors * Remove sequential_project_identifiers setting * Adapt spec to review feedback	4 years ago
Markus Kahl	8c8b8bbfa7	create backups via UI (#9136 ) * create backups via UI * Fix import of modal service * introduced backup token and addressed remaining comments * allow disabling permissions * improvements - only make user wait to use backup token in if really necessary - notify admins of new backup token - disable 'include attachments' option in UI if unavailable - documentation - misc * spec fixes * fixed feature spec * allow setting capybara host in every case * removed unused style file * addressed review feedback, added further feature specs * polish (code climate) * Avoid empty attachments * Don't raise filesize validation for internal exports Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	5920ace376	[37024] Make system user permanent admin (#9192 ) * [37024] Make system user permanent admin https://community.openproject.org/wp/37024 * Yield self from run_given * Fix count for admin in bim seeder	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958 ) * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	0d71772c37	User SqlBypass sessions to avoid ActiveRecord for session storage (#9142 ) * Use SqlBypass sessions to avoid ActiveRecord for session storage * Set default host if Capybara.app_host does not exist	4 years ago
ulferts	b8ca382d34	Group API (#9034 ) * include group members into resource * GET /api/v3/groups endpoint * POST /api/v3/groups * PATCH /api/v3/groups/:id * DELETE /api/v3/groups/:id	4 years ago
Oliver Günther	f4dfd6c6c6	[36238] Extract and fix user references in other objects (#9007 ) * Move replacing invalid references into separate job for principals * Write migration to remove existing invalid custom values and responsible * Fix other specs * Fix other specs * rewrite replacing user in records * consolidate principal deletion * include placeholder users in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	e4c9506e56	[36081] Increase max lengths of user/group names (#8948 ) * Unset DB limits for user attributes * Validate groups in synchronized groups * Extend limitations and fix specs	4 years ago
Wieland Lindenthal	efbd3e9b41	Placeholder user backend (#8935 ) * Add missing copyright note to AnonymousUser [ci skip] * Addin PlaceholderUser model and its associations * Ensure PlaceholderUser do not "leak out" uncontrolled * Extract Associations for User and PlaceholderUser. - remove obsolete #assigned_issues - remove obsoete #:responsible_for_issues - add specs and factory for PlaceholderUser Adding specs to PlaceholderModel * Migration: enforce uniqueness of lastname for Group and PlaceholderUser * Remove obsolete callback `after_add` on groups association. The association of principals and groups still had a callback `after_add` that called a method `user_added` on the group. That method was not defined anymore as it was removed in commit `d93ff52a27`. * Move validation for #groupname to the right spec. * Cleanup placeholder and group specs * Remove Setting `workpackage_group_assignment` * Refactoring: Extract assignable scope from Project to Member * Refactor: Add Member scope not_locked. * deprecate hacky scope * remove wp_group_assignment specific test case Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	7f34799a33	Chore/reimplement global roles (#8730 ) * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter	4 years ago
ulferts	7b31311713	Chore/rename timestamp on time entry (#8754 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on	4 years ago
ulferts	dd96011f11	remove renamed cron job (#8860 ) The Job was renamed in #58562e737989896f0354c38aa79e9d3af42b6397 but there might still be a job in the database using the old name.	4 years ago
Wieland Lindenthal	5c65ae2e1e	Fix #35131 : Cleanup migration for BIM themes (#8834 ) * Fix #35131: Addin a cleanup migration for BIM themes Elder BIM instances got "OpenProject" theme instead of the "OpenProject BIM" theme after migration as that became the default for the theme column. BIM instances need to get the theme set in a new CustomStyle entry AND its colors need to get written to DB. When digging around on Saas there were also BIM instances that had a theme set in a CustomStyle but did not have the colors written out to DB. * Refacotring: improve clearity of migration	4 years ago

1 2 3 4 5 ...

1008 Commits (1bc38c81dad56ed692a20889a0101df9a9d839aa)