69 Commits (1c176bc9f4680a07be292b88905922547ed7ed33)

Author	SHA1	Message	Date
Eric Schubert	d6b87a2210	[#38833] BCF API Comments Service ... - https://community.openproject.org/work_packages/38833 - added requests tests - added check for expected body length - added representer and api for bcf_comments - added create and set attributes service for bcf_comments - added migration for comment hierarchy - added create and update service for journals	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	cd2d736c18	Prevent self-assignment of work package parent ... The backend doesn't prevent parent self assignment of a work package. I triggered this by accident through an API call and this resulted in an endless loop.	3 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961) ... * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	428d23f267	disregard readonly status on project copy (#8873) ... By moving the readonly status restriction into the `reduce_by_writable_permissions` method, that functionality is disabled (as it is overwritten) when copying projects.	4 years ago
ulferts	3b0f7367fd	move to proper module	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling ... Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557) ... * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
ulferts	fdcc89f810	allow freely setting the dates of manually scheduled child work packages	4 years ago
ulferts	c5ead62e0a	adjust contract to allow setting dates on manually scheduled parent wps	4 years ago
ulferts	a2a559e553	remove almost duplicate, but faulty, readonly check ... The writability of the status is already checked at the attribute level	4 years ago
Markus Kahl	9c4d4ebc46	added :schedule_manually attribute to work package	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	614373828f	add time entries create form and schema	5 years ago
ulferts	e594f76cc6	have authorization in topics representer	5 years ago
ulferts	6c4e572f4e	consolidate allowed_* logic in the wp contract	5 years ago
ulferts	fbcdfcedba	adapt specs	5 years ago
ulferts	587e61c647	nil non provided parameters on put	5 years ago
ulferts	f759670f43	linting	5 years ago
ulferts	bc682f6b01	bail on inexistent related resource ... * status * type * assignee * priority	5 years ago
ulferts	dccd6c0b92	wip - bcf api topic#create	5 years ago
ulferts	b9b72f7204	linting	5 years ago
ulferts	cd3ffe0cc5	adapt specs to altered interface	5 years ago
ulferts	3dabb46dd9	allow copying projects without parent project reference	5 years ago
Markus Kahl	cb6d28136d	allow editing estimated time for parents, show derived separately	5 years ago
Oliver Günther	016bfc49cb	[30590] Fix switching into closed status with closed version assigned ... https://community.openproject.com/wp/30396 introduced a blocking of status editing when the version and version is closed. But this blocking also happens when trying to move a status INTO a closed state. https://community.openproject.com/wp/30590	5 years ago
ulferts	cc0145daf6	prevent useless edits to wp status ... In case the fixed version and the status of a work package are both closed, the status of a work package cannot be altered any more. Attempting it will result in an error. Before the fix, the possible status calculation would not factor in that situation and the status would be marked as writable regardless as well. Therefore, the frontend would display a list of statuses even though selecting one would do nothing at all. Now, the status property is marked as non writable in such a situation and the status list will only contain the current status. As we only fetch the form after a click on the edit field, we can only disable the field after that which is a bit weird.	5 years ago
ulferts	df2f37027c	introduce base class for delete contracts	5 years ago
ulferts	8b0182adae	add module attributes to wp contract	6 years ago
ulferts	6c49117804	do not display author in create payload	6 years ago
ulferts	492260102a	do not display lockVersion in the create form payload	6 years ago
ulferts	5b758c1419	differentiate between user and system set attributes	6 years ago
ulferts	a5defb73c5	add dedicated permission to regulate assigning a version	6 years ago
ulferts	0ffea0dc5a	fix specs	6 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308) ... * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Oliver Günther	3ba6913960	Implement read-only work package attributes based on status	6 years ago
Jens Ulferts	69ce16412f	allow current date for custom action	6 years ago
Oliver Günther	0d59680815	[28086] Add error when moving to milestone with children ... https://community.openproject.com/wp/28086	6 years ago
Oliver Günther	aa9897561b	[28455] Ensure model contracts are initiaited immediately before saving	6 years ago
Jens Ulferts	17efd9c84b	fix adding notes to work packages ... in 395c665627 the to generous interpretation of the :add_work_package_notes, that allowed user having the permission to alter additional attributes was removed. But after the removal a user having the permission was no longer allowed to add notes at all.	6 years ago
Jens Ulferts	abda9056cd	add attachment on new resource via rails form	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Oliver Günther	286d862c38	[27746] When validating the contract, ignore the old parent ... https://community.openproject.com/wp/27746	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Jens Ulferts	fc10be5a73	use ar name for validation	7 years ago
ulferts	83e605e63c	allow setting parent that has relation via new siblings (#6114) ... [ci skip]	7 years ago