openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	d497575c49	remove patch made superfluous by rails upgrade	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	7f34799a33	Chore/reimplement global roles (#8730 ) * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter	4 years ago
ulferts	ae2edad19b	Fix/copy project wiki notifications (#8777 ) * rename to convey applicability to all journal notifications * adapt journal completed job to handle wiki content * remove empty module * create wiki_content mail service * introduce copy/create service and contract for wiki pages * specify set attributes and create contract for wiki pages * copy the content attributes * use wiki page create service when copying wiki * introduce specifc service for copying wiki pages The contract disables checks for permissions on the wiki page. The copy_projects permission should suffice to copy everthing in a project * copy wiki pages top down to rewrite hierarchy * limit copied attachments to copied type	4 years ago
ulferts	5b95eb4412	remove outdated member autocompltion code (#8811 )	4 years ago
Markus Kahl	a8f04ae044	make sure API settings controller is loaded by declaring the API acronym (#8792 )	4 years ago
ulferts	23f6d97ccf	hide internal cf value format	4 years ago
ulferts	451d390e6a	adapt specs	4 years ago
ulferts	7c10376075	set view_work_packages permission as dependency A couple of permissions rely on having the view_work_packages permission, e.g. add_work_package_notes. Also removes some no longer existing controller&action combinations on the permission specificiation	4 years ago
Markus Kahl	580909e60c	ApiController -> APIController This is important because we define 'api' to be inflected as 'API' in general via ActiveSupport::Inflector in saas-openproject. So this would break (causing a 404) running on SaaS otherwise.	4 years ago
ulferts	0fbd3faeda	place members menu right before project settings	4 years ago
ulferts	5968c0b18a	Fix/replace custom i18n function (#8681 ) * replace custom i18n function calls * remove custom i18n method	4 years ago
Markus Kahl	73d5b21dbf	extend session TTL for logged-in users when using cache store for sessions	4 years ago
Oliver Günther	af4010b003	[33496] Don't try to lookup custom value by value Only for list types, the value will be an integer to look up by id, but instead use `CustomValue.new(...).typed_value` to use the formatter classes to correctly look up the value. https://community.openproject.com/wp/33496 [ci skip]	4 years ago
Markus Kahl	939f1d1df7	s3 hosts differ for pre-signed form uploads and downloads the latter include the region in the URL. This can possibly be changed so that we only need one host. Perhaps the region is optional in the carrierwave-generated remote download URLs.	4 years ago
ulferts	d695d03411	Fix/plugin settings breadcrumb label (#8618 ) * simplify code now that i18n can handle defaults * standardize settings plural i18n key * remove unused variable	4 years ago
Oliver Günther	e718b7c98f	Ensure CORS middleware is added after logger That's because saas uses a middleware before logger to ensure we can access request settings	4 years ago
Markus Kahl	55ab48c56a	allow disabling postgres type cache via env	4 years ago
Oliver Günther	86b8ffc326	[30007] Allow users to enable CORS on APIv3 resources Allows a setting and configuration option to allow access to APIV3. Setting allows us to selectively enable this for cloud instances too. https://community.openproject.com/wp/30007	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557 ) * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
Oliver Günther	81bd0e34cd	[34025] Allow insecure localhost redirect_uri for OAuth This makes it easier for developing and debugging local OAuth applications https://community.openproject.com/wp/34025	4 years ago
Markus Kahl	8a90e3f745	cache types in postgres adapter	4 years ago
Inga Mai	00665e7913	Correct routing for PATCH and cleanup	4 years ago
Inga Mai	7779ca7a04	Fix display page and incorrect paths	4 years ago
Inga Mai	1afc6782f7	Replace system settings tabs by submenu	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	b1a99353e2	Extend attribute help text for projects and allow images Attribute help text so far could only be added to work packages. This commit adds support for projects and adds the help texts to widget headers for status and description modals in the overview tab as well as extending the attachable mixin to allow uploading images. Uploaded attachments are to be expected to be visible regardless of permissions, thus this also adds an option to make attachments visible to all	4 years ago
Oliver Günther	d3ba1705e2	Skip slow log on test [ci skip]	4 years ago
Oliver Günther	10e21154f7	Move asset pipeline javascripts to frontend (#8482 ) * ove reporting and reporting_engine js to frontend page * Replace webhook assets javascript * Add path augment service to dynamically load scripts * Remove JS-Files that are not used/not needed any more * Include AugmentingModule correctly * Remove special handling for checkbox selection which is outdated and two jquery libs that are not used any more * Load scripts dynamically that are not needed globally * Move plugin JS to frontend * Move toggable fieldsets to global listeners * Move top-menu to global listeners and convert to TS * Move action_menu to frontend and port to TS * Move settings listener to frontend * Remove global js assets that were not used anyway * Move date range to timelog dynamic script where it's still used until removed * Move colors to global-listeners and port to TS * Replace tooltip with simple form instructions on the one place used Tooltips were only used at the one place in our application, when changing a users password. We can simply remove it there and use a modern solution the next time we need a tooltip * Move danger zone validation to frontend and port to TS * Move colorcontrast to backlogs vendor where it's used now * Remove contents of application.js.erb * Move project and user scripts to dynamically loaded * Move onboarding tour to dynamically loaded * Use correct syntax for jQuery so that $ is known keyword within this function * Fix onboarding tour * Fix onboarding tour for scrum tour * Fix specs after moving JS * Remove application.js.erb * Move locales and ckeditor to the frontend to dynamically load * Remove bundles caches These are no longer being used since angular cli * Ensure locales are exported before angular Co-authored-by: Henriette Darge <h.darge@openproject.com>	4 years ago
Behrokh Satarnejad	9db6aeffe5	[33680]Add "projects" to the global Modules menu (#8478 ) * add projects link to top menu * change the test	4 years ago
Markus Kahl	1b82908a1d	update puma and add puma health check	4 years ago
Oliver Günther	4099cf5f26	Move styleguide layout to somewhere it's not breaking stuff Under `app/assets` causes the asset compilation to break	4 years ago
Oliver Günther	144332eb7d	Ensure the icon font is loaded only once globally If we do not ensure this, components will double load the font, resulting in 404 font requests and breaking travis	4 years ago
Oliver Günther	c0e3516b50	Make livingstyleguide somewhat working again	4 years ago
Henriette Darge	2bec452167	Remove LSG gem as it is will be replaced by a frontend-compiled solution. Thus we can also remove sassc and autoprefixer.	4 years ago
Oliver Günther	cbb04e3541	Allow logging slow SQL queries to sentry/local logger We can use the activerecord.sql notification hook to determine slow running queries without needing to look into the psql slow log. The default threshold is set to 2000ms for now, can be changed freely with `OPENPROJECT_SQL__SLOW__QUERY__THRESHOLD=X` where X is an integer threshold in miliseconds	4 years ago
Oliver Günther	58562e7379	Let CopyProjectJob redirect to the target project	4 years ago
Oliver Günther	f7d4439f65	Rewrite status as module	4 years ago
Oliver Günther	ba6465f106	Listen to the notifications in a separate listener class	4 years ago
Oliver Günther	ea00378f0e	Remove max_attempts from delayed job From now on, jobs should use the AJ `retry_on` and `discard_on` methods to decide on what exceptions it makes sense to retry.	4 years ago
Oliver Günther	739860cc48	Fix spec not testing for response headers in selenium	5 years ago
Wieland Lindenthal	1841304742	Add Oauth redirect hosts to CSP action-form	5 years ago
Markus Kahl	e4bd453be5	use double splat as not using it is deprecated	5 years ago
ulferts	48bd2683fd	remove usage of deprecated doorkeeper config (#8329 ) The default value for `native_redirect_uri` is the same value we provide [ci skip]	5 years ago
ulferts	64d0f57d85	Feature/aggregated activities (#8221 ) * use cte for aggregated journal * Revert "use cte for aggregated journal" This reverts commit `5fedefefdd`. * add another subselect that could later on be provided from the outside * allow passing a nukleous sql to aggregated journals * wip - using aggregated journal for activity * new sql for aggregated journals * start implementing new aggregated query * additional documentation * consolidate activity functionality * simplify by turing into instance methods * move activity fetcher out of redmine * remove verb verification made obsolete Without catchall routes, the dispatching handles it * remove duplicate authorize check * refactor activities controller * refactory activity fetcher * cache avatar file * sort choosable events * remove legacy spec covered by contemporary * speed up aggregated journals via CTE * instance var might never have been set * ensure the event_types are always transmitted * correctly reset the avatar cache * fix avatar fetcher expectation regarding wiki pages * adapt spec [ci skip]	5 years ago
ulferts	1e6c1e7d72	introduce a presisted status for delayed jobs (#8299 ) This is currently only employed for work package export jobs but is intended to be used more broadly, e.g. to signal the status of copying a project. [ci skip]	5 years ago
Oliver Günther	6ded4e6852	Add cron job functionality to delayed_job	5 years ago

1 2 3 4 5 ...

865 Commits (1c31ec84ad83df1d0b968c30e7e1ea983f5fbf5c)