227 Commits (1e00c930df3ec96a3585466a9b57e64652e75995)

Author	SHA1	Message	Date
Markus Kahl	92506216d3	use common base class for jobs	8 years ago
Jens Ulferts	8f1c5d76b7	allow parent project to be set on copy	8 years ago
Oliver Günther	9db305439d	[22158] Fix CopyProjectJob notifications ... * Actually send copy job notifications * Skip enqueuing notifications when mails are disabled Aggregated journal notifications are sent after a delay, after which the actual job has long completed.	9 years ago
Oliver Günther	ba491cbf47	Fix repository relocation on managed remote ... Repositories were not properly relocated when using a managed remote. This also changes the request to use an old identifier instead of the whole path. The managed remote will build the correct old path itself.	9 years ago
Stefan Botzenhart	e7490c1988	Fix copy project ... After switching to strong parameters mass assignment for project params is not supposed to work without permitting params. We now pass a normal hash instead of a ActionController::Params hash. Otherwise we get an ActiveModel::ForbiddenAttributesError All errors on the job are being rescued and logged to a separate file. Normally rescueing all errors on Exception is not something you want to do but as the job has an ensure block you won't know about any failures.	9 years ago
Oliver Günther	dac730ac5a	Add insecure option to managed remotes ... Adds an `insecure` option to the `configuration.yml`. This option only applies when the manages: key is set to a URL. If the given URL uses SSL, certificate checking will be disabled. This key is set for a packaged installation by default, since it communicates locally and these installations may often include a snakeoil certificate.	9 years ago
Oliver Günther	b29abfbdc0	Expect URL and path to be returned from the remote ... This commit expects a managed remote to return at least a URL to the repository, and optionally a path. Note that OpenProject currently only supports local repositories for Git, and thus using managed remotes with Git WILL require a path returned from the remote. For Subversion, also returning a `file://<path>` URL is sufficient, since it can browse that. Returned external URLs must be accessible from OpenProject, since we do not receive any authentication from the remote.	9 years ago
Oliver Günther	589ba8e7b1	Relocate repositories locally and remote ... This commit introduces relocating a repository as a followup after a project's identifier has been renamed.	9 years ago
Mohamed Wael Khobalatte	d2349cf819	Delete Redmine's safe_attributes implementation ... It was an early implementation of strong_parameters, more or less. Going forward, we should strive to make the whitelisting of attributes a controller responsibility only.	9 years ago
Oliver Günther	02807e02a8	Refactor CopyProjectJob to class	9 years ago
Oliver Günther	dd20da3baf	Send access token and extend packaged configuration ... Extends the packager `configuration.yml` to include vendor configuration for Subversion and Git, when enabled through the wizard. Also extends the remote repository request to send an optional, configurable access token required to use the wrapper script.	9 years ago
Markus Kahl	708596c735	delay user invitation mails	9 years ago
Oliver Günther	58ced887a2	Repository Apache module ... Provides a simple mod-perl based Apache wrapper around remote repositories. As its functionality is very limited, it is probably not of much use outside of the packager context.	9 years ago
Oliver Günther	b7465b08a6	Remote managed repositories ... This commit starts the work to provide functionality with remote service hooks for managing repositories. The main driver behind this is packager, for which we want apache to be the sole owner of the repositories it delivers, and OpenProject only as a reader, however it benefits other installations as well.	9 years ago
Alex Coles	7d010a2649	Re-remove deprecated call to #deliver ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	e40f3758fb	Replace further deprecated calls to #deliver ... See 868d764a. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	b76c351813	Ensure mails are not sent twice ... ... in case a user is author + watcher	9 years ago
Jan Sandbrink	4ee163393f	Rearrange mail delivery responsibilities ... - each delivery job delivers only a single mail (like in the past) - a common super-class ensures correct handling of different error conditions (similar to the past) This new structure should allow for an efficient error handling: - fail the mail delivery on a per-recipient basis (i.e. redeliveries on error only affect the user that did not receive a mail) - only fail the delayed job for delivery errors (e.g. network issues, etc) - do not fail the delayed job for rendering errors (which are likely to re-occur on each rendering) -> only log those	9 years ago
Oliver Günther	7cb8d62e92	Fix max_attempts for StorageUpdaterJob ... This sets `max_attempts` for StorageUpdaterJob to 1, as we prefer having an external event retrigger storage counting rather than retrying from delayed_job. The reason behind this is failing counting due to I/O or other unforeseen issues (e.g. mount not available, .. ). In this case, recounting soon after will not solve the problem and only increase load on disk.	9 years ago
Oliver Günther	379a36d3e8	Fix repeating failing jobs due to missing repository ... When a StorageUpdater job is registered, but the associated object is vanished in between request and execution, the job fails and is repeated. It should instead succeed with a warning.	9 years ago
Stefan Botzenhart	868d764a97	Use activejob deliver_now method (removes deprecation warning)	9 years ago
Oliver Günther	701c49ab31	Correct parsing of string and octal chmod values	9 years ago
Oliver Günther	ec7b33484b	Force integral mode ... ENV-based configuration passes a string to the chmod value, which seemingly can't be turned into an integer. Thus we work around this by casting the value to integer, will also help users who are using strings in their configs	9 years ago
Jan Sandbrink	dfb9a5cd20	remove remaining AR find_by_x finders ... - most of them were removed by @myabc in the rails4 branch - some where reintroduced due to parallel development to that branch - still some occurences left that will hit custom implementations	9 years ago
Alexander Bach	4105a920b5	Style watcher notification mail	9 years ago
Alexander Bach	c22c41b7db	Directly notify new watchers by mail	9 years ago
Evghenii Barhatov	6ceb63b2b7	Pass user_id instead of whole User model object in DeleteUserJob	9 years ago
Jan Sandbrink	715c664cbe	generalize module included in all delayed jobs ... now also applies to other activities one might want to execute before all delayed jobs (as discussed with @ulferts)	9 years ago
Jan Sandbrink	10d61b01e7	let delayed jobs reset the request store ... This is especially neccessary since our Settings use the request store to determine, whether they need to invalidate the cache key. If the request store was never reset, the settings in our delayed jobs would be cached at an old value forever (until the next restart).	9 years ago
Oliver Günther	1b9ba9c4bf	Remove repository project hierarchy ... This commit removes the project hierarchy introduced with repository management. They are not required, incompatible with mod_dav_svn and provide little to none advantage to storing all repositories in a flat structure for the scale we require.	9 years ago
Oliver Günther	ee77585299	Disallow setting the owner of a repository folder ... The original repository management epic allows to define an owner that a created repository is set to. As this will not work for non-root users on *nix systems, this commit removes this functionality in favor of setting only the group. This is allowed by non-privileged users _as long as_ users are member of this group.	9 years ago
Jan Sandbrink	8a9d0b36a3	show comment in WP created mail	9 years ago
Jan Sandbrink	285b7f5437	move on-behalf-delivery into notification mailer	9 years ago
Jan Sandbrink	3b3ae3f6b3	split up mail delivery and enqueueing	9 years ago
Oliver Günther	c16c1e75d4	Extend SysController to allow WS to check / update storage	9 years ago
Oliver Günther	8b5a120052	Move storage information to database ... This commit effectively adds a storage information column to repositories. It tests the functionality of the counting on subversion and git repositories / adapters.	9 years ago
Oliver Günther	29ab3f74c0	Add quota display using .reposize file. ... This commits add the basic functionality for: - Retrieving the storage size of a repository in pure ruby. - Retrieving the latest mtime of a file in a repository - Asynchronously getting and writing this information in a separated file inside that repository (`.reposize`) with YAML for convenience.	9 years ago
Jan Sandbrink	974523c370	partly address an edge case that can prevent notification delivery ... "partly" because the current implementation is still "vulnerable" if the succeeding journal gets outdated in the same way as the preceeding one. The edge-case of the edge-case....	9 years ago
Oliver Günther	86f847043b	Allow configuration to disable arbitrary SCM types ... This commit provides: - Configuration options for disabling any number of available types of that particular SCM vendor. - Changes to the underlying structure to allow determination of which types are available on a class level.	9 years ago
Jan Sandbrink	6c1e4dbf4f	send aggregated notifications ... - only sending the last mail of an aggregation chain - displaying the aggregated state of the change - replaces old classes for mail notifications - old special error handling for missing users is obsoleted, since recipients are determined at jobs runtime - special cases for missing author and journal are considered	9 years ago
Oliver Günther	edf713fbd5	Rework managed repositories error handling ... This commit: - adds error messages for filesystem errors - Forces services and views to use repository.root_url instead of managed_path, which may not be available when config is missing	9 years ago
Oliver Günther	bb2a09490b	Remove delayed running of management workers. ... This commit (temporarily) removes the delayed creation and deletion of managed repositories for the sake of improvded error handling. After consultation with @ulferts, we suggest to improve the `Delayed::Job` pipeline to create means for identifying jobs (referenced ID) and to create a unified service to manage database AND filesystem access in a transactional manner. Also provides the following corrections: - Improve migration speed - Delete parent projects only by their identifier, not the managed root	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Alex Coles	ea713284a8	Fix syntax (w/Rubocop) in workers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	2fbbccb50c	move error handling up ... RecordNotFound would now already occur due to :recipient call in :perform method.	9 years ago
Jan Sandbrink	4bee848f3d	style	9 years ago
Jan Sandbrink	7d634d57ad	execute mail jobs in context of their recipient	10 years ago
Jan Sandbrink	95c0d0a013	pull recipient & author up into MailNotificationJob	10 years ago
Jan Sandbrink	d43803ce85	use more specific names than user ... author and recipient are matching the domain they are employed in (mail delivery) closer. Especially the name 'current_user' only happens to be the thing being assigned as author, but does not transport any special meaning in itself.	10 years ago