120 Commits (2022a87532c224e379bbe5b61f2d8a1935781307)

Author	SHA1	Message	Date
Oliver Günther	06d203141e	Remove outdated flash message ... Managed repositories are always deleted, even if the configuration states otherwise. The specific flash message concerning deletion of managed repositories is thus wrong and was removed.	9 years ago
Oliver Günther	c5b200d7a0	Review corrections ... - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	0284d11f21	Corrections from review ... - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter ... This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	b0c0d0a53f	Avoid fishy factory delegation.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring ... - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation ... Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the **legacy specs** for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Alex Coles	8b4be7f749	Indent fix in RepositoriesController for Rubocop ... [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks ... `rubocop -a` does not currently normalise formatting consistently (see ec1bb39f). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0942d7335b	Add explicit join references in controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jens Ulferts	13e0940171	only display scm options if they are configured	10 years ago
Jens Ulferts	b37ea687e2	showing error messages on scm updates	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	8a28b1a730	Prefer #map over #collect in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	bb0e6e6aa5	Fix syntax (w/Rubocop) in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	336446c59d	Use 1.9+ Hash syntax in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Jens Ulferts	dc98efb5ac	fixes route globbing for repositories	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Michael Frister	774be9fc43	Don't embed commits per author graph for unauthorized users	11 years ago
Michael Frister	a9d2520b00	Deny access to repository commit author stats for unauthorized users	11 years ago
Hagen Schink	0030de86be	Adapts format handling	11 years ago
Hagen Schink	1edbf747cf	Adapts Rails3's changed route globbing behavior ... In Rails3, globbed routes are strings and not arrays.	11 years ago
Jens Ulferts	6c720a8d5d	changes the last controllers to will_paginate ... Uses page_param and per_page_param calculation from PaginationHelper for all of the controllers Adapts the api views	12 years ago
Jens Ulferts	09b1c00e69	uses will_paginate for changesets	12 years ago
Jens Ulferts	21459a384f	provide every possible file with a short copyright notice ... This was done using the rake task: rake copyright:update	12 years ago
Philipp Tessenow	ec3829e11b	be careful with nested namespace'd controllers in our controllers	12 years ago
Martin Linkhorst	6200acf6f6	fix some active record queries for postgres and apply a patch from redmine at the same time	12 years ago
Martin Linkhorst	09e496f54b	REVIEW: get the changes by joining with the changesets in order to have access to the #committer of the changesets as required in the tests which group changes by the committer	12 years ago
Dennis Schmidt	958f58a4f2	remove default ordering for count(*) query ... (Postgres)SQL requires columns in ORDER BY to 'appear in the GROUP BY clause or be used in an aggregate function' which doesn't really make sense here: as we are grouping, ORDERing is pointless anyway.	12 years ago
Martin Linkhorst	aa297a2a99	fix repositories subversion controller	12 years ago
Holger Just	91070236db	Set source encoding to UTF-8	13 years ago
Eric Davis	4b3bd797b0	Fix errors when trying to check for binary SCM strings in 1.9.2 ... 1.9.2 removed String#is_binary_data?	13 years ago
Holger Just	07185fb169	[#436] Remove trailing whitespace	14 years ago
Eric Davis	99507a0391	[#197] Upgrade the copyright in the code files	14 years ago
Eric Davis	e131c3b531	[#197] Remove old copyrights	14 years ago
Toshi MARUYAMA	be2046b189	scm: set mime type in downloading file. ... git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5210 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Toshi MARUYAMA	6fcddfe2e2	scm: fix non ascii text files displaying (#6256). ... git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5204 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Toshi MARUYAMA	1c0e7790be	scm: recovery showing "root @ branch" in repository tree viewing. ... git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5139 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Toshi MARUYAMA	49fde3723b	scm: fix diff revision param validation. ... git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4860 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Toshi MARUYAMA	6cd9bc5ca5	scm: space and tab cleanup of app/controllers/repositories_controller.rb. ... git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4817 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Toshi MARUYAMA	3d11a22624	scm: fix non ASCII filename downloaded from repo is broken on Internet Explorer (#7288). ... git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4816 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Toshi MARUYAMA	e1667dabbf	scm: use format_revision() for history, view and annotate (#3724). ... git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4733 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Jean-Philippe Lang	e14e244f7b	Use #blank? instead of #nil? || #empty?. ... git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4711 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago