198 Commits (210379367f30bae986359db5c1c508fa3b5dc603)

Author	SHA1	Message	Date
Roman Roelofsen	210379367f	WIP reducing watcher count	9 years ago
Roman Roelofsen	e0bf811f77	Reduced watchers count, needs review!	9 years ago
Roman Roelofsen	8985c910f7	Reduced Watcher Count	9 years ago
ulferts	48ac7aa6f4	introduce strategy for displaying fields (#4469) ... In order improve the code structure and in order to enable plugins to add display strategies for fields, that are not covered by the core yet, a strategy pattern is introduced for displaying fields. The mechanism is identical to the way EditFields are handled. In fact, the DisplayFields and EditFields now inherit from a common superclass, Field. Also, the service and the factory inherit from a common superclass.	9 years ago
Markus Kahl	f64d06638c	hide hidden fields even if they have a value (#4408) ... * Make test/dev assets settings explit * description must not be customizable * updated feature help text * fields with default values can be hidden * fixed hide condition * fixed edit wp spec (required cf) for some reason factories initialize custom fields with '' (empty string) as default values. The API interprets this as a default value being present. In normal operation a custom field without a default value will return nil, not the empty string	9 years ago
Oliver Günther	2b02d50af5	Remove old values when they're no longer in the schema	9 years ago
Oliver Günther	159a7f0007	Restore custom schema displayAttr functionality ... I don't really like that displayAttr is exploited for displaying sums, despite the directive clearly targeted to work packages alone. This makes the distinction clearer with a 'customSchema' attribute when not the work package schema is to be used.	9 years ago
Oliver Günther	6e50a03877	Extend wpDisplayAttr test	9 years ago
Oliver Günther	c1f00abf21	Update wp-display-attribute only when changed	9 years ago
Oliver Günther	ca65f078c3	Fix leftover values from wp resource still showing up ... The display-attr causes old values in the resource to still show up, despite no associated schema being available. I don't think it hurts to have old values in the resource, as long as we can ensure that it's the schema that decides what is showing.	9 years ago
Oliver Günther	cfec719371	display-attr receives updates from wpCacheService	9 years ago
Oliver Günther	6589b6ba50	Initialize edit field when work package is updated in cache	9 years ago
Oliver Günther	2f1d84c7cf	Fix saving/display of boolean custom fields ... Boolean custom fields were no longer saved since the field was marked as required and thus invalid when unchecked. Even when booleans were unchecked, they were output as 'Yes' since the text was evaluated to become the placeholder `-` before the format helper was called, thus resulting in a truthey value. Also, unchecked booleans are marked as placeholders since they are falsey when empty.	9 years ago
ulferts	fa68e867e7	reverting 698a6ea (#4453) ... We need the extra service so that plugins might register to have additional fields displayed.	9 years ago
Oliver Günther	e066ababcc	Reload the WP table in background after split screen creation	9 years ago
Oliver Günther	8b9212bf73	Use op-auto-complete in comment field and add test	9 years ago
ulferts	2c47657de7	unified date field for milestone work packages (#4437) ... Work packages having a type that is a milestone receive a 'date' attribute in their API resource. Other work packages still have the 'startDate'/'dueDate' attributes. The schema behaves analogous so that such a change is visible to a client. In the cient we can now remove some of the custom behaviour for the date field. The code removal is limited to the new inplace edit implementation as the old implementation can hopefully be removed fully in the near future.	9 years ago
ulferts	de77f7bf48	style inline edit placeholders (#4439)	9 years ago
Jens Ulferts	303cbba580	reflect value update in accessibility labels	9 years ago
Oliver Günther	88d2312256	Use localized value for cg-busy message	9 years ago
Oliver Günther	6549869000	Fix focussing on erroneous fields	9 years ago
Alex Dik	dcb21eabec	Include test helpers within webpack instead of karma	9 years ago
Oliver Günther	c3a256b6a3	Always post to global create form	9 years ago
Alex Dik	efc0d7d3d8	Fix TS compiler output for test files	9 years ago
Alex Dik	607f3b44ce	WP deletion closes split view (#4422) ... * Tidy up ui router config using the openproject module import * Close details view on WP bulk delete * Implement spec for WP deletion in split view	9 years ago
Alex Dik	a17196b318	Fix date placeholder for milestone type	9 years ago
Jens Ulferts	e0f7adf35d	move inline edit dashboard so that it is nested correctly for styling	9 years ago
Oliver Günther	3cc850b783	Replace comment cuke with spec	9 years ago
Oliver Günther	6e009604fa	Restore comment field ... It's incorrectly styled, still.	9 years ago
Oliver Günther	06c2f02068	Restore create form ... Create form was not rendered due to edit-actions-bar	9 years ago
Oliver Günther	67e4551387	Mark WorkPackageResource as dirty when values were changed ... This allows us to check the cache services for changes in the work package and not refresh it from the cache. Currently, this is only relevant for edit all mode, however it may be the entry point for a API merging / refreshing service.	9 years ago
Oliver Günther	b849514904	Separate methods for entering/cancelling by user events	9 years ago
Oliver Günther	4e2303ff60	Activate edit all when switching	9 years ago
Oliver Günther	e299283bcb	Move wp-edit-form up to list-details ... This requires the new work package resource in the details controller parallel to the old resource. It's ugly, but temporary.	9 years ago
Alex Dik	f2246e32c7	Use one time binding for date field placeholder	9 years ago
Alex Dik	4d909134fe	Remove wpField directive from wpDisplayAttr	9 years ago
Alex Dik	a1ba434ad0	Add placeholders to date fields	9 years ago
Jens Ulferts	c4e5bab07b	style inline-edit textarea fields	9 years ago
Alex Dik	4c1e56e993	Fix date field group editing	9 years ago
Alex Dik	9bf0b1bbbd	Remove redundant line	9 years ago
Jens Ulferts	09810c897f	add styling to rest of inline edit fields	9 years ago
Jens Ulferts	23515190cb	restyle subject on the wp.show	9 years ago
Oliver Günther	bceed4ea51	Fix typescript warnings in attachment.directive	9 years ago
Alex Dik	d67dd289ac	Undo removal of legacy attachments directive ... We can just undo this commit for the new one to be used in the create form as soon as it is ready.	9 years ago
Alex Dik	9c6c56bf00	Rename WorkPackageAttachmentsService to wpAttachments	9 years ago
Alex Dik	33bdb3e50c	Rename directive work-package-attachments to wp-attachments	9 years ago
Alex Dik	031750352b	Move the WP attachments directive to components	9 years ago
Jens Ulferts	e5d874a966	Accessibility for wp-edit fields ... * Hidden label for all fields once they are activated * aria-labelledby for all fields when they are in read mode * turned visible attribute text on split/fullscreen to be clickable so that it behaves like a label	9 years ago
Oliver Günther	91ba21556e	Focus element when exiting edition	9 years ago
ulferts	a4c8fa75bb	add ability to activate inline edit fields via keyboard (#4405) ... Allows tabbing on the inline edit field. https://community.openproject.com/work_packages/23076/activity I feel that one scenario is still not supported the way it should be. If the user presses the "ESC" key while being in an inline edit input, the input disappears and the text representation is displayed as desired. But the focus is not placed on the text so it becomes hard to reactivate the field as the user has to start the tabbing journey anew. I couldn't get this to work as the field can only be focused after it reappears.	9 years ago