3855 Commits (213caff8a39e25c72d4746249223d49bb7822e20)

Author	SHA1	Message	Date
Oliver Günther	d49ba37e0a	Remove explicit required label for impaired users ... Denote inputs with `aria-required="required"` instead of a separate span within the label, which causes double mentions of the field being required (once through the html5 attribute when the screenreader is compatible) as well as in the label span.	9 years ago
Oliver Günther	bbfe941e77	Refactor required star into separate spans ... Seperate spans for visible and impaired users allows us to replace the spelled out Asterisk from pseudo content with a proper aria-label.	9 years ago
Oliver Günther	86a061b6e7	Add separate span with error message for the current field	9 years ago
Oliver Günther	ce503e3306	Add error handling to form labels ... This re-enables an `-error` state for labels when the associated field is erroneous. Also shows an error icon next to the label and changes the font style.	9 years ago
Oliver Günther	a3746ed4ae	Create proper breadcrumb helper to avoid escaping ... Lots of toolbars use the notation `<Foobar> >> <Subitem>`, which did not have a helper yet and requires manually calling html_safe all over the place. This fixes it by adding a `breadcrumb_toolbar` helper that properly and safely joins its components.	9 years ago
Oliver Günther	c67f8cd34a	Add link_to option to toolbar title	9 years ago
Oliver Günther	6ce9f8f539	Add title to sort link itself ... The sort link was added to the table header, but not the sort link itself. This way, it was not accessible.	9 years ago
Oliver Günther	412becb62e	Fix icon-add missing spec	9 years ago
Oliver Günther	67e06ee2b2	Remove double escaping ... With OpenProject 5.0, we moved to Open3 pseudo-shell, which no longer requires escaping seperate arguments (unless the whole command is passed as a single string, which will result in an actual shell that would require escaping). The `shell_quote` functionality was still used though and causes issues with remote subversion passwords, which will be improperly escaped.	9 years ago
Jens Ulferts	9375bdb9c0	use standard select for sort by modal	9 years ago
Oliver Günther	24265421bb	Remove embedded users in Projects#show ... I believe its no longer in use by the frontend.	9 years ago
Jens Ulferts	e1839083ef	invisible elements may not be clicked on	9 years ago
Jens Ulferts	061a71bb32	fix setting custom values on version	9 years ago
Jens Ulferts	fc49e2a7b7	use linked parent resource instead of parentId ... The parentId field should be removed. But we shouldn't do it in a minor version.	9 years ago
Jens Ulferts	c7f780e797	enable child work package creation in split view	9 years ago
Jens Ulferts	4e2f3a1b7a	implement work package child creation	9 years ago
Jens Ulferts	9668e7e99e	fix addChild path in work package resource	9 years ago
Jens Ulferts	966d749e45	add parentId field to schema ... This is somewhat debateable. Having a parentId field is wrong in itself. It should be a linked resource. But as the field is also present in the resource, it also needs to be part of the schema for consistency sake.	9 years ago
Oliver Günther	5cd5040e9e	Fix invalid params on category edit ... The edit route wrongly assigned parameters to the category, although it should only render the edit form. This only became apparent when strong params where requiring the `:category` param hash.	9 years ago
Oliver Günther	55beb72bcd	Let container be available in split page	9 years ago
Oliver Günther	4cfb830b70	Move visit_tab! to abstract work package page	9 years ago
Oliver Günther	8dc9b592c4	Fix merge hickup	9 years ago
Jens Ulferts	f8086335db	enable copying on split view	9 years ago
Jens Ulferts	50fa86d18e	spec full page copy	9 years ago
Oliver Günther	383d0d631e	Restore accessible-by-keyboard template ... This fixes the broken specs due to: 1. Switch to button in accessible-by-keyboard 2. Changed label for '+ Work Packages'	9 years ago
Henriette Dinger	b0560a2188	Include review feedback	9 years ago
Henriette Dinger	48f593645c	Add small icons for timelines and start fixing specs	9 years ago
Henriette Dinger	463aa185da	Update icon classes from 'not-watch' until 'pulldown-arrow4'	9 years ago
Henriette Dinger	844663fef2	Change icon classes from 'attention1' until 'headphone'	9 years ago
Oliver Günther	34cb4980e1	Squish date to avoid start-of-month bugs ... The date output in the `activity_tab_spec` today is `"December 1, 2015"` (mind the extra space), which no longer matches the result when the date is a single digit.	9 years ago
Oliver Günther	840a362177	Squish date to avoid start-of-month bugs ... The date output in the `activity_tab_spec` today is `"December 1, 2015"` (mind the extra space), which no longer matches the result when the date is a single digit.	9 years ago
Jens Ulferts	2516e9c0e7	allow to disambiguously group by responsible association ... Before the commit, the result for a count on a query grouped by responsible would be of the schema { id: count, id2: count2 }. For other attributes, e.g. assignee it is { user: count, user2: count2}. The difference is caused by using :responsible_id for grouping which is necessary as the association causes an ambiguous reference in the issued db query. That problem has been fixed in rails/master (c2d33c4abf). But as long as the fix is not backported, we will have to overwrite a method of ActiveRecord::Calculations	9 years ago
Jens Ulferts	b8c7d77683	unpersisted WPs are considered leaves	9 years ago
Jens Ulferts	5e6d657a35	remove no longer required dynamic spec generation	9 years ago
Markus Kahl	7f88ba5b22	removed attachments#show; only #download remains	9 years ago
Jens Ulferts	8c506b6f6e	remove redundant security check ... One might be able to constantize arbitrary objects (those that exist) but the checks after the constantize are very strict. They will only allow the find method to be called on objects inheriting from Acts::As::Watchable. The only parameter that is allowed for the method is an integer.	9 years ago
Oliver Günther	03907e8c0f	Rename spec usages appropriately	9 years ago
Oliver Günther	e93f6df303	Use better selector for hovering the comment	9 years ago
Jens Ulferts	b7e0970a89	adapt activity features spec	9 years ago
Oliver Günther	6e2731e82b	Add feature spec for activities ... [ci skip]	9 years ago
Oliver Günther	95def249b7	Reduce forced sleep in spec ... This removes the forced sleep of the spec and rather checks for the correct page to have loaded before the next is requested.	9 years ago
Alex Dik	15a0dad173	Spec resetting of new WP form	9 years ago
Oliver Günther	c15eeca71e	Fix activity comment spec flicker by allowing more wait time	9 years ago
Oliver Günther	8b01984cc2	Adjust test to check activities are not embedded	9 years ago
Jens Ulferts	e2f8db9497	eager load colors together with the type	9 years ago
Jens Ulferts	11d7e428ad	reuse version calculation on eager loaded projects ... Eager loading projects assigns the same object instance to each work package having the same project_id. When the first project evaluates the assignable versions, the result can be memoized to be used by other work package having the same project	9 years ago
Oliver Günther	ba491cbf47	Fix repository relocation on managed remote ... Repositories were not properly relocated when using a managed remote. This also changes the request to use an old identifier instead of the whole path. The managed remote will build the correct old path itself.	9 years ago
Stefan Botzenhart	1f53f5472e	Code style enhancements to fight against bad scoring	9 years ago
Oliver Günther	dac730ac5a	Add insecure option to managed remotes ... Adds an `insecure` option to the `configuration.yml`. This option only applies when the manages: key is set to a URL. If the given URL uses SSL, certificate checking will be disabled. This key is set for a packaged installation by default, since it communicates locally and these installations may often include a snakeoil certificate.	9 years ago
Markus Kahl	b071308444	fixed broken permitted param specs	9 years ago