460 Commits (216f0013b44c1a8b4f1ad6ef79810b96e254154d)

Author	SHA1	Message	Date
Oliver Günther	6661f2b6d5	Refuse to delete a repository in OpenProject on FS permission errors ... This commit changes the behavior of removing repositories. It is no longer possible to remove a managed repository (model) when the underlying repository directory could not be removed. This error originally occurred when Apache committed changes to the repository through mod_svn, which resulted in the OpenProject user being unable to delete a particular subdirectory.	9 years ago
Oliver Günther	7e7386f3b6	Rework instruction display ... - Defaults to localized instruction when none is provided in the settings - Make readonly input visually clickable, not disabled - Renamed `permission?` to `permissions?`	9 years ago
Oliver Günther	c9d3dabab2	Delete repository: Fix internal error on lacking permissions ... While rolling out on dev, we found that apache by default modifies the access permissions of a repository. This in turn causes the deletion of a repository to no longer complete sucessfully, but return with a permission error. This error was not caught an escalated into a 500 on the repository settings.	9 years ago
Jan Sandbrink	dfb9a5cd20	remove remaining AR find_by_x finders ... - most of them were removed by @myabc in the rails4 branch - some where reintroduced due to parallel development to that branch - still some occurences left that will hit custom implementations	9 years ago
Oliver Günther	ef322e89dd	Cleanup	9 years ago
Oliver Günther	dfb8ac4853	Add basic checkout instructions ... This commit adds very basic checkout instructions similar to `openproject-checkout` to repositories. Issues: * Uses table style for checkout component, as exact styling is unclear * Adds compressed table style with less padding * Checkout settings are best organized in a Hash with keys per SCM * vendor. Using default settings, a lot of new setting values would be introduced * Checks for Hash in SettingsController * Currently can't use SettingsHelper, as it requires single setting values	9 years ago
Oliver Günther	a71ce6f1a5	Refactor SCM config to lowercase / symbols ... ENV-based configuration for various configs can only provide case-insensitive values for SCM configuration and thus is unable to properly configure, e.g., managed repositories. This refactoring relies on lowercase configuration and symbols to define SCM vendors, and camelizes them to the old notation (e.g., :git => 'Git') when using `Setting.enabled_scms` to remain compatible with previous installations.	9 years ago
Tim Habermaas	1571abc931	[Refactor] Remove useless setters; remove useless mutation of self.	9 years ago
Alex Coles	18b8625ae2	Fix deprecated .update_all in MoveWorkPackageService ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Evghenii Barhatov	6ceb63b2b7	Pass user_id instead of whole User model object in DeleteUserJob	9 years ago
Jens Ulferts	6e01b27f18	rename service's method to be in accordance with proc	9 years ago
Jens Ulferts	c471080e08	set locale before API v3 request ... The mechanism was extracted from the rails stack where the locale is taken based on (in that order): * The user's preferences * The accept_language header * The system settings Only languages, that are enabled by the instance are valid. If one is selected (e.g user preference), that is not enabled by the instance, a fallback is taken.	9 years ago
Oliver Günther	1b9ba9c4bf	Remove repository project hierarchy ... This commit removes the project hierarchy introduced with repository management. They are not required, incompatible with mod_dav_svn and provide little to none advantage to storing all repositories in a flat structure for the scale we require.	9 years ago
Jens Ulferts	a8b4ca5e83	remove superfluous safeguard	9 years ago
Jens Ulferts	6f3e289f9a	remove duplicate assignment of custom field values ... The assignments happens in work_package.copy_from as well	9 years ago
Jens Ulferts	07fab1f315	further method extraction	9 years ago
Jens Ulferts	fcaa4ca886	extract methods to reduce complexity	9 years ago
Jens Ulferts	7a2a0324ae	extract method	9 years ago
Jens Ulferts	6837fffc77	remove instances of User.current	9 years ago
Jens Ulferts	f5437ff077	consolidate specs for move work package service	9 years ago
Jens Ulferts	bdf20ef94d	extract work package move/copy to own service	9 years ago
Oliver Günther	edf713fbd5	Rework managed repositories error handling ... This commit: - adds error messages for filesystem errors - Forces services and views to use repository.root_url instead of managed_path, which may not be available when config is missing	9 years ago
Jan Sandbrink	62e63b8d08	doc + specs for new service ... - also move create wp service into new directory (consistent with other things that live under 'app')	9 years ago
Jan Sandbrink	fd3312a0f2	extract attachment storing into service ... - service cares about adding a journal too - only store the attachment when the journal can be saved (i.e. the WP is valid)	9 years ago
Oliver Günther	ca04363e6d	Allow to delete filesystem managed repositories even when config missing ... Previously, repositories could not be deleted on disk when the `manages:` configuration entry was removed in the meantime. This commit allows repositories to be deleted in that case because we no longer depend on accessing the managed_root (path for `manages:`).	9 years ago
Oliver Günther	bb2a09490b	Remove delayed running of management workers. ... This commit (temporarily) removes the delayed creation and deletion of managed repositories for the sake of improvded error handling. After consultation with @ulferts, we suggest to improve the `Delayed::Job` pipeline to create means for identifying jobs (referenced ID) and to create a unified service to manage database AND filesystem access in a transactional manner. Also provides the following corrections: - Improve migration speed - Delete parent projects only by their identifier, not the managed root	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	b0c0d0a53f	Avoid fishy factory delegation.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring ... - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation ... Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the **legacy specs** for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Alexander Bach	a5f4eb1e8b	First event-based draft ... Unifies Journal- and WorkPackageObserver Removes them as observers Makes new JournalListener more classy	9 years ago
Alex Coles	5c8bff38ea	Fix syntax (w/Rubocop) in services ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	82d8b4500d	Remove temporal coupling	10 years ago
Alexander Bach	08bfddec48	Remove unused property	10 years ago
Alexander Bach	e547364886	Choose only valid types	10 years ago
Alexander Bach	e1d4f64616	Increase type safety ;)	10 years ago
Alexander Bach	6564cae465	Simplify work package services	10 years ago
Alexander Bach	cbe64452a8	Improve initialization readability	10 years ago
Alexander Bach	bee2df808b	Introduce CreateWorkPackageService	10 years ago
Alexander Bach	0f9ca97e07	Increase service flexibility	10 years ago
Alexander Bach	02240617f2	Remove temporal coupling	10 years ago
Alexander Bach	63867d9e10	Remove unused property	10 years ago
Alexander Bach	a9e758306c	Choose only valid types	10 years ago
Alexander Bach	f41e927a79	Increase type safety ;)	10 years ago
Alexander Bach	73cfcb061a	Simplify work package services	10 years ago
Alexander Bach	6c08706c22	Improve initialization readability	10 years ago