openproject

Commit Graph

Author	SHA1	Message	Date
Henriette Dinger	cf38af63eb	Use generic classes for the homescreen blocks and update the LSG	9 years ago
Oliver Günther	fcd450af3f	Fix redirect vulnerability `redirect_back_or_default` was vulnerable to some of the URLs found to be vulnerable in redmine, such as `@test.foo`. This commit extracts the whole functionality into a policy and alters the constraints with a path check to avoid these cases. Thanks to @marutosi for pointing this out. http://www.redmine.org/projects/redmine/repository/revisions/14560	9 years ago
Alex Coles	06274b97ea	Remove reundant include in MembersController spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Markus Kahl	dbc343555b	fixed members_controller spec adapted spec to new non-js behaviour	9 years ago
Alex Coles	87720d19ec	Fix broken #assert_select_rjs in Controller specs Add workaround for nested assertions, broken since Rails Dom Testing switch to Nokogiri. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	fecd3b3b3e	Simple API for managing the homescreen content This commit alleviates the homescreen management from both core and plugins, in order to simply add and remove blocks. Also contains refactoring from review * Consistent block and variable usage * Removed unused labels * Avoid word breaks in multiline enumerations and remove margin from enumerations	9 years ago
Oliver Günther	c49b59b7f2	Add controller and routing specs	9 years ago
Oliver Günther	15273724c3	Homescreen functionality This commit adds the homescreen functionality to OpenProject, replacing the default welcome screen. This adds support for: * Blocks of content for various privilege levels (latest projects, users, news, etc.) * Links to common functionality (administration, community) Relevant work package: https://community.openproject.org/work_packages/19722	9 years ago
Alexander Bach	d2fee1e293	Adjust test expectation to direction changes	9 years ago
Stefan Botzenhart	3fccb90c57	Use factory girl instead of object daddy	9 years ago
Alex Coles	8b88eb921f	Fix obsolete finder in MeetingsController Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Stefan Botzenhart	5dfa7802b7	Add controller spec for Project#custom_fields	9 years ago
Alexander Bach	78efda7ee8	Remove project homepage field from all the specs	9 years ago
Jan Sandbrink	1ac1188ef8	fix spec double and remove users from groupable CFs - spec double was not up to date with reality of return values - user custom fields are not successfully groupable, because the order statement is a list	9 years ago
Oliver Günther	ef322e89dd	Cleanup	9 years ago
Oliver Günther	3fce1d6f2e	Added service and controller specs	9 years ago
Oliver Günther	4025e0158d	Fix notification and Rails4-related issues The Notifier was removed in `6424ce2b13 (diff-38fdff24984f272711ecbd29c3cd51f7)`. After this, this plugin must have been broken. Additionally, several problems related to the Rails 4 update existed, such as shallow routes under a scope instead of resource. This PR should make the plugin usable again and also fixes all specs. Relevant work package: https://community.openproject.org/work_packages/21316	9 years ago
Jan Sandbrink	aa5155c8b7	fix specs - also extend WP schema specs	9 years ago
Oliver Günther	b15002beca	More explicit validation error message for repositories Adds a specific message for repository validation from enabled SCM Fixes missed venodor keys in specs	9 years ago
Oliver Günther	a71ce6f1a5	Refactor SCM config to lowercase / symbols ENV-based configuration for various configs can only provide case-insensitive values for SCM configuration and thus is unable to properly configure, e.g., managed repositories. This refactoring relies on lowercase configuration and symbols to define SCM vendors, and camelizes them to the old notation (e.g., :git => 'Git') when using `Setting.enabled_scms` to remain compatible with previous installations.	9 years ago
Alex Coles	efdfcf82e4	Fix typo in JournalsController spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	471fc04663	Fix ActionController::InvalidCrossOriginRequest in specs https://github.com/rails/rails/pull/13345 introduced CSRF protection to gets with JavaScript responses.	9 years ago
Alex Coles	96fedeb976	Use Minitest assertions: assert_not_* => refute_ Test::Unit-compatible assertions are no longer available in Minitest 5, the version bundled with Rails 4.1. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	14a394842d	Extract SCM authorization routines into policies per vendor	9 years ago
Philipp Tessenow	373473c563	Add git support to repository authentication script Refactors the original PR from #1629 * dispersed authorization methods in SysController * refactored and updated SysController specs	9 years ago
Oliver Günther	0b583c3ccf	Extend autofetching of commits into update repository information This commit extends the previous functionality of autofetch commits into internal updating of repository information, which encompasses: * Commit information (changesets) * Disk space information They are now both retrieved when browsing the repository and the latter is fetched asynchronously whenever the last update is older than the timeout setting. This timeout setting is now user-configurable.	9 years ago
Jens Ulferts	3aa8a144d6	adapt specs to send mails on self action	9 years ago
Jens Ulferts	e03e1e99df	prevent spec flicker by cleaning up after Setting.notified_events	9 years ago
Alexander Bach	a8e1aadec7	replace changed_data by details working towards making the alias obsolete...	9 years ago
Jan Sandbrink	ca03e6543a	fix specs	9 years ago
Oliver Günther	0610280e6f	Cleanup	9 years ago
Oliver Günther	c16c1e75d4	Extend SysController to allow WS to check / update storage	9 years ago
Jan Sandbrink	6c1e4dbf4f	send aggregated notifications - only sending the last mail of an aggregation chain - displaying the aggregated state of the change - replaces old classes for mail notifications - old special error handling for missing users is obsoleted, since recipients are determined at jobs runtime - special cases for missing author and journal are considered	9 years ago
Oliver Günther	9336cff8bb	Extended specs This commit adds / extends the following specs: RepositoriesController: Ensure empty repository page is shown for empty repositories adapters/subversion: Test correct use of --login, --password arguments	9 years ago
Oliver Günther	caf5e4a706	Formatting and clean up	9 years ago
Oliver Günther	c5b200d7a0	Review corrections - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Jens Ulferts	8133b1a488	i18n agnostic spec	9 years ago
Alex Coles	d052f189d5	Prefer #map over #collect Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a66f166498	Normalise syntax with Rubocop Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	22502bb008	Use 1.9+ Hash syntax Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ccb4268793	Normalise syntax with Rubocop Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	16fb352d8d	Use 1.9+ Hash syntax Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	138d3dba29	fix some specs - error messages now contain punctuation - when :save returns false, there should be errors present - errors in form representers are now API errors	9 years ago
peter	6a7ab0edb8	fix invalid response for /api/v2/authentication.json	9 years ago
Alex Coles	1d1d56217d	Without message chain, prefer #receive in spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	985a15f08a	Remove obsolete TODO in VersionsController spec [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8338b7a6e1	Update OP::Authentication to use uppercase headers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago

... 7 8 9 10 11 ...

1243 Commits (22a9d062ff80f5c19425f190104ca4774f651365)