openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	06d203141e	Remove outdated flash message Managed repositories are always deleted, even if the configuration states otherwise. The specific flash message concerning deletion of managed repositories is thus wrong and was removed.	9 years ago
Markus Kahl	dd496297fd	don't use random language as user's language If a user's language is not set ('') the code just used any valid language.	9 years ago
Jens Ulferts	67d8e7f240	remove DefaultData::Loader from source All of it is now handled by db:seed which needs to run anyway	9 years ago
Oliver Günther	f03008ec94	Require admin for destroy_info	9 years ago
Oliver Günther	c5b200d7a0	Review corrections - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	0284d11f21	Corrections from review - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	b0c0d0a53f	Avoid fishy factory delegation.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Alexander Bach	a5f4eb1e8b	First event-based draft Unifies Journal- and WorkPackageObserver Removes them as observers Makes new JournalListener more classy	9 years ago
Alex Coles	f320305531	Revert "Temp. comment includes in API v2 ProjectController" `FriendlyId::Finders` should ensure an identifier-aware `find` on an `ActiveRecord::Relation` chain. This reverts commit `51512f1522`.	9 years ago
Alex Coles	347f363026	Remove unloadable from controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
peter	6a7ab0edb8	fix invalid response for /api/v2/authentication.json	9 years ago
Alex Coles	8b4be7f749	Indent fix in RepositoriesController for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a3af19a8ff	Indent fix in SysController for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	acd23b8046	Fix missing space around block in MyController Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks `rubocop -a` does not currently normalise formatting consistently (see `ec1bb39f`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	75cecdb21a	Omit extraneous [] in APIv2 CustomFieldsController Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Florian Kraft	f8d69c5212	address hound complaints Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jan Sandbrink	f86e0ef591	uglify order statement at least this one DOES work...	9 years ago
Jan Sandbrink	253785622c	specify order in the Rails 3 way ascending is the default anyway	9 years ago
Jan Sandbrink	9cb9957bbb	also accept auto complete requests without query	9 years ago
Jan Sandbrink	d2eeb27c84	eliminate instance variable	9 years ago
Jan Sandbrink	c9f0fba192	increase readability of wp->hash conversion it might use more lines, but I hope there is a gain in readability	9 years ago
Jan Sandbrink	8897235fa4	rewrite find into where, order and limit	9 years ago
Jan Sandbrink	194f1814e1	always return a valid scope though WorkPackage works like a scope most of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	9 years ago
Jan Sandbrink	e51a4005ff	try to increase readability - extract scopedeterminition into an extra method - always use "outer" if statements in index method	9 years ago
Jan Sandbrink	280e333f18	explain why some code exists	9 years ago
Jan Sandbrink	2854584cb2	use more clear scopes for autocompletion lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	9 years ago
Jan Sandbrink	45815cb9f3	rename query to scope sounds more understandable to me, but I am biased, I guess...	9 years ago
Alex Coles	851f23712f	Prune commented code in TimelinesController [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	8798fe68ad	Teach Experimental API UsersController to pluck Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0942d7335b	Add explicit join references in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2d9cfd97f4	Remove deprecated Relation#all in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	ffd81c4886	Add some polish	10 years ago
Markus Kahl	bcd981df5c	consider X-Authentication-Scheme; opt scoped realm	10 years ago
Markus Kahl	d854df5175	suppress browser prompt on authenticate failure	10 years ago
Alexander Bach	1a52cc1292	Suppress the hound	10 years ago
Alex Coles	0c729dae54	Replace deprecated calls to Model.scoped Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	c687c63c71	Fix some project url building with identifiers This commit was powered by @ulferts	10 years ago
Alex Coles	ecfa05fad9	Rename Project.public scope to public_projects Avoid collision with `public` class method. As of Rails 4.1, `public` is explicitly black-listed as a scope name: https://github.com/rails/rails/pull/14582	10 years ago
Alex Coles	51512f1522	Temp. comment includes in API v2 ProjectController `includes().find` appears to have issues with polymorphic associations in Rails 4.0.x. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e02eb0181d	Migrate AR finder/query methods in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago

1 2 3 4 5 ...

2844 Commits (23a0d6855ad6035327cc539f9c6a163337cd6d18)