223 Commits (23a0d6855ad6035327cc539f9c6a163337cd6d18)

Author	SHA1	Message	Date
Oliver Günther	acb4431d8a	Implement UserPreferences endpoint ... Provides the implementation to the user preferences endpoint.	9 years ago
Stefan Botzenhart	1c01b5801e	Use login_as helper method throughout all specs	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	ab9d502009	Allow to delete work packages via APIv3	9 years ago
Jan Sandbrink	e7a6ae629e	Add specs for update links with missing permissions ... - also (for now) remove title text which was not localized - consistently use link helpers for the corresponding specs	9 years ago
Jan Sandbrink	e7291fba8c	Unify permission handling in representer spec	9 years ago
Jan Sandbrink	aad39544f5	Hide addAttachment link when user is not allowed	9 years ago
Jan Sandbrink	5de0f15898	Correctly link activities ... - they might not be embedded - create an endpoint for activities - document it properly - adapt angular client	9 years ago
Jan Sandbrink	14a55b82d1	Do not embed linked resources in WP collections	9 years ago
Jan Sandbrink	d8ec635e9e	simplify interface for assignable values ... - one method to rule them all - eases overriding -> does not require to define method for new types on base class - allows to infer values_callback from property name (schema representer)	9 years ago
Jan Sandbrink	9e8d051027	reintroduce form_embedded argument for schema ... we can't live without it :/	9 years ago
Jan Sandbrink	32e638449b	hide lockVersion from work package columns	9 years ago
Jan Sandbrink	80fc96dee3	replace deprecated AR method	9 years ago
Jan Sandbrink	bfcc769cfd	split implementations for work package schema ... - was already quite case-ish, depending on its creation via WP or via project + type - I plan on adding a third case, which would not improve the situation for a single class	9 years ago
Jan Sandbrink	aa5155c8b7	fix specs ... - also extend WP schema specs	9 years ago
Jan Sandbrink	b0d488f751	fix and extend collection representer specs	9 years ago
Alex Coles	a2b45b5ced	Replace call to removed Model.scoped in spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	e7abc0e3d5	first version of a paginated collection ... - common base class with UnpaginatedCollection - one implementor	9 years ago
Oliver Günther	41e7031f27	Additional corrections ... * Use 'has no link' for missing revisions link spec * Avoid duplicate get request	9 years ago
Oliver Günther	2a31d9cabd	Corrections from review ... * Return Unauthorized according to specification * Added revisions by work package specs for users without wp permission (404) and with wp, but without changeset permission (403) * Corrected paths * Use existing link shared examples * Add revision link representer specs * Test for missing author link in revison representer	9 years ago
Oliver Günther	ec3a5b9da7	Browse revisions by work package with linked collection	9 years ago
Oliver Günther	aa74e9c382	Added specs for revision endpoint	9 years ago
Jan Sandbrink	3f5c346aa5	add id to built models ... tried to correctly "build_stubbed" them, but turns out that this is harder than I would like it to be...	9 years ago
Jan Sandbrink	68d521ca85	add link for adding attachments to work package	9 years ago
Jan Sandbrink	1f7485d5bf	fix HTTP 500 in WP form ... - occured when an invalid type was provided by the client	9 years ago
Jan Sandbrink	88e052a53e	style ... [ci skip]	9 years ago
Jan Sandbrink	b374ebdd7f	store messages alongside error symbols ... - allows to skip translation part in ErrorBase - allows to have correct translations containing placeholder values	9 years ago
Jan Sandbrink	138d3dba29	fix some specs ... - error messages now contain punctuation - when :save returns false, there should be errors present - errors in form representers are now API errors	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation ... - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	13b9042293	treat all 422 errors the same for forms ... That means: Do render the form for all HTTP 422 errors, problems are highlighted within the form	9 years ago
Jan Sandbrink	8f110d8b93	adapt specs to new contract behaviour ... - also refine specs for done-ratio to check for non-fail when not changed - use shared examples for parent properties also in done ratio specs	9 years ago
Jan Sandbrink	ac9cffe741	remove tautology and add apropriate specs	9 years ago
Jan Sandbrink	e9059a97ee	style ... [ci skip]	9 years ago
Jan Sandbrink	ce0b906d91	dirty trick to allow using a Hash as mock ... also removes default value from initializer, which was never sane	9 years ago
Jan Sandbrink	0b7b4bf329	extract error merging into contract	9 years ago
Alex Coles	0436446257	Revert "DRY WorkPackageSchema#available_custom_fields spec" ... This reverts commit 8e47f600b0.	9 years ago
Alex Coles	8e47f600b0	DRY WorkPackageSchema#available_custom_fields spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	837265c257	Fix API v3 WorkPackageSchema for AR::Relation ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	baaf452cbd	style ... [ci skip]	10 years ago
Jan Sandbrink	e50e18dba1	fix spec ... the actual hashes provided by grape have string keys	10 years ago
Jan Sandbrink	4054c2ae22	add a removeWatcher link to work packages	10 years ago
Alexander Bach	ef88ca1339	Move out of place parenthesis back into position	10 years ago
Alexander Bach	8ae33c9d0f	Simplify test setup	10 years ago
Alexander Bach	a1ad5b92bf	Refactor test to use helper_class	10 years ago
Alexander Bach	21ee97b19f	Move test to proper location and benefit from it	10 years ago
Alexander Bach	e7f080efbb	Check link content as well	10 years ago
Alexander Bach	ce81b7f4f2	Add specs for create form api	10 years ago
Alexander Bach	0e9e986f7f	Style fixes	10 years ago