openproject

Commit Graph

Author	SHA1	Message	Date
Jens Ulferts	d04b86da9c	introduce custom eager loading for work package list Reduces the amount of AR models instantiated when handing wp#index requests by: * Calculating part of the checksum for caching in the db. This is done by using the id and the updated_at/on field of associated models whose representation is cached in the wp representer. * Reusing instantiated models for multiple associations. e.g instances of Project are used in various places (the work package itself, it's ancestors and children). Instead of using Rails' eager loading which would instantiate a project potentially once for every association path, the code now assigns the same instance to all those associations. Additionally, the commit streamlines the creation of custom field injected representers. Now only one class is created for all work packages when before it would be one class for every uniq set of custom fields. On top of that, the class can be reused if the set of custom fields does not change.	7 years ago
Jens Ulferts	5a5e3494f9	turn attribute group into dedicated object	7 years ago
Jens Ulferts	a33b0bbbbd	WIP - return Query as an attribute group * only default query for now * only returned when no custom configuration is applied * start to turn attribute groups into ressources	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	ab9a9baee7	[26002] Add date as writable when type is milestone (#5804 ) https://community.openproject.com/wp/26002 [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732 ) * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
ulferts	65c7db3120	avoid side effects on calls to attribute_groups (#5677 ) Without the deep_dup, the call to attribute_groups used to alter the type's attribute_groups deeply nested attribute_groups property. As a result, the second call to attribute_groups would be different from the first one. This became most apparent when rending the schema for a couple of work packages all sharing the same type. As the type was reused to render the schema, but the project might have changed, only the first schema for the type was accurate, while subsequent schemas for that type lacked attributes [ci skip]	8 years ago
Oliver Günther	5d50acc50e	[25288] Re-add translations to default attribute groups (#5515 ) * [25288] Re-add translations to default attribute groups Uses symbols to mark internal attribute groups and translates them in the schema representer to the user's locale. * Extend form configuration front end for translated default groups * fixing specs * fix feature spec for attribute groups * Add symbol test to attribute groups [ci skip]	8 years ago
Jens Ulferts	6391867267	minor code quality improvements	8 years ago
Oliver Günther	ba9c0ce58f	Allow custom fields to be added through type	8 years ago
Oliver Günther	e4f0cb6634	Fix AR method name duplication	8 years ago
Oliver Günther	8220d43bbf	Add custom sub-models for attribute constraints and groups This allows plugins such as backlogs and costs to integrate into the grouping while restricting while they are visible. The problem here is that on a global admin page, the plugin's attributes should be available, however in a project context, they should only be added when the respective module is active.	8 years ago
Oliver Günther	59220397d8	Implement frontend for group configuration	8 years ago
Wieland Lindenthal	8000c27bec	Fixing spec	8 years ago
Wieland Lindenthal	da9afaa9a2	Not necessarry stuff killed	8 years ago
Markus Kahl	3cf5cda7ce	fixed _attributeGroups format	8 years ago
Markus Kahl	0ff5eb8d3f	attribute groups backend draft 1	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	5948249c77	no longer show available values for a typed schema Before, the available values where always embedded into every schema. Because a deep copy is performed in the front end, this would downgrade the performance of the wp list in cases where a schema has a list cf with a lot of available values	9 years ago
ulferts	2c47657de7	unified date field for milestone work packages (#4437 ) Work packages having a type that is a milestone receive a 'date' attribute in their API resource. Other work packages still have the 'startDate'/'dueDate' attributes. The schema behaves analogous so that such a change is visible to a client. In the cient we can now remove some of the custom behaviour for the date field. The code removal is limited to the new inplace edit implementation as the old implementation can hopefully be removed fully in the near future.	9 years ago
Jens Ulferts	5a977c5594	add resource for querying the list of allowed projects	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	d8ec635e9e	simplify interface for assignable values - one method to rule them all - eases overriding -> does not require to define method for new types on base class - allows to infer values_callback from property name (schema representer)	9 years ago
Jan Sandbrink	9ac9524d28	change attribute registration via plugin to be more generic - now also registers the attribtue as writable in the schema	9 years ago
Jan Sandbrink	8e4321959e	improve code style	9 years ago
Jan Sandbrink	bfcc769cfd	split implementations for work package schema - was already quite case-ish, depending on its creation via WP or via project + type - I plan on adding a third case, which would not improve the situation for a single class	9 years ago
Jan Sandbrink	d5fe64bd5e	move writability decision into WP schema - reducing the method count (aka interface size) of the schema - giving it more control - still allow outside override in representer (for plugin compatibility)	9 years ago
Alex Coles	837265c257	Fix API v3 WorkPackageSchema for AR::Relation Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	9abbe5c4f7	Remove deprecated Relation#all in lib Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	f48972d570	Added schema indications for writability of start & due date	10 years ago
Jan Sandbrink	52696b5c98	extract a scope for active priorities	10 years ago
Jan Sandbrink	b407d0a43c	use "try"	10 years ago
Jan Sandbrink	bda0a30b70	only query the status, not the whole WP	10 years ago
Alexander Bach	1cc5c212ff	Fixed utility method	10 years ago
Jan Sandbrink	467fc9dba6	make WP schema resilient to invalid work packages	10 years ago
Alexander Bach	ed723aeeb3	Improve performance and readability of leaf_or_nil?	10 years ago
Alexander Bach	cc234861e2	Some minor style improvements	10 years ago
Alexander Bach	35af232afd	Improve method naming and implementation	10 years ago
Alexander Bach	cc20199571	Correctly state property writablility in schema	10 years ago
Jan Sandbrink	f99e735611	add type getter to WP schema	10 years ago
Jan Sandbrink	857bcf4636	some refactoring around the WP schema - schema does not decide anymore whether to include allowed values (solely decided by "form_embedded" of representer) - schema will answer as many "assignable_*" methods as possible - work package does not need those methods anymore (except few cases)	10 years ago
Jan Sandbrink	0394bc7daa	show allowed statuses correctly during type change	10 years ago
Jan Sandbrink	53909cbb61	indicate type as editable in schema	10 years ago
Jan Sandbrink	2c9447bfa3	include self link in schema - only if the schema is not embedded in a form	10 years ago
Alexander Bach	95721361b9	Incomplete base	10 years ago
Jan Sandbrink	e8b461f23b	more elegant style add spec stub for work package schema	10 years ago
Jan Sandbrink	097e29de90	fix wrong member access	10 years ago
Jan Sandbrink	8debd27c32	extract schema endpoint - schema representer now represents a schema - a schema has a limited subset of a WPs functionality - schema can be created with or without work package	10 years ago
Jan Sandbrink	04ca1e5b93	move schema representers into own directory	10 years ago

1 Commits (246afcc1ad809faa446720702b3daec20c5433fb)