132 Commits (2528cf43bdcd3f40d37806201125c148421934ff)

Author	SHA1	Message	Date
Jan Sandbrink	8897235fa4	rewrite find into where, order and limit	9 years ago
Jan Sandbrink	194f1814e1	always return a valid scope ... though WorkPackage works like a scope *most* of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	9 years ago
Jan Sandbrink	e51a4005ff	try to increase readability ... - extract scopedeterminition into an extra method - always use "outer" if statements in index method	9 years ago
Jan Sandbrink	280e333f18	explain why some code exists	9 years ago
Jan Sandbrink	2854584cb2	use more clear scopes for autocompletion ... lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	9 years ago
Jan Sandbrink	45815cb9f3	rename query to scope ... sounds more understandable to me, but I am biased, I guess...	9 years ago
Alex Coles	0c729dae54	Replace deprecated calls to Model.scoped ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	9eb7cfbe9b	actually allow the status to be set while moving ... apparently the status_id param was set to expect an array of values while being moved in this commit: d7f399ab8d Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	9 years ago
Jan Sandbrink	d3ceffddfc	actually allow the status to be set while moving ... apparently the status_id param was set to expect an array of values while being moved in this commit: d7f399ab8d Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	10 years ago
Jan Sandbrink	42ec887384	uglify order statement ... at least this one DOES work...	10 years ago
Jan Sandbrink	0f868f17e2	specify order in the Rails 3 way ... ascending is the default anyway	10 years ago
Jan Sandbrink	9ed5480298	also accept auto complete requests without query	10 years ago
Jan Sandbrink	799f3b9b52	eliminate instance variable	10 years ago
Jan Sandbrink	b265ad88db	increase readability of wp->hash conversion ... it might use more lines, but I hope there is a gain in readability	10 years ago
Jan Sandbrink	b524b0724d	rewrite find into where, order and limit	10 years ago
Jan Sandbrink	dd052d5114	always return a valid scope ... though WorkPackage works like a scope *most* of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	10 years ago
Jan Sandbrink	dc71f37587	try to increase readability ... - extract scopedeterminition into an extra method - always use "outer" if statements in index method	10 years ago
Jan Sandbrink	4556da741e	explain why some code exists	10 years ago
Jan Sandbrink	d59b54a63c	use more clear scopes for autocompletion ... lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	10 years ago
Jan Sandbrink	75b542725a	rename query to scope ... sounds more understandable to me, but I am biased, I guess...	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	bb0e6e6aa5	Fix syntax (w/Rubocop) in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	336446c59d	Use 1.9+ Hash syntax in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	1900e9b55d	Fix whitespace in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Till Breuer	adeb2e4a27	Don't render ok in bulk#delete if clean up is required	11 years ago
Till Breuer	d67bc8b975	Temporarily allow for ajax calls to bulk controller ... Undo when API V3 is ready	11 years ago
Alex Coles	d30ce48539	Begin replacement of server-rendered context menu ... Removes WorksPackages::ContextMenusController, its views and specs, and ContextMenuHelpers. This patch begins the work needed to serialise a given WorkPackage's 'actions' in the v3 API response, based on a user's permissions. This should support a client-rendered context menu (or any other contextual UI for that matter). Much code was simply copy-and-pasted from ContextMenusController into Api::V3::WorkPackagesController. This code still requires considerable refactoring and optimisation. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Philipp Tessenow	145fb9c5cb	remove duplicated method from moves_controller ... The find_work_package method was present in work_packages/moves_controller.rb as well as in application_controller.rb. As the MovesController inherits from Application controller and the methods in both controllers are identical, it can be removed from the MovesController.	11 years ago
Richard	2f11241407	WIP. using the url params to keep state but having a nightmare with url escaping:/	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Sebastian Schuster	11a566a044	Removed now-redundant specification of Status sort order	11 years ago
Philipp Tessenow	10b62ca681	fix #4858	11 years ago
Sebastian Schuster	7e726ea2a2	Added responsible for work_package summary	11 years ago
Sebastian Schuster	1f8446f7cd	Added responsible to context menu	11 years ago
Sebastian Schuster	46834b7cba	Added responsible to bulk update	11 years ago
Sebastian Schuster	c0f7acafa1	Implemented treating assignees and responsibles differently so there ... are no (non-functional) group responsibles anymore	11 years ago
Hagen Schink	24ad6d03af	Fixes duplicated journal notes on move	11 years ago
Philipp Tessenow	80dd8836b4	let the at.js textarea autocompletion look like the usual work-package auto-completion	11 years ago
Philipp Tessenow	d7844da23f	add issue number autocomplete for textareas	11 years ago
Till Breuer	6fef6001da	Perform individual parameter whitelisting during work package bulk update	11 years ago
Till Breuer	e43506b7a1	Fix work_packages/bulk#update if no work package params are passed	11 years ago
Till Breuer	e34b674dcf	Use permitted params instead of safe attributes in work packages bulk controller... ... ... to allow for cost_object_id updates (fixes #2591)	11 years ago
Philipp Tessenow	444546e2e8	use \A and \z instead of ^ and $ in ruby regexes	11 years ago
Jens Ulferts	e78d2b4eef	adds breadcrumb label for bulk controller	11 years ago
Jens Ulferts	9650774167	restyles wp destroy form for extensibility	11 years ago
Jens Ulferts	d1ee79d75d	reimplements bulk destruction of work packages ... There no longer is a destroy action on the work package controller. It needed to be either in the work package controller or the work package bulk controller. The later was the better place based on the controller's structure.	11 years ago
Jens Ulferts	13280996b3	moves work_package_bulk controller into work_packages namespace	11 years ago
Stefan Frank	e7e9e928af	major refactoring of reports into separare classes ... reports now live in separate classes: This brought up several issues with buggy templates; lots of duplicate code has now been removed. Still needs some view-testing, and maybe some unit-testing for the service.	11 years ago