openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Aleix Suau	53f8e985ff	Fixed: figcaption kept inside the image (#8882 ) * Fixed: figcaption kept inside the image * adapt specs to altered figcaption handling Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844 ) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit `0d27d28137`. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	73a1d29e95	[24760] Enable ckeditor image resize plugin https://community.openproject.com/wp/24760	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	9de876df95	Take care that Backlogs/versions partial is used && Fix tests	5 years ago
Henriette Dinger	7167a85cb0	Fix specs by correcting the project settings paths and do some minor selector changes	5 years ago
Oliver Günther	d001679673	[31531] Fix visiting history wiki content https://community.openproject.com/wp/31531	5 years ago
ulferts	0065dd5fe4	attempt to stabilize flickering spec	5 years ago
Oliver Günther	8e0dee1ad8	Fix editing new backlogs wiki page	5 years ago
ulferts	5c46d66b41	redirect attachments calls to api v3	5 years ago
Oliver Günther	d41e1563f2	Fix broken selectors	6 years ago
Oliver Günther	4623fecf7a	Create upload helper in wysiwyg component	6 years ago
Jens Ulferts	c65b59374f	bump ckeditor to 11.1.1	6 years ago
Oliver Günther	a5b0764638	Revert "bump ckeditor to 11.1.1"	6 years ago
Jens Ulferts	e1ebb4b471	bump ckeditor to 11.1.1	6 years ago
Henriette Dinger	b23a01712f	Attempt to avoid test flickering	6 years ago
Oliver Günther	baf4a71fbf	[28381] Fix attachment lookup by customizing src attribute downcast This PR: 1. Prepends the `editingDowncast` to replace named attachment URLs with their full accessible URLs for viewing 2. Prepends the `dataDowncast` with a data-original-src attribute containing the named attachment 3. Fixes the turndown replacement for images to use that tag. 4. Vendors our GFM commonmark plugin since its now no longer usable on its own.	6 years ago
Jens Ulferts	1641c2fe97	replace wiki rename cuke	6 years ago
Jens Ulferts	642cb1b5b3	remove duplicating spec	6 years ago
Oliver Günther	eac3b7db3b	Fix toolbar in wiki index/toc page https://community.openproject.com/wp/28307	6 years ago
Wieland Lindenthal	4e9302193e	fix spec	6 years ago
Oliver Günther	8a0df0eb79	[28188] Make wiki content text not required https://community.openproject.com/wp/28188	6 years ago
Oliver Günther	223284c401	[28171] Output claimed attachments on wiki representer https://community.openproject.com/wp/28171	6 years ago
Jens Ulferts	0d22112e0e	replace rails based attachment forms and lists completely	6 years ago
Jens Ulferts	abda9056cd	add attachment on new resource via rails form	6 years ago
Wieland Lindenthal	e58cd194d8	Tell Rubocop to ignore FrozenStringLiteralComment	6 years ago
Jens Ulferts	319f33e924	remove textile	6 years ago
Wieland Lindenthal	221493be92	Improve default titles for wiki pages: - When created from URL, greplace dashes with spaces and captilaze first word. - When created with `../new` do not copy parent’s title into the page title but have a proper placeholder string „Page title“ instead.	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Jens Ulferts	cf35cc65ad	squash all migrations up to 7.1.0	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	c8ef6e1a4d	Strengthen specs (Try #2 ) (#5686 ) * Don't use expect in retry_block It doesn't raise an exception, but only marks the example erroneous * Replace textile_link cuke * Replace wp search cuke with existing spec We only need to test for the href, no need to check that the page exists. * Also remove pagination cuke, its part of the search-spec [ci skip]	7 years ago
Oliver Günther	90da34c601	Fix specs	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	11d4b30d10	Strengthen unicode spec selector This might fix https://travis-ci.org/opf/openproject/jobs/167037128	8 years ago
Oliver Günther	c5ca7e7782	Actually save the title, not the name	8 years ago
Henriette Dinger	2e6adb9f6d	Fix broken specs	8 years ago
Oliver Günther	1ff88a823b	Swap and correct WikiMenuItems titles and names Previously, the `title` attribute of a WikiMenuItem was used to identify a page that was linked to. With slugs, that makes no sense. We swap the name and title usage so that: 1. Name is used for the wiki_page slug that is being linked to 2. Title is used for the displayed name	8 years ago
Oliver Günther	e8904a4f76	Clarify slug duplicate in spec	8 years ago
Oliver Günther	c5acedb1eb	Let text_formatter write the slug as a link	8 years ago
Oliver Günther	9a34fe27c7	Migrate wiki titles to URL slugs Wiki titles in 6.0 can contain ANY character, which is causing issues for specific characters processed by textile and CGI-escaped before we can actually parse wiki links. To mitigate the issue of linking space/underscored wiki pages, introduce a permalink URL based on the title and create a migration to move old underscored titles (e.g., `base_de_donées` to spaced titles `base de donées`).	8 years ago

45 Commits (2667cd15817ca72721a56d5c8c490ba777253aec)