748 Commits (290cc8bd02c154a4e1b2791f72ee4fcc5632be81)

Author	SHA1	Message	Date
Oliver Günther	5693f6946c	Fix summing done_ratio when estimated_hours is zero (#4528) ... When `estimated_hours` is `0.0`, it is still taken into consideration when weighting average done ratios for a parent. That results in the parent becoming `0%` done. As 0.0 is being set in the frontend as the default value, this is now happening all over the board. A separate PR should refactor the frontend for 5.1. to allow null as a value for estimated_hours.	9 years ago
Henriette Dinger	867b273c8a	Set default wp type	9 years ago
Markus Kahl	a7f7a5f276	added interpolation spec	9 years ago
ulferts	9ab87ff564	always have current status as an option for the new status (#4423) ... The current status will always be available as an option when the work package is queried about what status it can be changed into.	9 years ago
Jens Ulferts	5cbc31392f	move some specs into appropriate file	9 years ago
Jens Ulferts	d1c2578eee	extract new status description into separate spec	9 years ago
ulferts	29bd679361	Fix/no text cf columns (#4413) ... Removes custom field columns from the query when the custom fields has field_format == text. Displaying long text is not feasible inside the small space the work package table offers.	9 years ago
ulferts	eae5321c4e	Feature/latest project activity (#4390) ... The project table is extended to also have the "Latest activity at" column which shows the date of the latest write operation within the project. https://community.openproject.com/work_packages/22858 Models can register for being considered when the latests activity date is calculated. This mechanism can be and is used by core and can also be used by plugins. It is unfortunate, that the mechanisms already in place by acts_as_activity could not be reused, but it would have required a complete rework to make it happen. Another shortcoming of the current implementation are the sql strings generated within Project::Activity. It would have taken more time to rework them into Arel and as the improvable code is limited to one class and a clean interface separates it from the rest of the application I deem it ok to stay that way for now.	9 years ago
ulferts	1f33252f0d	fix date validation warning (#4391)	9 years ago
Oliver Günther	bececbce8f	Integrate openproject-announcements ... This commit integrates the announcement functionality of openproject-announcements. It extends showing the announcement on the homescreen.	9 years ago
Oliver Günther	638340e7b6	Fix rubocop issues	9 years ago
Oliver Günther	e9cd24f2bf	Add support for parent-scoped with_settings data	9 years ago
Oliver Günther	b2490bf958	Fix 'with_settings' specs	9 years ago
Oliver Günther	8fd75e0456	Extend Subversion repository with UTF-8 paths (#4326) ... Provide some test data for UTF-8 encoded paths with Subversion. This confirms the tests of PR #4324. Side note: OS X will decompose some unicode characters into two characters. For example, the LATIN SMALL LETTER O WITH DIAERESIS (U+00F6 `ö`) will be decomposed into o and COMBINING DIAERESIS (U+0308). This obviously breaks SVN path mapping and while you will be able to commit files with decomposed paths, it will wreak havoc when using these characters on repositories manipulated by OSX and other systems. It apepars that Windows, Linux silently ignore these changes. We can't really account for this server side, but unicode-path patches exists for Subversion on OSX. For git, a config setting exists that does just that (`core.precomposeunicode`).	9 years ago
Oliver Günther	9db305439d	[22158] Fix CopyProjectJob notifications ... * Actually send copy job notifications * Skip enqueuing notifications when mails are disabled Aggregated journal notifications are sent after a delay, after which the actual job has long completed.	9 years ago
Markus Kahl	d2bc4202ad	make group deletion fast	9 years ago
Jens Ulferts	ff3d42fa33	add a project independent endpoint to create work packages ... Includes the auxillary end points: * form * schema * available_projects	9 years ago
Jens Ulferts	909b805917	Remove project#add_work_package	9 years ago
Jens Ulferts	92a09b89bc	add scope to Type to query for those enabled in a project	9 years ago
Jens Ulferts	dd05cf297c	add capability to move work package accross projects to service	9 years ago
Jens Ulferts	09e5815a74	add sumsSchema to api	9 years ago
Oliver Günther	02b5b8dda1	Add simple YAML extraction of ENV overrides ... Allows users to pass arrays or hashes via `[foo,bar]` and `{ foo: bar }` notation via inline YAML syntax.	9 years ago
Jens Ulferts	0d6f420afc	Revert "less magic on default query columns" ... This reverts commit 2293c3735b.	9 years ago
Jens Ulferts	2f764b84b9	Revert "less magic on default query columns" ... This reverts commit 2293c3735b.	9 years ago
Oliver Günther	04398738f2	Allow Repository.disabled_types to be strings ... When passing configuration settings through ENV (e.g., packager), we can't pass arrays as configuration settings. This PR allows `Repository.disabled_types` to be set as a String in ENV, e.g., through `OPENPROJECT_SCM_SUBVERSION_DISABLED__TYPES='existing,foobar'`.	9 years ago
Jens Ulferts	2293c3735b	less magic on default query columns ... Use the columns defined to be default for a new query as a default for a new query upon initialization. A caller can chose to overwrite this. This prevents the columns from getting readded when no column is selected. It also allows to improve the performance of the work_packages#index call because an SQL query with less columns is considerably faster.	9 years ago
Jens Ulferts	0267938c36	introduce spent_time model	9 years ago
Oliver Günther	aaeb58ad53	Add separate regex-based delimiter for incoming mails ... This adds a simple additional field to let the input body of mails be delimited by a regex provided by the user, since all other delimiters are escaped before being used by regex. Since we don't want to force existing user of the feature to change their settings, simply removing the regex escape is not a viable option.	9 years ago
Jens Ulferts	061a71bb32	fix setting custom values on version	9 years ago
Oliver Günther	8dc9b592c4	Fix merge hickup	9 years ago
Jens Ulferts	2516e9c0e7	allow to disambiguously group by responsible association ... Before the commit, the result for a count on a query grouped by responsible would be of the schema { id: count, id2: count2 }. For other attributes, e.g. assignee it is { user: count, user2: count2}. The difference is caused by using :responsible_id for grouping which is necessary as the association causes an ambiguous reference in the issued db query. That problem has been fixed in rails/master (c2d33c4abf). But as long as the fix is not backported, we will have to overwrite a method of ActiveRecord::Calculations	9 years ago
Jens Ulferts	b8c7d77683	unpersisted WPs are considered leaves	9 years ago
Jens Ulferts	5e6d657a35	remove no longer required dynamic spec generation	9 years ago
Jens Ulferts	11d7e428ad	reuse version calculation on eager loaded projects ... Eager loading projects assigns the same object instance to each work package having the same project_id. When the first project evaluates the assignable versions, the result can be memoized to be used by other work package having the same project	9 years ago
Stefan Botzenhart	1f53f5472e	Code style enhancements to fight against bad scoring	9 years ago
Markus Kahl	b071308444	fixed broken permitted param specs	9 years ago
Jens Ulferts	0980f01a95	copy over symbol in custom value to customizable ... We need to have access to the original symbol so that the API v3 can post process the errors on the custom fields just like it does every other field. When only a string is provided, the symbol :unknown is stored which will lead to the API rendering error messages like "can't be blank" (without the erroneous field name).	9 years ago
Oliver Günther	353039fcfe	Allow PermittedParams to receive new keys from plugins ... Previously, PermittedParams allowed only the extension of existing keys with new attributes from plugins. Since we now need to extend strong_params from global roles in impermanent memberships, we can prevent load-order dependencies by injecting a new key in the permitted params hash into the core.	9 years ago
Stefan Botzenhart	a71e253841	Rename spec description ... This is require so we can disable it within a plugin. Somehow rspec example disabler has problems with quotes.	9 years ago
Stefan Botzenhart	ba3c727dcc	Remove pending specs	9 years ago
Mohamed Wael Khobalatte	e10cc2d6ad	Pass project_id instead of project instance to version_attributes	9 years ago
Oliver Günther	589ba8e7b1	Relocate repositories locally and remote ... This commit introduces relocating a repository as a followup after a project's identifier has been renamed.	9 years ago
Mohamed Wael Khobalatte	18ac022927	Add specs for new strong_params methods	9 years ago
Mohamed Wael Khobalatte	a1bf92212d	Fix legacy and cucumber specs failing because of strong params	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago
Oliver Günther	02807e02a8	Refactor CopyProjectJob to class	9 years ago
Jens Ulferts	b0a86a69c2	refactor types action on projects controller ... * Introduced a service to reduce complexity in the controller * Used permitted params to ensure params syntax * Introduced a scope for querying for types used by a work package of the project	9 years ago
Mohamed Wael Khobalatte	7e7868b5a9	Send `watcher set` emails only when said watcher allows email notifications.	9 years ago
Jens Ulferts	c3ab585e80	remove dead code	9 years ago
Jens Ulferts	60a7e8a0d3	add spec for saving of preferences refered to as other ... Was wondering if sending of "others_will_change!" is necessary but apparently, it is not	9 years ago