54 Commits (2a8bb15d8092f6ccff117a36e0bbe234b458e33f)

Author	SHA1	Message	Date
ulferts	d34d14cfb2	legacy_spec to spec	4 years ago
ulferts	1f18dfca1a	legacy_spec to spec	4 years ago
ulferts	64a6a4501b	legacy_spec to spec	4 years ago
ulferts	b91e9d4201	legacy_spec to spec	4 years ago
ulferts	d1f419385f	Feature/member custom notifications (#9173) ... * include custom message in membership forms * keep pristine params to be able to pass it to the state * fix indentation on projects api docs * pass grape instance around in default endpoints The grape instance has readily available access to all the objects (params, current_user) so less individual parameters need to be passed. This also avoids having to store the grape endpoint in a potentials not thread safe variable * send custom message out on membership creation * send custom message on membership update * send custom message even if setting disabled * restore params interface * add custom message description to schema * describe notificationMessage in the api documentation * extract meta payload functionality into mixin * ensure password in spec meets requirements * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958) ... * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
Oliver Günther	8a066ae425	[32180] Fix invalid version diff number ... The version number is no longer incorrect in the mailer since we delay them https://community.openproject.com/wp/32180 [ci skip]	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Yegor Tovstik	b503f579e0	PR fixes	5 years ago
Yegor Tovstik	ee2762e8ef	Send email on watcher being removed	5 years ago
ulferts	5c46d66b41	redirect attachments calls to api v3	6 years ago
Oliver Günther	86be73236f	Prepare for core integration	6 years ago
Oliver Günther	352099089c	Prepare for core integration	6 years ago
Oliver Günther	42584aeae3	[28186] Fix formatting journal details in no_html_mode ... https://community.openproject.com/wp/28186 [ci skip]	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot ... Removes the deprecation	7 years ago
Oliver Günther	fb7c0a8012	FactoryGirl => FactoryBot (opf/openproject#6304)	7 years ago
Oliver Günther	c84b29827e	FactoryGirl => FactoryBot (opf/openproject#6304)	7 years ago
Henriette Dinger	e064bb7af8	Increase contrast between differences in journal (#6194) ... [ci skip]	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	646d99b704	Prepare OpenProject 6.0.0 release	8 years ago
Stefan Botzenhart	463a115d6c	Fix rubocop issues	9 years ago
Oliver Günther	d09c91d2f8	Complete translation of done ratio ... Fixes specs broken with a4b672ce22	9 years ago
Alex Coles	e493107140	Fix deprecated call to #deliver in UserMailer spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Stefan Botzenhart	868d764a97	Use activejob deliver_now method (removes deprecation warning)	9 years ago
Alexander Bach	81606714d9	Add specs for new mailer method	9 years ago
Jan Sandbrink	f08eb09627	fix specs	9 years ago
Jan Sandbrink	27eeb8bbf5	fix words	10 years ago
Jan Sandbrink	e6ee21b518	fix spec call and move more tests over to specs	10 years ago
Jan Sandbrink	2411b6ea75	replace some TestUnit tests with RSpec	10 years ago
Jan Sandbrink	1f3b47f461	test and fix mail delivery ... - add specs testing the observable behaviour - keep the interceptor mostly intact - use the same hack already known	10 years ago
Alex Coles	3785fdc9ed	Use #describe, #context with String arg not symbol ... The semantics of `describe` have changed in RSpec 3: passing a symbol rather than a string will change the value of the described object. See discussion here: https://github.com/rspec/rspec-core/issues/1114 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	f0b95955a0	Normalise syntax with Rubocop ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	31d1d4b297	Use 1.9+ Hash syntax ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	6e51fb8410	Fix specs	10 years ago
Hagen Schink	590bc1c434	Switch handling logic of no_self_notified setting	10 years ago
slawa	373fd026b4	Spec tests for MeetingMailer	10 years ago
Alex Coles	25b8157bd7	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 5 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 3 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } * 1 conversion from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	7b30d42348	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 1.12.0 with the following command: transpec * 60 conversions from: obj.should to: expect(obj).to * 23 conversions from: == expected to: eq(expected) * 15 conversions from: obj.stub!(:message) to: allow(obj).to receive(:message) * 8 conversions from: be_true to: be_truthy * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 5 conversions from: be_false to: be_falsey * 5 conversions from: it { should ... } to: it { is_expected.to ... } * 2 conversions from: =~ [1, 2] to: match_array([1, 2]) * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: pending to: skip * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 1 conversion from: obj.should_not to: expect(obj).not_to	11 years ago
Alex Coles	5cdc438c52	Convert specs to RSpec 2.99.0.beta2 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 402 conversions from: it { should ... } to: it { is_expected.to ... } * 67 conversions from: be_true to: be_truthy * 55 conversions from: be_false to: be_falsey * 35 conversions from: it { should_not ... } to: it { is_expected.not_to ... } * 20 conversions from: == expected to: eq(expected) * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: =~ /pattern/ to: match(/pattern/) * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 1 conversion from: after { example } to: after { |example| example } * 1 conversion from: pending to: skip	11 years ago
Alex Coles	a2679b5d35	Convert specs to RSpec 2.14.8 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec . * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 3 conversions from: obj.should to: expect(obj).to * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: obj.should_not to: expect(obj).not_to * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message)	11 years ago
kgalli	291aa1c6c5	Small refactoring of spec including comment to clarify before block	11 years ago