openproject

Commit Graph

Author	SHA1	Message	Date
Wieland Lindenthal	c4c2149d98	Fix: 36299 -- Allow to modify login when global permission :manage_users present (#9026 ) * Refactoring: Create shared examples for user contracts * Users::UpdateContract spec added * Add spec for updating the login of a user * Add spec for permitted params when global permission to :manage_user * Remove spec for :login updates for user UpdateContractSpec The writability of the login attribute is not part of the contract (yet). * Use user contract for checking writability of user attributes * Fixing user contract specs. * use persisted user in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	109ade62da	Allow editing auth_source as a global user (#8954 )	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557 ) * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
Oliver Günther	dab04415c4	Fix indentation from editorconfig	5 years ago
Oliver Günther	80e747e0c6	Fix test by calling service with system user Adds this to the factory to avoid using the system user all over the place	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	70a29885d5	fix topic attachment upload	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	7d4a4a19e7	use join table for storing activites active in project	5 years ago
ulferts	5733679291	add project status to project settings page	5 years ago
Oliver Günther	0541a32dfa	Fix specs	5 years ago
Oliver Günther	c5994d3b9b	Rename Boards to Forums	6 years ago
Henriette Dinger	ec7627e0e7	Add migration to remove impaired column from database	6 years ago
Oliver Günther	86be73236f	Prepare for core integration	6 years ago
Oliver Günther	5b49b33b21	Prepare for core integration	6 years ago
Oliver Günther	b08a5874f5	Remove project responsible and type	6 years ago
Jens Ulferts	5a1e597d84	remove in_aggregation from type	6 years ago
Markus Kahl	bfb9601d76	registration footer override	7 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	fb7c0a8012	FactoryGirl => FactoryBot (opf/openproject#6304 )	7 years ago
Oliver Günther	61afac09cc	FactoryGirl => FactoryBot (belongs to opf/openproject#6304 )	7 years ago
Jens Ulferts	38cc9ae9c1	fix copy workflows and query attribute groups	7 years ago
Jens Ulferts	a352392268	cleanup type controller and service	7 years ago
Jens Ulferts	95a4c352d7	allow sorting custom actions	7 years ago
Jens Ulferts	9bf5d05fdb	add description on custom action * turn custom action into fully fledged resource * add description to custom action model * load custom action resource on mouse over and display in title	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Jens Ulferts	886273ee86	initial implementation of conditions - status	7 years ago
Jens Ulferts	92ce554e53	configurable actions on custom actions	7 years ago
Jens Ulferts	7b197b49a7	add stub custom_action model	7 years ago
Jens Ulferts	baa7e99d1d	cleanup timelines data	7 years ago
Jens Ulferts	dd80b0d670	remove planning_element from permitted_params	7 years ago
Oliver Günther	a0150fffa0	Remove timelines	7 years ago
Jens Ulferts	82bb46f27e	replace deprecations	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533 ) * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
Wieland Lindenthal	185a6e9c02	When params for existing cost items were not provided, cost items were not deleted (#288 ) When params for existing cost items were not provided, cost items were not deleted [ci skip]	8 years ago
Jens Ulferts	53033ebfb5	adapt spec to removal of permitted params method	8 years ago
Jens Ulferts	5b9efd6efe	rewrite permitted_params_spec	8 years ago
Jens Ulferts	f5531d2c44	fix switching month on calendar	8 years ago
Oliver Günther	f377e9d943	Replace themes with static design to be overridden once	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	688385428c	Avoid multiple requires of spec_helper https://github.com/rspec/rspec-core/issues/1076	8 years ago
Jens Ulferts	77479ed4b2	add meetings to permitted search params	8 years ago
Oliver Günther	646d99b704	Prepare OpenProject 6.0.0 release	8 years ago
Alex Coles	f0b95955a0	Normalise syntax with Rubocop Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	31d1d4b297	Use 1.9+ Hash syntax Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	25b8157bd7	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.1 with the following command: transpec * 5 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 3 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } * 1 conversion from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago

1 2 3

106 Commits (2a8bb15d8092f6ccff117a36e0bbe234b458e33f)