openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	9256c9b46c	Allow to disable ldap groups sync with env flag (#9211 )	4 years ago
ulferts	ce5e06dde2	Fix/non matching pagination (#9202 ) * fix duplicates returned for wp list on multiple matching attachments/comments LEFT JOIN leads to potentially having multiple records returned if a search string is present in more than one attachment/comment. This is not a problem if we fetch work packages directly out of the query results but becomes problematic if only the id is fetched and then used to get the work packages by a subquery. * attachment filters no longer differentiate on tsv_where concatenation As EXISTS and NOT EXISTS is now used, the full string is always to be searched for so `and` concatenation is now always employed. * adapt spec Work packages that have no attachment at all are now also considered to match the filter if a "doesn`t contain" operator is used * less strict rspec rubocops for feature specs * cleanup code	4 years ago
ulferts	ff09b3b4cc	Bumped version to 11.2.4 [ci skip]	4 years ago
Oliver Günther	412302a093	Better database connection check Fixes the MySQL output and adds a rake task to properly check the connection This will e.g., output something like this ``` Database connection failed with error: FATAL: Datenbank »bla« existiert nicht ```	4 years ago
Oliver Günther	2b0bce6b5c	Improve message when nulldb is being used (#9156 )	4 years ago
Oliver Günther	c33e303bfe	Bumped version to 11.2.3 [ci skip]	4 years ago
Oliver Günther	2d902749d2	Load patches in initializer, not in individual patches	4 years ago
Oliver Günther	219df2130a	Bumped version to 11.2.2 [ci skip]	4 years ago
ulferts	7e68bd8ce1	avoid nil for wiki page slugs as they would be invalid (#9081 ) * avoid nil for wiki page slugs as they would be invalid Also explicitly enables having "!" for a wiki title but fails hard for all cases, which are not handled by default or custom. * move legacy specs over	4 years ago
Oliver Günther	aca807b45a	Explitly import patches module (#9080 )	4 years ago
Oliver Günther	6fde8cc32a	Add patch to I18n to replace empty strings with nil (#9068 ) * Add patch to I18n to replace empty strings with nil * Add common patch_gem_version helper	4 years ago
ulferts	c4c33e9a68	Bumped version to 11.2.1 [ci skip]	4 years ago
Oliver Günther	e9f1781d2b	Use contracted member services and show only manageable projects in user administration (#9076 ) * Reuse contracted services in memberships controller * Show only manageable projects * Show only manageable projects in select box * Reject empty values in role_ids * Add spec for when user has no manage_members permission * Also handle delete through service * Extend spec for when user has no manage_members permission * Extend Members SetAttributesSpec * Make manageable_Members an instance method and add spec * hide buttons if user is not allowed to use them * Rename manageable_projects to assignable_projects * Build a membership for the contract * Fix url for global_roles to work with update and create methods Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Markus Kahl	487811aa86	fix custom field validation on unpersisted record (#9050 ) * fix custom field validation on unpersisted record For unpersisted records, the customized value on a custom field is not yet set even though the custom field has been constructed using customized.custom_fields.build This needs to be countered by setting the customized explicitly. Without this, e.g. validations that depend on the customized fail * adapt spec to have the members created in setup Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Markus Kahl	eebf873eb1	disable direct uploads when use_iam_profile is true (#9049 )	4 years ago
ulferts	bc238d62be	fix custom field validation on unpersisted record (#9048 ) For unpersisted records, the customized value on a custom field is not yet set even though the custom field has been constructed using customized.custom_fields.build This needs to be countered by setting the customized explicitly. Without this, e.g. validations that depend on the customized fail	4 years ago
ulferts	9edf745085	Fix/group mention links (#9036 ) * turn group mentioning into link * add profile button to group edit page * Include built ckeditor Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	e1fbbf1fd4	Fix/deleted user representation (#9025 ) * fix displaying deleted user in representer For now, we simply use the user representer. In the long run, this might be changed to a specific representer * consolidate user polymorphy in api * use class comparison	4 years ago
Wieland Lindenthal	ffa5ac84a8	Allow deletion of placeholder users when permission of :manage_placeholder_user give (#9018 ) * Refactoring: Rename permission :add_user and :add_placholder_user to :manage_user and :manage_placeholder_user * Add deletion to :manage_placeholder_user permission label * WIP: Check :manage_placeholder_user permission before deletion Specs still missing * In controller rely on authorize_global for deleting placeholder users * Add deletion_info for placeholder users * Extend specs * Set placeholder users to locked when deleting * Review feedback Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	bbeae32698	[35508] Add global permission to manage placeholder users (#9000 ) * Add global permission to manage (but not delete) placeholders https://community.openproject.com/work_packages/35508 * Restore breadcrumbs for non-show routes * Remove permissions to memberships for add_placeholder_user permission * Allow non-admins with global permission to access membership * Remove permissions to memberships for add_placeholder_user permission * Rename shared_examples for admin contract validations Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	b8ba68421f	Bumped version to 11.1.5 [ci skip]	4 years ago
Oliver Günther	0c9fb9b1af	[36206] Make force_no_page for ldap configurable https://community.openproject.com/wp/36206	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	cb5fbb6a72	Use the configured variable for expiry https://github.com/opf/openproject/pull/8941	4 years ago
Oliver Günther	8df966abff	Use the configured variable for expiry (#8985 ) https://github.com/opf/openproject/pull/8941	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	2eb58888af	Bumped version to 11.1.4 [ci skip]	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973 ) * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
ulferts	5c112f39e1	fix role api permission checks The authorization on the individual get was handled to early (before instead of after_validation) so that the current user wasn`t set correctly yet. Additionally, there was not dedicated authorization check on the index get action	4 years ago
ulferts	40dda5833b	bump carrierwave Fixes https://nvd.nist.gov/vuln/detail/CVE-2021-21288 and https://nvd.nist.gov/vuln/detail/CVE-2021-21305	4 years ago
ulferts	97f8677cc7	allow filtering for groups and placeholders on user cfs Extends the ability of filtering work packages based on user typed work package custom fields by values of the classes: * Group * PlaceholderUser	4 years ago
Oliver Günther	a65992c354	Allow placeholder and group assignment to custom field (#8972 ) * Allow placeholder and group assignment to custom field * Review feedback	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	8942c488f0	Reuse the deprecation state for our own deprecator	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943 )	4 years ago
Markus Kahl	5f54e89aa9	.update_attributes! is now called .update!	4 years ago
Oliver Günther	4d17b19783	[36026] Ensure project filter only searches for active projects https://community.openproject.com/wp/36026	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Wieland Lindenthal	efbd3e9b41	Placeholder user backend (#8935 ) * Add missing copyright note to AnonymousUser [ci skip] * Addin PlaceholderUser model and its associations * Ensure PlaceholderUser do not "leak out" uncontrolled * Extract Associations for User and PlaceholderUser. - remove obsolete #assigned_issues - remove obsoete #:responsible_for_issues - add specs and factory for PlaceholderUser Adding specs to PlaceholderModel * Migration: enforce uniqueness of lastname for Group and PlaceholderUser * Remove obsolete callback `after_add` on groups association. The association of principals and groups still had a callback `after_add` that called a method `user_added` on the group. That method was not defined anymore as it was removed in commit `d93ff52a27`. * Move validation for #groupname to the right spec. * Cleanup placeholder and group specs * Remove Setting `workpackage_group_assignment` * Refactoring: Extract assignable scope from Project to Member * Refactor: Add Member scope not_locked. * deprecate hacky scope * remove wp_group_assignment specific test case Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Markus Kahl	af48244ffd	make download URL expiry configurable, use safer default	4 years ago
ulferts	5f0d4df485	Bumped version to 11.1.3 [ci skip]	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	07186be404	treat dalli_store to say :mem_cache_store	4 years ago
ulferts	5a3439cf13	rails uses dalli by default on mem_cache_store configuration now Also see https://guides.rubyonrails.org/caching_with_rails.html#activesupport-cache-memcachestore Fixed deprecation: DEPRECATION: :dalli_store will be removed in Dalli 3.0. Please use Rails official :mem_cache_store instead.	4 years ago
ulferts	7d20d8e5d2	do not fail on edge case of rendering	4 years ago
Markus Kahl	1c9da07a42	Bumped version to 11.1.2 [ci skip]	4 years ago
ulferts	38b783879a	use new method to get erroring attributes	4 years ago
ulferts	9df4ede3cc	adapt interface of mailer #perform to adhere to rails 6.2	4 years ago
ulferts	3094329287	explicitly allow polymorphic attributes	4 years ago
ulferts	b52b0d87ac	prevent yarn from interfering	4 years ago

1 2 3 4 5 ...

5611 Commits (2bd3d3e6b96a9836918fc216e015ed797cafaa1f)