3833 Commits (2be6ca186dc2745e891d02533ad183c877339baa)

Author	SHA1	Message	Date
ulferts	61e496ab97	annotate secure custom field ordering	5 years ago
ulferts	dc5a927d2c	move visibility check into project query ... This is more secure as it then cannot be forgotten. The visiblity check is added as a subquery to avoid the introduced DISTINCT interfering with SELECT	5 years ago
Yegor Tovstik	bb4a7bdfb4	CI fixes	5 years ago
Yegor Tovstik	ee2762e8ef	Send email on watcher being removed	5 years ago
ulferts	c2311df6f5	avoid unsafe sql warning	5 years ago
ulferts	8370c3099e	avoid n+1 queries on query requests by caching	5 years ago
ulferts	6c4e572f4e	consolidate allowed_* logic in the wp contract	5 years ago
ulferts	587e61c647	nil non provided parameters on put	5 years ago
ulferts	bc682f6b01	bail on inexistent related resource ... * status * type * assignee * priority	5 years ago
Oliver Günther	70bc14625d	Fix unwatch_from_permission_change when project nil ... https://sentry.openproject.com/share/issue/a58124f215d04e139b4a4336e6fa3a16/	5 years ago
Henriette Dinger	c3f9f1c7c3	Add DB field and checkbox for long text field CFs to save text orientation	5 years ago
Oliver Günther	a6a4031aa2	[31667] Fix ambiguous reference to project_id when group/sort ... Properly reference project_id to avoid ambiguous references to project_id when grouping by project_id and sorting by priority https://community.openproject.com/wp/31667	5 years ago
Markus Kahl	cddd45c8f5	I'm sick of looking up magic numbers	5 years ago
Markus Kahl	a311fe1b7b	skip builtin users in all counts (since anon and system are now active too, and deleted is blocked)	5 years ago
ulferts	611462b03c	memoize anonymous in request store	5 years ago
Markus Kahl	9922cc1fe4	made deleted user locked; exclude builtin users from active_or_registered ... Because active_or_registered are users which are meant to be worked with in the system. We may want to rename this to something else.	5 years ago
Markus Kahl	ddb40187ba	added regression spec for active users and fixed anonymous user's status	5 years ago
Markus Kahl	80bb46d47b	call protected method if defined	5 years ago
Oliver Günther	4944f02e2d	Add time entry webhook	5 years ago
Oliver Günther	51e8387e78	Remove builtin status ... [ci skip]	5 years ago
Oliver Günther	56a75602a6	[31609] Make system user active	5 years ago
ulferts	00a31728fc	increase strictness on regexp for default orders ... Otherwise partial matches would also count e.g. is_public matches as public is a substring.	5 years ago
ulferts	c96c5b89d5	only require copy_project permission to show button	5 years ago
ulferts	a8bc7b6c18	move @is_leaf resetting to different module	5 years ago
ulferts	b9b72f7204	linting	5 years ago
ulferts	9b9ee1349a	memoize leaf? method	5 years ago
ulferts	5869966f12	relay available_custom_fields call to cacheable class method ... That way, we avoid n+1 queries for the available custom field especially in scenarios like schemas and api collections where a set of models is queried for their custom fields	5 years ago
ulferts	aa3698d061	fix summing custom fields on wp table ... Before the fix, string values where returned and then the `+` method was called which lead to the strings being concatenated. A subsequent call of `integer?` failed. The fix performs the aggregation in the database which is not only correct then but can also be carried out considerably faster. The drawback is, that the casting breaks the abstraction introduced by the cf strategies	5 years ago
ulferts	4eab6effe1	merge changed_by_system into contract options	5 years ago
ulferts	3dabb46dd9	allow copying projects without parent project reference	5 years ago
ulferts	d37bdb71f0	extract methods	5 years ago
ulferts	f6226524dd	extract shared code into module	5 years ago
ulferts	75d34621fb	adapt project order to altered db column name	5 years ago
ulferts	924a3dfb04	adapt project order to altered db column name	5 years ago
Oliver Günther	a7ed2e9da0	Rewrite jobs to use ActiveJob syntax	5 years ago
Oliver Günther	3aa3dea512	Allow `deliver_later` using a custom ApplicationJob ... We're getting more and more reports on synchronous Timeouts and SMTP errors causing internal errors for users when trying to send mail in the request of the browser. With rails 5.2, we can assign a custom job that handles the `deliver_later` delayed sending. We can hook this into the ApplicationJob with delayed_job. Since rails now also has GlobalID serialization of ActiveRecord, we don't even need to do the serialization ourselves!	5 years ago
Oliver Günther	68d38fe2d5	[31500] Output correctly translated errors in mail handler ... https://community.openproject.com/wp/31500	5 years ago
ulferts	60b4b47c75	ensure journal notifications value is reset ... Before, an execption raised within the block would lead to the value not being reset. This happens e.g. when a transaction is canceled. This caused spec failures to occur from time to time e.g. rspec ./spec/models/work_package/openproject_notifications_spec.rb[1:1:1:1] ./spec/requests/api/v3/membership_resources_spec.rb[1:2:3:1] --seed 92792 but might also have unwanted side effects in production	5 years ago
Markus Kahl	bfe1e2003f	make external avatar URLs valid for 24h	5 years ago
Wieland Lindenthal	259950ec24	Add sorting for project status to project list and ... change project status filter operator logic to be consistent with other filters	5 years ago
ulferts	8d35a9b5f0	rely on api for configuration instead of gon ... Replaces all configuration fields currently supported by the api to be fetched from the api instead of from gon. Reduces the information passed to gon. Only the date/time format fields are left for gon to pass as those are not yet available via the api. Adding the fields should be easy.	5 years ago
Wieland Lindenthal	636ec8a5f3	Adding specs for project list's project status filter.	5 years ago
Wieland Lindenthal	1af4b9abe5	Add status filter to project list ... Extending the base filter to allow for left outer joins.	5 years ago
Oliver Günther	d4644c7c30	[31260] Correctly remove group key from attribute group ... The attribute group key is used in the frontend to detect whether the group is treated as an internal symbol (translation key). When renaming the group, the key is removed in the frontend, but always returned again by the backend. When saving that form again (e.g., rename another group), it is treated as internal again with a wrong key, resulting in the `no key` error. This error is removed by stripping the key field from JSON. Additionally, not found keys are being returned as is, ensuring groups are now named correctly even if they were erroneous before https://community.openproject.com/wp/31260	5 years ago
ulferts	c47a8bb5b0	fix group_by associated resource if only a nil group exists	5 years ago
ulferts	e7e4cbf961	replace mail legacy spec	5 years ago
ulferts	9bf1ccb13a	fix project acts_as_event url	5 years ago
Oliver Günther	ca97e60e0f	Revert "Merge remote-tracking branch 'origin/fix/remove_dependency_from_gon' into dev" ... This reverts commit ed8082ecfd, reversing changes made to f47a75d153.	5 years ago
ulferts	f7df4b222a	rely on api for configuration instead of gon ... Replaces all configuration fields currently supported by the api to be fetched from the api instead of from gon. Reduces the information passed to gon. Only the date/time format fields are left for gon to pass as those are not yet available via the api. Adding the fields should be easy.	5 years ago
ulferts	83c3b281b9	ensure scope used for user list in admin does not return system user	5 years ago