202 Commits (2e51905b8878ac927e848f735c0dc8cd94dce7a4)

Author	SHA1	Message	Date
kgalli	7f078624da	Replacement of RbServerVariablesController show ... Move of all relevant parts into shared view. Rendering of this view inline. Inline JavaScript might not be the best solution but seems more suitable as having an extra controller for that. The whole CSRF problem is also fixed by doing so.	9 years ago
Alexander Bach	9fc6ab537e	Add routing specs for modified route	9 years ago
Stefan Botzenhart	7e74650e02	Fix rubocop concerns	9 years ago
Stefan Botzenhart	406d365546	Add routing specs for settings	9 years ago
Oliver Günther	caf5e4a706	Formatting and clean up	9 years ago
Oliver Günther	0284d11f21	Corrections from review ... - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Alex Coles	a66f166498	Normalise syntax with Rubocop ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	22502bb008	Use 1.9+ Hash syntax ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ccb4268793	Normalise syntax with Rubocop ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	16fb352d8d	Use 1.9+ Hash syntax ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e480aae38d	Split CostTypesController#toggle_delete method ... Split into separate #destroy, #restore methods. * Add skeleton CostTypesController spec. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ac8fa05e30	Fix routing to MyController#reset_(api|rss)_key ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	18835799dd	Make ProjectsController#types use PATCH ... * make routing less convoluted: switch to a regular member route. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ae97716087	Make MyController#account use PATCH ... Now routes form helper-generated request correctly. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e4d1f7f7d7	Make WikiController#update_parent_page use PATCH ... Now routes form helper-generated request correctly. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	124e905c58	Convert specs to RSpec 3.2.0 syntax with Transpec ... This conversion is done by Transpec 3.1.0 with the following command: transpec -sf * 11 conversions from: it { should ... } to: it { is_expected.to ... } * 11 conversions from: obj.should to: expect(obj).to * 9 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: obj.unstub(:message) to: allow(obj).to receive(:message).and_call_original For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Alex Coles	f0b95955a0	Normalise syntax with Rubocop ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	31d1d4b297	Use 1.9+ Hash syntax ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	4534d704f8	Update routing specs to account for query params ... Appears to relate to: https://github.com/rspec/rspec-rails/issues/712 https://github.com/rails/rails/issues/2781 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	01d2569225	allows version selection for global filtering	10 years ago
Hagen Schink	28f89f9449	Add specs	10 years ago
Jens Ulferts	7ea3920fbe	responds with 410 to requests to api v1	10 years ago
Alex Coles	7bf86f2339	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some model' { } to: describe 'some model', :type => :model { } * 1 conversion from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Alex Coles	2d4e737f84	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 1.12.0 with the following command: transpec * 28 conversions from: obj.should to: expect(obj).to * 9 conversions from: =~ [1, 2] to: match_array([1, 2]) * 3 conversions from: == expected to: eq(expected) * 2 conversions from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: =~ /pattern/ to: match(/pattern/) * 1 conversion from: obj.should_not to: expect(obj).not_to * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message)	10 years ago
Alex Coles	879fcd49f6	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.6 with the following command: transpec -f * 66 conversions from: it { should ... } to: it { is_expected.to ... } * 53 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 20 conversions from: == expected to: eq(expected) * 19 conversions from: obj.should to: expect(obj).to * 7 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 7 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 7 conversions from: its(:attr) { } to: describe '#attr' do subject { super().attr }; it { } end * 5 conversions from: obj.should_not to: expect(obj).not_to * 4 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 3 conversions from: be_true to: be_truthy * 2 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 2 conversions from: its([:key]) { } to: describe '[:key]' do subject { super()[:key] }; it { } end * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: be_false to: be_falsey * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 1 conversion from: it { should_not ... } to: it { is_expected.not_to ... } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Jens Ulferts	3dfdae1cf9	moving request specs to proper directory, really	10 years ago
Jens Ulferts	6d162fd6ed	moves routing specs to proper directory	10 years ago
Jens Ulferts	b612fc3e0c	adds available_statuses to work_package resource	10 years ago
Michael Frister	25acfbe130	Add routes for /workflows{/edit,/copy}	11 years ago
Michael Frister	df1e87befa	Add route for /work_packages/quoted/:id	11 years ago
Michael Frister	edfff0151b	Add route for /types/move/:id POST	11 years ago
Michael Frister	24fbc557f3	Fix statuses#update_work_package_done_ratio routing spec	11 years ago
Michael Frister	fbbc4f2bea	Add /settings{,/edit,/plugin/:plugin_id} routes	11 years ago
Michael Frister	5e4a44d17c	Add route for /roles/new (not sure we need this route) ... The proper route here is /admin/roles/new, but at least one cuke uses /roles/new and we don't want to break it when removing the default route.	11 years ago
Michael Frister	02a88ad2b7	Add route for /projects/types/:project_id	11 years ago
Michael Frister	92573190dc	Add routes for /my/{add_block,remove_block,page_layout}	11 years ago
Michael Frister	060d2be9a8	Add route for /account/register GET & POST	11 years ago
Michael Frister	2ea6e3868f	Add route for /account/lost_password POST	11 years ago
Michael Frister	4a4e0678c8	Add route for /admin	11 years ago
Till Breuer	2a115caf6d	Add constraints to catch-all routes to fix conflicts	11 years ago
Till Breuer	7a8bdc86c9	Add route specs for catch-all routes for work package tabs	11 years ago
Alex Coles	25b8157bd7	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 5 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 3 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } * 1 conversion from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	714966de5c	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 13 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 4 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 2 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	82489fc5eb	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 14 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 11 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 4 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 2 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago