openproject

Commit Graph

Author	SHA1	Message	Date
Jens Ulferts	8a08856748	replace string object by custom option for list custom fields	8 years ago
Oliver Günther	1cfa120192	[19714] Make priority part of form configuration This allows users to completely disable the priority, if they wish. As it will always receive a default value, it is internally still a required field.	8 years ago
Oliver Günther	3a539b6bdc	Fix specs	8 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Jens Ulferts	c4bef2247d	adding filter instance schemas	8 years ago
Jens Ulferts	a022169f23	refactor for linting	8 years ago
Jens Ulferts	74770c6a63	adding query schema - global query	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	455955fc32	use equal method of embedded work package	8 years ago
Oliver Günther	ff8c85c478	[24258] Reuse existing schema after updating work package When a work package is updated after a successful PATCH, its schema is being reset to the linked value (and thus, `$loaded == false`). Since this controls type attribute visibility, this always leads to a small period of time where the schema is being retrieved from cache and causes a visible reloading of an attribute section. Here, again, the correct fix is to AVOID loading schemas as links, but rather as a separate state where the referenced schema will always reside unless the switch was made to a new type.	8 years ago
Oliver Günther	550763ae46	Do not 'inherit' priority from children This removes updating of priority values from children to parent work packages.	8 years ago
Jens Ulferts	d18b028599	use assignable_custom_field_values for version as well	9 years ago
Jens Ulferts	5948249c77	no longer show available values for a typed schema Before, the available values where always embedded into every schema. Because a deep copy is performed in the front end, this would downgrade the performance of the wp list in cases where a schema has a list cf with a lot of available values	9 years ago
Oliver Günther	6204762234	Add the current locale to the schema cache key (#4526 )	9 years ago
ulferts	2c47657de7	unified date field for milestone work packages (#4437 ) Work packages having a type that is a milestone receive a 'date' attribute in their API resource. Other work packages still have the 'startDate'/'dueDate' attributes. The schema behaves analogous so that such a change is visible to a client. In the cient we can now remove some of the custom behaviour for the date field. The code removal is limited to the new inplace edit implementation as the old implementation can hopefully be removed fully in the near future.	9 years ago
Oliver Günther	14c858a6c3	Remove required state of description	9 years ago
ulferts	4e6d880906	Fix/representer cache key (#4385 ) Moves the calculation for whether the WP schema representer has to be rerendered to the representer itself in the form of the cache_key method. This reduces coupling as the cache_key calculation is based on information the representer already has and the controller now no longer needs to know that information. It additionally uses the same calculation for the E-Tag to reduce duplication. In order to allow plugins to add to that cache_key, the acts_as_op_engine module is extended.	9 years ago
Markus Kahl	50e40f324a	wp form config polish (#4364 ) * allow hiding fields with defaults; consider name_source * sort types by name; move projects config to bottom * updated translations (default => active) * no extra visibility behaviour for new WPs * allow hiding even type; always show details header though otherwise the 'show all attributes' button may vanish * updated specs to include new info	9 years ago
Oliver Günther	29d69a3fc5	Introduce header and Rails caching for schemas This commit introduces cached project-scoped work packages schema. Their caches are expired on a key based on - the Project ID - the Type ID - the allowed custom fields for the given project This commit only caches schema, not form endpoints.	9 years ago
Markus Kahl	db29aead44	updated specs to work with new behaviour	9 years ago
Jens Ulferts	ff3d42fa33	add a project independent endpoint to create work packages Includes the auxillary end points: * form * schema * available_projects	9 years ago
Jens Ulferts	5a977c5594	add resource for querying the list of allowed projects	9 years ago
Jens Ulferts	0123e70316	adapt specs to altered implementation	9 years ago
Jens Ulferts	09e5815a74	add sumsSchema to api	9 years ago
Jens Ulferts	fc49e2a7b7	use linked parent resource instead of parentId The parentId field should be removed. But we shouldn't do it in a minor version.	9 years ago
Jens Ulferts	966d749e45	add parentId field to schema This is somewhat debateable. Having a parentId field is wrong in itself. It should be a linked resource. But as the field is also present in the resource, it also needs to be part of the schema for consistency sake.	9 years ago
Jens Ulferts	e2f8db9497	eager load colors together with the type	9 years ago
Jens Ulferts	8284933a5a	mark spentTime and percentDone as optional	9 years ago
Jens Ulferts	27e2cce32b	add priority to list of attributes inherited from children	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	d8ec635e9e	simplify interface for assignable values - one method to rule them all - eases overriding -> does not require to define method for new types on base class - allows to infer values_callback from property name (schema representer)	9 years ago
Jan Sandbrink	bfcc769cfd	split implementations for work package schema - was already quite case-ish, depending on its creation via WP or via project + type - I plan on adding a third case, which would not improve the situation for a single class	9 years ago
Jan Sandbrink	aa5155c8b7	fix specs - also extend WP schema specs	9 years ago
Alex Coles	0436446257	Revert "DRY WorkPackageSchema#available_custom_fields spec" This reverts commit `8e47f600b0`.	9 years ago
Alex Coles	8e47f600b0	DRY WorkPackageSchema#available_custom_fields spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	837265c257	Fix API v3 WorkPackageSchema for AR::Relation Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	bda0a30b70	only query the status, not the whole WP	10 years ago
Alexander Bach	4399787256	Corrected preparations required by spec Some tiny style improvement	10 years ago
Alexander Bach	1cc5c212ff	Fixed utility method	10 years ago
Jan Sandbrink	467fc9dba6	make WP schema resilient to invalid work packages	10 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	e6370cc0a1	Added specs for estimated hours and percentage done	10 years ago
Jan Sandbrink	857bcf4636	some refactoring around the WP schema - schema does not decide anymore whether to include allowed values (solely decided by "form_embedded" of representer) - schema will answer as many "assignable_*" methods as possible - work package does not need those methods anymore (except few cases)	10 years ago
Alex Coles	c13b9a59ff	Convert specs to RSpec 3.2.0 syntax with Transpec This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 11 conversions from: it { should ... } to: it { is_expected.to ... } * 3 conversions from: be_true to: be_truthy * 1 conversion from: be_false to: be_falsey * 1 conversion from: failure_message_for_should { } to: failure_message { } * 1 conversion from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Jan Sandbrink	0394bc7daa	show allowed statuses correctly during type change	10 years ago
Jan Sandbrink	53909cbb61	indicate type as editable in schema	10 years ago
Jan Sandbrink	847242ea1f	more specs for WP schema	10 years ago
Jan Sandbrink	b2f725b43a	add specs for WP schema methods passing to WP	10 years ago
Jan Sandbrink	e8b461f23b	more elegant style add spec stub for work package schema	10 years ago

50 Commits (2e93fa2df4c279fd02e99759ec931132b424f69a)