openproject

Commit Graph

Author	SHA1	Message	Date
Jens Ulferts	f3bfe9f287	Revert "remove unused columns parameter on v3 query get" This reverts commit `b8d11aea96`.	8 years ago
Roman Roelofsen	616ccb05a8	Timeline relations bug relations folding (#5687 ) * Fixed some tslint warnings * Correctly display relations when parent rows are folded * Removed console.error statements [ci skip] * without comment.... [ci skip]	8 years ago
ulferts	c70aa76ea0	mimic AR join alias calculation for query (#5682 ) * mimic AR join alias calculation for query * remove unused columns parameter on v3 query get [ci skip]	8 years ago
Oliver Günther	50dbf354f7	[25495] Cancel clicks to hrefs with nothing but a hash (#5685 ) Clicking on an unhandled link with `href="#"`, you end up on the homepage. This was observed in 25495 while using the datepicker due to the following problems: 1. The datepicker library we use adds links with a hash href @href="#"@ to each date field in the datepicker 2. The datepicker adds an event that cancels the default handling of these fields 3. When quickly updating the page, the datepicker instance events are unregistered before its actually fully closed 4. The href="#" event bubbles up, and angular handles it. Due to the way our base url works, it routes the URL to @<root>/#@ which results in your going to the homepage. [ci skip]	8 years ago
Wieland Lindenthal	5fbf569c4e	Fix/layout fine tuning fixes (#5683 ) * Fix for reclamation in #25556. Pin icon gets frontend side drawn and was missed. * sync content-icon-color to content-link-color * In toolbar buttons with text label the whitespace left and right of an icon should be equal * use same color logic for drop downs as for the main menu * improve contrasts for hover and selected menu items * open dropdown labels in top menu shall be treated the same as in hover state. * selected/hovered items in project selector shall not be bold. [ci skip]	8 years ago
Roman Roelofsen	7a7e02c7d1	Only display 'follows' and 'precedes' relations	8 years ago
Oliver Günther	3d68f36f56	Fix/relations drawing (#5663 ) * improved drawing of timeline relation lines * Improved relations data flow * Timeline relations: Load relations once the timeline becomes visible * - Fixed SwitchState failing test - Version bump ReactiveStates - cleanup [ci skip]	8 years ago
Oliver Günther	6e05f96cb5	[25554] Let long-text attributes span both columns (#5658 ) * [25554] Let long-text attributes span both columns https://community.openproject.com/work_packages/25554 * Attempt to reconnect on pullpreview [ci skip]	8 years ago
Wieland Lindenthal	2ea324e5b5	change toolbar button height (#5664 ) https://community.openproject.com/projects/openproject/work_packages/255 11/activity [ci skip]	8 years ago
ulferts	02e418374f	only nest error message on invalid query (#5647 ) [ci skip]	8 years ago
Oliver Günther	6bb684a531	[25534] Fix needless escaping with jquery-ui (#5649 ) The `_.escape` was used for the typehead that was since replaced by ui-autocompleter, which uses a text node to insert the label: https://github.com/jquery/jquery-ui/blob/master/ui/widgets/autocomplete.js#L568 Thus the escape is no longer necessary. https://community.openproject.com/projects/openproject/work_packages/25534/activity?query_id=930 [ci skip]	8 years ago
ulferts	16f0cace89	Fix/wp copy with cf (#5638 ) * fix copying cf values on wp copy * use angular copy form if only one wp copied [ci skip]	8 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637 ) * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	8 years ago
ulferts	df99cf15c3	fix wp subject display in ff (#5640 ) * fix wp subject display in ff The subject used to be hidden because the width calculation was off. Instead of tempering with the width calculcation, I decided to use float instead so that we end up with fewer objects having their width calculated in js * fix being able to double click on hierarchy area * add comments on pointer-events [ci skip]	8 years ago
ulferts	0ab4c9aaec	set float values to null if empty string is passed (#5633 ) Used to be set to undefined which caused float cfs not being able to be set to blank [ci skip]	8 years ago
Wieland Lindenthal	84c3426934	Fix Nato positioning for Win Chrome	8 years ago
ulferts	08e49612e6	Fix/forums pagination (#5623 ) * restructure table pagination to use a controller * split up pagination directive There now is the table-pagination directive which is generic, taking input to communicate with its caller. This is used by the forum. The wp-table-directive is specific for the wp table and relies observers. [ci skip]	8 years ago
Oliver Günther	58c4facd82	[25433] Let the dropdown controller reposition the dropdown on changes (#5620 ) [ci skip]	8 years ago
Wieland Lindenthal	94a95bfd0c	Align and style back button like other toolbar buttons	8 years ago
Wieland Lindenthal	6f9991e35c	Remove boilerplate of back button and aligning it.	8 years ago
Wieland Lindenthal	0b91bab4ec	Fix bug #25461 . On iOS safari is not enabled. (#5621 ) [ci skip]	8 years ago
ulferts	3e6fdc8639	Fix/loading indicator on query change (#5617 ) * show loading indicator on query switch * prevent duplicate loading on query change We might want to look into moving the query checksum mgmt to the service layer to avoid scattering around calls to the checksum service but I refrain from doing that in a patch release * code prettification [ci skip]	8 years ago
Jens Ulferts	ff1a855ec7	handle non existing properties on inline create default values OP has filters defined for non work package properties. E.g. there is no subprojectId property on the work package resource. We need to ignore those filters when determining the default value on inline created work packages [ci skip]	8 years ago
Oliver Günther	ac46271c59	[25430] Set the width of the remaining space next to hierarchy indicator (#5613 ) This allows inline edit fields to retain the whole remaining size next to the hierarchy indicator. https://community.openproject.com/projects/openproject/work_packages/25430/activity?query_id=916 [ci skip]	8 years ago
Oliver Günther	bbda2c572d	Set the current hierarchy mode correctly in HierarchyTransformer (#5612 ) [ci skip]	8 years ago
Oliver Günther	5b5326db4c	[25438] Fix only saving changed column positions (#5608 ) When changing only the positions of the default query columns, the query incorrectly checked only for the permutation of the default columns, not the actual order. Thus the columns were not actually saved in the query. Additionally, the `observeUntilChanged` incorrectly reflects previous values which causes the movement of a column twice to only result in a move by one position. As this was already suggested to remove in https://github.com/opf/openproject/pull/5597, let's resolve this together in this PR. [ci skip]	8 years ago
Oliver Günther	94234bd5ee	[25432] Correctly transmit hasDefault to frontend (#5603 ) The default value for CFs is '', which is obviously not nil despite not being a default, however the frontend only _always_ shows the attribute when it is required and has no default. This PR also adds a 'always visible' flag to the form configuration when the CF is set required. [ci skip]	8 years ago
ulferts	483934e91b	refresh wp list after saving in full screen (#5600 ) [ci skip]	8 years ago
Oliver Günther	3c283ea512	Render table sums row in separate directive (#5595 ) * Render table sums row in separate directive * Fix JS error on setSelection It is not supported for [type=number] input fields. [ci skip]	8 years ago
Henriette Dinger	cb9ad7ba17	[25356] Icons in toolbar not aligned correctly (#5568 ) * Icon alignment in toolbar * Styling: newline after comma in CCS selector. No functional change. Just my personal preference. * Extra class for toolbar buttons that are icons only to make them a square. * Improve documentation for generating icon font [ci skip]	8 years ago
ulferts	96b20eae2a	fix old timeline legend width calculation (#5594 ) The calculation of an element's width was assigned to the wrong variable in #e04cc7e5794273103306a19ebbece0feb9cc192d [ci skip]	8 years ago
Oliver Günther	e877713b0a	[25404] Show timeline context items only when visible (#5590 ) Fixes a check for the timelineVisible state. [ci skip]	8 years ago
ulferts	1afcc57bd1	Fix/autocomplete multiple times (#5588 ) * $compile after changing dom via ajax response This enables the autocompleter implemented via an angular directive to work after a user has been added/removed from the group * reduce debounce on autocompleter [ci skip]	8 years ago
Oliver Günther	ebdad784cd	[25415] Add ancestor groups always when inserting extra rows (#5587 ) The hierarchy render pass uses ancestor groups to identify which rows belong to a certain hierarchy group for simple selector-based hiding/expanding of nested groups. For extra added rows, these groups were only added when the ancestor was not yet added to the list, causing them to not respond to collapsing the ancestor group. [ci skip]	8 years ago
Oliver Günther	bf9373120b	[25416] Refresh query on removed query_props with ID set When you're navigating to a query and override a filter, then move back to the query, the URL is changed, however the query is not being refreshed. This is due to the checksum being required to be non-null, even though it can possibly become null in the above case.	8 years ago
Oliver Günther	e20ef8fc71	[25411] Never render extra parents in timeline (#5584 ) Currently, hierarchy mode does NOT load extra parents that are not part of the results table (marked grey). As they are not loaded, the timeline doesn't have any information to draw them with. However, IF the workPackages state _had_ the value of the work package (e.g., because it's open in split view or it is part of a relation), it would still be rendered. This PR avoids rendering these rows at all times. [ci skip]	8 years ago
ulferts	d9aab230fd	Fix/empty filters on export (#5579 ) * place empty filter set in representation url This will allow the empty filter set to override the default filter (status - open) * remove now unused method * persist having no filter in the url params Otherwise, the default filter (status - open) will reappear on reload [ci skip]	8 years ago
Roman Roelofsen	d3606545f1	Improve drawing/positioning of milestones and relation lines (#5583 ) * Improve drawing/positioning of milestones and relation lines * Rebase on op/dev [ci skip]	8 years ago
Oliver Günther	14839a92a9	Remove forkjoin to avoid asynchronous pulling of rows and other states (#5582 ) [ci skip]	8 years ago
Oliver Günther	c676d97881	Avoid undefined cell work packages Extra work package rows may result to valid rows in the timeline, but their associated work package is not loaded (hierarchy mode!).	8 years ago
Oliver Günther	bfba259846	Ignore an empty cell element [ci skip]	8 years ago
ulferts	cf78b9fd5a	Fix/roadmaps wp list links (#5577 ) * robustness on missing sort criteria * use v3 names in url Not strictly necessary as the api can also handle the AR identifiers * adapt specs [ci skip]	8 years ago
Oliver Günther	1163875917	[25383] Refactor wp-timeline cell to be rendered top-down (#5573 ) * [25383] Refactor wp-timeline cell to be rendered top-down Avoids creating timeline cells as part of the table rendering process, but rather lets the container maintain the reference to them to instrument drawing and updating single rows. This removes the necessity for the `unsubscribeTimelineCells` hook and with that fixes https://community.openproject.com/projects/openproject/work_packages/25383/activity?query_id=896 * Extract cells rendering in separate class * Add missing takeUntil [ci skip]	8 years ago
Oliver Günther	32381134f4	Fix relations removal in split screen and add test (#5578 ) [ci skip]	8 years ago
Oliver Günther	c96c6eb72b	[25400][25357][25399] Remove title from wp-display-formattable (#5575 ) Removes the title from formattible attributes. Fixes https://community.openproject.com/projects/openproject/work_packages/25399 https://community.openproject.com/projects/openproject/work_packages/25357 https://community.openproject.com/projects/openproject/work_packages/25400 [ci skip]	8 years ago
Jens Ulferts	10b01d994e	apply `ellipsis class` to query menu items	8 years ago
Oliver Günther	190e37e9d9	[25401] Restore details icon [ci skip]	8 years ago
Oliver Günther	160d8876c7	Add switch state in query state handling to clarify access to states (#5571 ) [ci skip]	8 years ago
Wieland Lindenthal	53ecfc19c8	Fix/25382/false duplicate error message (#5569 ) * fix false duplicate error * do not change keys of default groups unless name changed * groups that have the same key after transforming to lower case should be treated as duplicates. [ci skip]	8 years ago
Roman Roelofsen	d378cbe0a7	Removed debug console.log statements	8 years ago

1 2 3 4 5 ...

4094 Commits (2efedc2058257bbcfb4b9724130bcadaf053f5bc)