292 Commits (3045c18005b8720f3c9215ee6d06f47022a6e1a1)

Author	SHA1	Message	Date
Oliver Günther	3b0f83b292	[23643] Use wpNotificationsService to handle error response in relations (#4681) ... A removed method in ErrorResource caused removing children to fail when the resource was invalid. https://community.openproject.com/work_packages/23643/activity	8 years ago
Oliver Günther	ebae2da48f	[23592] Fix attachments in create mode (#4682) ... This fixes the attachments section (wpAttachments and wpAttachmentsFormattableField) for the create mode. https://community.openproject.com/work_packages/23592/activity fix default delayed attachments upload fix insertion and delayed upload via drag and drop show attachments section depending on the existance of pending attachments fix removal of pending attachments show uploaded attachments without hard-refresh... Supersedes https://github.com/opf/openproject/pull/4640 with using the cache service hook	8 years ago
ulferts	6a3496d26e	prevent editing a work package while saving takes place (#4658) ... Otherwise, especially in IE with their custom change handler for select boxes, it was possible to make a change, trigger saving and while saving takes place, change another attribute and change that. Only the first change would work while the second would fail because of optimistic locking.	8 years ago
Oliver Günther	8a8aac580f	Avoid posting an empty object to textile API (#4673)	8 years ago
ulferts	0ad9a3a2df	remove non performant copy as the values are not altered anyway (#4645)	8 years ago
Henriette Dinger	f99958aa68	Set focus after submit (#4550)	8 years ago
Oliver Günther	36a926e556	Avoid posting empty objects to preview ... https://community.openproject.com/work_packages/23584	8 years ago
Oliver Günther	667dcdde52	Add wpNotificationService helper method to handle error responses	8 years ago
Oliver Günther	ec1b97041b	Always save the WP when it is new ... Otherwise, copying work packages will break.	8 years ago
Oliver Günther	f705e4d9ac	Rewrite comment directive in TypeScript without inplace	8 years ago
Oliver Günther	ea6b930582	Show 'Open in full screen' notification only when not in fullscreen ... https://community.openproject.com/work_packages/23574/activity	8 years ago
ulferts	a25717ab83	Fix/move project empty options (#4610) ... * linting * show "Please select" when the current value is invalid It is considered invalid if the value is null and it is a required field or when the value is not within the list of allowed values * remove unused variable	8 years ago
ulferts	b664210d39	Fix/force datepicker open upon first focus (#4606) ... * remove unused variable * explicilty show the datepicker upon initialization This leads to the datepicker being opened when focusing for the first time. Without it, the datepicker is only shown on the wp create page after the second focus	8 years ago
Oliver Günther	62ca484428	Allow tab read-only display fields, but highlight them ... This styles the background of read-only values when focussing or hovering them. Also, all fields regain a tabindex value of 0 to make them reachable. https://community.openproject.com/work_packages/23546/activity	8 years ago
Alex Dik	ab807b8847	Stop exposing $route on HalLink's callable directly	9 years ago
Oliver Günther	0ed6bfeca6	Swap condition in WorkPackageResource#save ... Now values can be `null` and the check is no longer valid.	9 years ago
Oliver Günther	d07ec7a3eb	Rename wpNotificationsService	9 years ago
Alex Dik	f7a9f6e51f	Refactor wpEditForm controller	9 years ago
Alex Dik	b80d224f05	Refactor wpNotification service	9 years ago
Jens Ulferts	6f4e49333b	correctly hide datepicker upon selection	9 years ago
Jens Ulferts	bc02799de9	allow refocusing when field is errorenous	9 years ago
Jens Ulferts	bb109fcfc8	linting	9 years ago
Jens Ulferts	c5d4c132c0	less magic more datepicker	9 years ago
ulferts	d800fb25c8	don't submit an unchanged wp resource (#4575) ... Checks the wp's dirty flag before actually submitting the wp. Thereby, updateWorkPackage becomes a noop if a wp has no changes.	9 years ago
Oliver Günther	efdc044a29	Avoid wpEditMode in Create Service ... Inline creation doesn't use wpEditMode.	9 years ago
Alex Dik	7e8c9beea4	Add success state redirect after new WP is saved	9 years ago
Alex Dik	c7096bb220	Add subject field ... Add subject field	9 years ago
Alex Dik	58d5ee0072	Allow saving of the work package	9 years ago
ulferts	6ed3160937	do not focus an already active field (#4567) ... Otherwise, changes to a resource will lead to a reinitialization which will lead to a refocus	9 years ago
Oliver Günther	009fe4894c	Fix execution of cancelling edit-mode confirmation	9 years ago
Jens Ulferts	7cb1c0a122	i18n for internal error	9 years ago
Jens Ulferts	4b06a41ba3	provide api independent error message for date format errors	9 years ago
Jens Ulferts	4a1274d6a3	extract wp notifications into separate service	9 years ago
Jens Ulferts	124987499a	submit date on blur when in accessibility mode ... As the accessibility mode has no date picker, we can submit it right away	9 years ago
ulferts	344c0c92ab	Fix/activate inplace edit in ie (#4560) ... * no longer require an isolated scope for clickOnKeypress As that directive is so small and is oftentimes used on the root element of a directive, having an isolated scope limits the usage of directive * reapply click-on-keypress to trigger inplace edit Otherwise, the IE will not be able to trigger the element	9 years ago
Oliver Günther	74b52eaab8	[23300] Fix date fields not being updated (#4556) ... * Fix date fields not being updated For Milestone rows, start and due date are both mapped to `date` and thus collide with the wpEditForm#callbacks helper that propagate changes from the `wpCacheService` down to edit and display fields. This fails to update the last field since they registers callbacks based on their attribute name. This commit instead suggests to use the wpCacheService directly, since the scopedObservable will handle deregistration correctly on its own. * Remove no-longer-required wpEditForm	9 years ago
Jens Ulferts	ea745865ad	remove focusability/role on non editable elements	9 years ago
ulferts	1d99206232	Fix/accessible error messages (#4529) ... * add error messages to each field * move role=alert up so that success messages are also covered * remove focus code from notification-box directive The box does not need to be focused as it has the role=alert which will lead to it being read out. * remove specific focusing behaviour for accessibility mode The mode was introduced to present error messages to user requiring assistive technology e.g. screen readers. By setting role=alert on the error fields and additionally labeling the fields with the errors, this should no longer be necessary	9 years ago
ulferts	cbd33707b8	don't submit field if we already know it to be erroneous (#4525) ... Either because: * it is required and empty * it is erroneous and unchanged	9 years ago
Jens Ulferts	43a4ecce5d	remove wpEditField dependency from wpDisplayAttr	9 years ago
Jens Ulferts	48200d3a5c	don't submit field if we already know it to be erroneous ... Either because: * it is required and empty * it is erroneous and unchanged	9 years ago
ulferts	76e2a5e0ce	submit on user blur (#4513) ... Will also submit the work package when clicking somewhere else (blur).	9 years ago
ulferts	104f918796	provide role attribute so that ngAria does not set it to "button" (#4518)	9 years ago
ulferts	a97797b057	Fix/nullable date field (#4503) ... * allow setting date fields to null * move all transformers into dedicated folder	9 years ago
Jens Ulferts	3bfc489a8e	remove html-class setting already present in the template ... There is already an ng-class statement setting the desired class upon editability. As the wp-edit-field directive is applied via an attribute, the $element is the dom element the directive is an attribute of. That way, the -editable class is applied twice.	9 years ago
Alex Dik	e79ce2a28f	Refactor editActionsBar directive (#4490) ... * Refactor editActionsBar directive * Move editActionsBar directive files to another location * Make the editActionsBar directive more general * Refactor WP details controller test * Fix WP details controller test	9 years ago
Roman Roelofsen	ae6087e9f0	Removed timeout defer	9 years ago
Roman Roelofsen	57e98024bb	WIP reducing watcher count	9 years ago
Roman Roelofsen	210379367f	WIP reducing watcher count	9 years ago
Oliver Günther	67c1cc154c	Cherry pick @og refactoring	9 years ago