openproject

Commit Graph

Author	SHA1	Message	Date
Wieland Lindenthal	4e22681e78	User mentions feature (#5897 ) * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
Oliver Günther	92060508a9	Remove unused test helper	7 years ago
Oliver Günther	fdfb41b327	[26069] Allow passing of me-value link for principal filters again The 'me' value is currently automatically normalized to the current user, making it impossible to store queries that reference the current user whenever accessing the query as before.	7 years ago
Oliver Günther	cf55f61e73	Don't register textile formatters in initializer (#5903 ) When the autoloader reloads WikiFormatting, the values registered in the initializer are lost [ci skip]	7 years ago
Oliver Günther	75d2f010ba	[25108][26176] Assigned_to filter returns group values Since 7.0.0, the `assigned_to is <user>` filter also returns work packages assigned to a group that `<user>` belongs to. Since this is misleading and judged a bug by several customers, instead add a new filter that provides exactly this behavior, while using `assigned_to` only for the exact value specified there. https://community.openproject.com/wp/26176 https://community.openproject.com/wp/25108	7 years ago
Oliver Günther	ddcf35f3f7	Fix invalid value_objects being passed to representer There are queries that seem to pass values not available in APIv3 path helper to the instance representer. ``` Original error: #<NoMethodError: undefined method `anonymous_user' for API::V3::Utilities::PathHelper::ApiV3Path:Class Did you mean? anonymous?> Stacktrace: /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:82:in `block (2 levels) in <class:QueryFilterInstanceRepresenter>' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:80:in `block in <class:QueryFilterInstanceRepresenter>' ```	7 years ago
Oliver Günther	ed1a0c87de	[25999] Make timeline labels configurable https://community.openproject.com/wp/25999	7 years ago
Oliver Günther	e02a65e372	[26141] Use valid subset of query to save it (#5859 ) https://community.openproject.com/wp/26141 [ci skip]	7 years ago
Oliver Günther	f07ee8c2b5	Don't use return in block	7 years ago
Oliver Günther	47c5475e44	Require hashie [ci skip]	7 years ago
Oliver Günther	ece6fa5d23	[26128] Fix local jump error (#5856 ) [ci skip]	7 years ago
ulferts	9c8f7f3ca1	read operations for time_entries via api v3 (#5776 ) * read operations for time_entries via api v3 Introduces the endpoints: * GET /api/v3/time_entries * GET /api/v3/time_entries/:id * GET /api/v3/time_entries/activities/:id The index action for time entries can be queried by the following filters: * project_id * user_id * work_package_id The implementation is exposing the database structure mostly one to one with the exception of some renaming and the hiding of the activities' complexity, where only the activity used systemwide is referenced regardless of whether a project specific override exists or not. * allow custom values for time entries [ci skip]	7 years ago
ulferts	2f9d7f408a	Fix/wp table switch to milestone (#5825 ) * map date name in changeset * handle date switch in wp form * Don't stub_const for services that may exist before hand This will cause the const to be evaluated already, so that stub_const has no effect there. This is why this fails depending on the order on travis, but not locally/isolated. [ci skip]	7 years ago
ulferts	0c1c8d443a	don't use project as cache key if project is nil (#5806 ) [ci skip]	7 years ago
ulferts	61281b7f6a	explicitly set author to be nonwritable in wp schema (#5805 ) While the author is writable, one can set it to the current user. It should not be marked as writable as the backend makes that assignment already. But because of this behaviour we cannot rely on the default behaviour for determining whether a property is writable [ci skip]	7 years ago
Oliver Günther	ab9a9baee7	[26002] Add date as writable when type is milestone (#5804 ) https://community.openproject.com/wp/26002 [ci skip]	7 years ago
Oliver Günther	9937307c7c	[25968] Use OpenStruct instead non-required hashie (#5794 ) https://community.openproject.com/wp/25968 [ci skip]	7 years ago
Oliver Günther	162401d962	[25768] Parse/Output estimated hours with seconds precision Was truncated to minutes before. https://community.openproject.com/wp/25768	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732 ) * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
ulferts	4b7e3ff26d	Feature/limit attribute help text visibility (#5749 ) * code prettification * avoid help text for newly added cf requiring restart When using the class method statically, the values are determined upon reading the class. By that, a restart is required before newly added custom fields are added to the list and removed custom fields will still be listed * limit visibility of attribute help texts [ci skip]	7 years ago
Oliver Günther	ec6b856686	Add directive to show help text modal	7 years ago
Oliver Günther	57356059af	Create /help_texts endpoint	7 years ago
Oliver Günther	8956700408	[25374] Remove attribute visibility	7 years ago
ulferts	39bbf082bf	fix author filter for projectless users (#5718 ) As the principals returned by the principals API where limited to those that are members in projects the user can see, users not having any project would not be returned. This is intended in so far as to prevent getting all users easily. But the user herself should be visible in any case. [ci skip]	7 years ago
ulferts	7ad39ec35f	Fix/cache query representers (#5711 ) * cache various query representers json representation * sort by * columns * group by * filter instance schemas * fix custom option path [ci skip]	7 years ago
ulferts	fc139e55df	limit visibility of relations index (#5703 ) [ci skip]	7 years ago
ulferts	835c18f91e	render empty href on invalid list cf (#5688 ) [ci skip]	7 years ago
Oliver Günther	aa386f994d	[25606] Saving query with nil group_by does not apply it (#5684 ) This was caused by the groupBy deserialization only applying when it is non-nil [ci skip]	7 years ago
Jens Ulferts	5982ede894	adapt to altered representable interface	7 years ago
ulferts	65c7db3120	avoid side effects on calls to attribute_groups (#5677 ) Without the deep_dup, the call to attribute_groups used to alter the type's attribute_groups deeply nested attribute_groups property. As a result, the second call to attribute_groups would be different from the first one. This became most apparent when rending the schema for a couple of work packages all sharing the same type. As the type was reused to render the schema, but the project might have changed, only the first schema for the type was accurate, while subsequent schemas for that type lacked attributes [ci skip]	7 years ago
ulferts	9414241dfb	show error message if activity cannot be saved (#5678 ) [ci skip]	7 years ago
ulferts	5165906e11	fix saving boolean cf filters, use representer for filter parsing (#5660 ) * fix saving boolean cf filters, use representer for filter parsing * patch roar to allow linked_reseource definitions This enables us to get rid of dedicated representers for links sections when the representer is used for parsing [ci skip]	7 years ago
Oliver Günther	507c2d26ea	Remove fromType, toType	8 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637 ) * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	8 years ago
Oliver Günther	2c0ebf0a6e	Add relationType to relationOfType column So we can avoid matching the id/href in the frontend.	8 years ago
Oliver Günther	f3df45cef4	Extend backend relations API with WP type information This saves the doubled frontend request just to find out which types work packages of a specific relation have. Since the connection between work package types and relation types are very close, we should always send them.	8 years ago
ulferts	55695ed756	adds query columns by relation type (#5625 ) [ci skip]	8 years ago
ulferts	cea23ce333	Fix/sort version filter options (#5630 ) * have version filter options ordered by name * Fixes filter options on global queries (returned types instead of versions) * Adds the name order to be available generally * code prettification [ci skip]	8 years ago
ulferts	20dd8a6e0a	Feature/work package id filter (#5614 ) * add filter for work packages by id to query * hide the id filter in front end As we do not yet have satisfying means to display the filter values for selection, we hide the filter and use it internally only [ci skip]	8 years ago
ulferts	ace7098eb3	add relations columns to query (#5606 ) * add relations columns to query * refactory query columns * rename QueryColumn to QueryColumn::Property QueryColumn is now only an abstract supertype [ci skip]	8 years ago
Oliver Günther	6b372acae6	Implement timeline zoom level as query enum	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	94234bd5ee	[25432] Correctly transmit hasDefault to frontend (#5603 ) The default value for CFs is '', which is obviously not nil despite not being a default, however the frontend only _always_ shows the attribute when it is required and has no default. This PR also adds a 'always visible' flag to the form configuration when the CF is set required. [ci skip]	8 years ago
ulferts	d9aab230fd	Fix/empty filters on export (#5579 ) * place empty filter set in representation url This will allow the empty filter set to override the default filter (status - open) * remove now unused method * persist having no filter in the url params Otherwise, the default filter (status - open) will reappear on reload [ci skip]	8 years ago
ulferts	86c2f3d59d	Fix/increase query api robustness (#5574 ) * removes unavailable filters on valid_subset! * remove invalid columns on valid_subset! * cleanup query form and collection * code prettification * add status to spec in order to have valid queries [ci skip]	8 years ago
Oliver Günther	c89d2e6165	Enforce type for activity id Otherwise, anything is passed to `AggregatedJournal.with_nodes_id`.	8 years ago
ulferts	2a71172837	prepare the query before reading results (#5547 ) * prepare the query before reading results * use string for list cf filter value because all other list filter also use a string * handle invalid group, columns, sort on query read [ci skip]	8 years ago
ulferts	a4198c9722	add showHierarchies to query payload representer (#5551 ) [ci skip]	8 years ago
Oliver Günther	303109340d	[25339] Pass the context to format_text in formattable (#5541 ) [ci skip]	8 years ago
Oliver Günther	5d50acc50e	[25288] Re-add translations to default attribute groups (#5515 ) * [25288] Re-add translations to default attribute groups Uses symbols to mark internal attribute groups and translates them in the schema representer to the user's locale. * Extend form configuration front end for translated default groups * fixing specs * fix feature spec for attribute groups * Add symbol test to attribute groups [ci skip]	8 years ago

1 2 3 4 5 ...

1335 Commits (307c37f737ab4bd1fb4a9032142205425ab076e3)