3371 Commits (31943d5713cad71d4cbdc8c6013a61625be55499)

Author	SHA1	Message	Date
Markus Kahl	8309798598	removed obsolete invitations controller	9 years ago
Oliver Günther	a6b4372b09	Always preprocess URLs with CGI.unescape ... This forces redirect URLs to always pass through the escaping process, in order to process escaped paths (`/mysubdir/%2E%2E/secret/`).	9 years ago
Markus Kahl	9af0e26623	make user creation/invitation work with plugins ...	9 years ago
Jan Sandbrink	2fb41301de	Fix activation in case a non-existing token is passed ... looks like the original author intended to use the method I am using now and just forgot to update the call...	9 years ago
Oliver Günther	fcd450af3f	Fix redirect vulnerability ... `redirect_back_or_default` was vulnerable to some of the URLs found to be vulnerable in redmine, such as `@test.foo`. This commit extracts the whole functionality into a policy and alters the constraints with a path check to avoid these cases. Thanks to @marutosi for pointing this out. http://www.redmine.org/projects/redmine/repository/revisions/14560	9 years ago
Markus Kahl	92a3b89997	don't offer to invite who is already a member	9 years ago
Markus Kahl	a0be1030b7	show user name in deletion notices	9 years ago
Markus Kahl	42506dacf6	moved invitation email sub to initializer	9 years ago
Markus Kahl	0102f299e0	delete invited users when removed as member	9 years ago
Markus Kahl	3738329078	delete invited users when removed from project	9 years ago
Markus Kahl	3428181894	only admins may invite new users	9 years ago
Markus Kahl	871375bbc0	register: clear placeholder name(s); refactoring	9 years ago
Markus Kahl	5b41431400	don't invite members without given roll	9 years ago
Markus Kahl	47479ba28b	refactoring	9 years ago
Markus Kahl	ac8a096488	polish considering remarks through review and houndci	9 years ago
Markus Kahl	06f20c94b2	fixed self registration; manual activation of invited users	9 years ago
Markus Kahl	1319e1fe34	extracted member's roles feature spec from cuke ... fixed bug while at it (no error message when choosing no role)	9 years ago
Markus Kahl	5c3241ee50	fixed error messages feature (as feature spec) ... - dropped cuke - fixed a bug inviting Anonymous when no user selected - dropped obsolete test	9 years ago
Markus Kahl	f37520ad19	feature spec for user creation and activation	9 years ago
Markus Kahl	b7b613f86f	explain why auth source wasn't deleted...	9 years ago
Markus Kahl	b3176866f2	removed signup screen; show OmniAuth opts in register view	9 years ago
Markus Kahl	23ba7981bf	use project identifier in members path	9 years ago
Markus Kahl	bc563ea977	more helpful flash messages for project members view	9 years ago
Markus Kahl	738f385cb1	more polish	9 years ago
Markus Kahl	43e18dd00c	switch to user invitation by default ... this changes quite many flows. With this user self registration is a separate flow to what happens when an admin creates a user. Users created by admins are 'invited' instead of 'registered'.	9 years ago
Markus Kahl	2f5018c1d0	extract members tab; invite members via email	9 years ago
Markus Kahl	98ba7ce333	basic user invitation prototype	9 years ago
Alex Coles	db078e0964	Fix for ActiveRecord::Base.reflections API change ... `WorkPackage.reflections.keys` now returns Strings rather than symbols. This solution is not ideal: calling `to_sym` is often a code smell. It might be acceptable to pass through Strings to `includes`, but this warrants further discussion. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	fecd3b3b3e	Simple API for managing the homescreen content ... This commit alleviates the homescreen management from both core and plugins, in order to simply add and remove blocks. Also contains refactoring from review * Consistent block and variable usage * Removed unused labels * Avoid word breaks in multiline enumerations and remove margin from enumerations	9 years ago
Oliver Günther	15273724c3	Homescreen functionality ... This commit adds the homescreen functionality to OpenProject, replacing the default welcome screen. This adds support for: * Blocks of content for various privilege levels (latest projects, users, news, etc.) * Links to common functionality (administration, community) Relevant work package: https://community.openproject.org/work_packages/19722	9 years ago
Oliver Günther	bef80793a0	Small visual corrections for checkout ... This commit provides: * An integrated annotation warning display, when the entry could not be annotated (most often due to it being binary). * Hide current rev_id for subversion when no branch/revision is given.	9 years ago
Alexander Bach	717e514953	Fix routing on error handling of copy project	9 years ago
Jan Sandbrink	a2c5bdf369	Avoid mutator method entirely	9 years ago
Jan Sandbrink	6ecbb25fc2	Fix reversed comments display on WP legacy view	9 years ago
Alex Coles	07551ae585	Switch to new AR API for boolean typecasting ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Stefan Botzenhart	868d764a97	Use activejob deliver_now method (removes deprecation warning)	9 years ago
Oliver Günther	1481afb666	Corrections from review	9 years ago
Jens Ulferts	d3bc58b955	force id value in experimental API ... The id information needs to be returned in the api response so that links still work. The frontend will filter it out anyway	9 years ago
Oliver Günther	980072f7d9	Remove last activity section from admin/projects ... The last activity information is not updated properly in the current state, thus the column should not appear (yet). This will be reversed once it is updated appropriately.	9 years ago
Oliver Günther	6661f2b6d5	Refuse to delete a repository in OpenProject on FS permission errors ... This commit changes the behavior of removing repositories. It is no longer possible to remove a managed repository (model) when the underlying repository directory could not be removed. This error originally occurred when Apache committed changes to the repository through mod_svn, which resulted in the OpenProject user being unable to delete a particular subdirectory.	9 years ago
Jan Sandbrink	f9cb083481	in production handle internal API errors gracefully ... - still allow for useful errors during development - let all own exceptions inherit from StandardError, the thing you should use for own errors...	9 years ago
Stefan Botzenhart	7e74650e02	Fix rubocop concerns	9 years ago
Stefan Botzenhart	394c0d08a3	Authorize custom fields controller method	9 years ago
Stefan Botzenhart	e95fd22218	Move custom field selection for a project to its own tab ... * edit_project permission shall apply * add notice if action fails	9 years ago
Jan Sandbrink	2b7261b2ee	move assembly of reports list into controller	9 years ago
Jan Sandbrink	8e4321959e	improve code style	9 years ago
Oliver Günther	f47f61bcbf	Work around outdated group SQL ... The `Group.includes(:users)` call from the GroupsController seems to return an outdated / incomplete result of the members. You can verify that by calling `@group.reload` after the affected line, which will yield the correct result. I assume that this has something to do with the HABTM association `:users` for which a similar issue appears to be still open. Using `eager_loading` directly seems to fix the issue, however we have to remove :memberships here as it requires a condition.	9 years ago
Jan Sandbrink	dfb9a5cd20	remove remaining AR find_by_x finders ... - most of them were removed by @myabc in the rails4 branch - some where reintroduced due to parallel development to that branch - still some occurences left that will hit custom implementations	9 years ago
Oliver Günther	dfb8ac4853	Add basic checkout instructions ... This commit adds very basic checkout instructions similar to `openproject-checkout` to repositories. Issues: * Uses table style for checkout component, as exact styling is unclear * Adds compressed table style with less padding * Checkout settings are best organized in a Hash with keys per SCM * vendor. Using default settings, a lot of new setting values would be introduced * Checks for Hash in SettingsController * Currently can't use SettingsHelper, as it requires single setting values	9 years ago
Jan Sandbrink	2a65240e52	always include relevant columns ... - caller does not need to do it anymore - caller is still allowed to do it, because it can also add own conditions...	9 years ago