openproject

Commit Graph

Author	SHA1	Message	Date
Benjamin Bädorf	87cd178270	Fixed more linting errors (#9452 ) * Fixed more linting errors * Update the selector of the focus directive to opFocus * Update the selector and BEM class of the focus-within directive * More linting fixes * Remove unused directives, merge focus and autofocus directive, remove now empty a11y module * Some small fixes * Fix ReorderDeltaBuilder * Fix failing specs, linting * Fix a couple of linting errors * Reenable linting rules for unsafe any * Reset broken code, update some html coding style	3 years ago
Oliver Günther	e9f1781d2b	Use contracted member services and show only manageable projects in user administration (#9076 ) * Reuse contracted services in memberships controller * Show only manageable projects * Show only manageable projects in select box * Reject empty values in role_ids * Add spec for when user has no manage_members permission * Also handle delete through service * Extend spec for when user has no manage_members permission * Extend Members SetAttributesSpec * Make manageable_Members an instance method and add spec * hide buttons if user is not allowed to use them * Rename manageable_projects to assignable_projects * Build a membership for the contract * Fix url for global_roles to work with update and create methods Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	bbeae32698	[35508] Add global permission to manage placeholder users (#9000 ) * Add global permission to manage (but not delete) placeholders https://community.openproject.com/work_packages/35508 * Restore breadcrumbs for non-show routes * Remove permissions to memberships for add_placeholder_user permission * Allow non-admins with global permission to access membership * Remove permissions to memberships for add_placeholder_user permission * Rename shared_examples for admin contract validations Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	7f34799a33	Chore/reimplement global roles (#8730 ) * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter	4 years ago
ulferts	27b41a313c	replace custom i18n function in views	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Inga Mai	edc3bcc613	Remaining Labels removed; titles for all buttons instead	6 years ago
Oliver Günther	f86abae9eb	Enforce Arel.sql for string order, pluck	6 years ago
Henriette Dinger	c7d1e699ca	Remove doubled id (#6236 ) [ci skip]	7 years ago
Oliver Günther	ab4f9b7ed5	Replace settings and boards remotes with actual responses	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	bb88d38ff0	[25979] Toggle membership form elements and compile response … (#5802 ) * [25979] Toggle membership form elements and compile response This fixes two issues: 1. Toggles the form elements with a class selector so the impermanent memberships plugin can extend it. 2. Compiles the response html so subsequent datepickers are shown https://community.openproject.com/wp/25979 * Apply the same fix to the member cell [ci skip]	7 years ago
Oliver Günther	b2b499a7fd	[25686] Use collection_check_box in membership page This adds a hidden field for when no checkbox is selected, however it adds the caveat that non-selected values are transmitted as empty values, thus we have to filter them again in the backend.	7 years ago
Oliver Günther	441279e4a9	Fix icons in member rows	8 years ago
Oliver Günther	8c8f4d329c	Remove interactiv-table and background usages	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	28fc8d37b2	split memberships concerns from users controller	8 years ago
Jens Ulferts	c945cd2021	replace prototype in views	8 years ago
Oliver Günther	983dba10bb	Add simple link_to_function replacement	8 years ago
Oliver Günther	b7040e0960	Remove role="grid" from tables As described in https://community.openproject.org/work_packages/20429/activity#activity-19, the role 'grid' effectively blocks impaired users from detecting input elements in cells of those tables.	9 years ago
Oliver Günther	8dc9b592c4	Fix merge hickup	9 years ago
Henriette Dinger	244d2d81e8	Update icon classes from 'reload1' until 'yes3'	9 years ago
Mohamed Wael Khobalatte	0e72ec4243	Move to ruby1-9 syntax once and for all	9 years ago
Peter Lehwess	36010c2f67	Replace most no_data labels with he no results helper	9 years ago
Henriette Dinger	ee31ccdccf	Exchange classes and labels: delete, remove	9 years ago
Jens Ulferts	78dc3d36a5	use sensible class name	9 years ago
Jens Ulferts	4da09d1ad2	move membership table hooks to before the buttons This is a place that fits the need of more plugins.	9 years ago
Henriette Dinger	d8c322a61c	fixed style bugs	9 years ago
Henriette Dinger	3825250562	styled more hidden tables in Admin/Workflows, Admin/Users, Admin/Groups, Admin/Roles	9 years ago
Alex Coles	2faeb3a34a	Migrate AR finder/query methods in views Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a003c93351	Remove success button styling from forms, modals This effectively reverts `7c6890825d` `ecec5032eb` Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	b8362f7951	Add icon to success buttons in Rails views NOTE: This patch switches most buttons from `input[type=submit]` to `button[type=submit]` (Rails' `button_tag` helper sets `[type=submit]` by default). This is a quick-fix: ideally, methods should be added to view helpers /`TabularFormBuilder` that append the relevant modifier/icon classes. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6bcd0b0285	Apply form fieldset styling to user forms Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	fa38bb9470	Apply styling to user forms Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	322c14d334	Replace splitcontent* classes with Foundation grid Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	15c270b1f6	Normalise indentation in Rails ERB views Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	bd22b35395	Apply button styles to most buttons in Rails views Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	cc766fb598	uses fully qualified route on users memberships This avoids problems when other controllers render the partial	10 years ago
Alex Coles	9f762c3cd4	Fix whitespace in (Rails) views Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Hagen Schink	0a1259e018	Remove superfluous script	11 years ago
Johannes Wollert	c8d4e449cc	unifies creation/deletion/error notices in user's membership tab	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Christian Ratz	4550f23330	Use new delete icon - removed old delete icon styles - uses new icon font for delete icon - whitespace fixes in app/views/projects/settings/_versions.html.erb	11 years ago
jwollert	643bd70d42	fix readding a users membership to a project in admin panel	11 years ago
jwollert	1cd3597157	adds a id to the new membership form inside admin's user edit panel	11 years ago
jwollert	77310b40f3	removes remote_form_for from admin's user edit panel, so we don't get 2 requests on all actions	11 years ago

4 Commits (31ffea7452be5029cc96b72687e1891140c877d6)