openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Alexander Bach	a5f4eb1e8b	First event-based draft Unifies Journal- and WorkPackageObserver Removes them as observers Makes new JournalListener more classy	9 years ago
Alex Coles	f320305531	Revert "Temp. comment includes in API v2 ProjectController" `FriendlyId::Finders` should ensure an identifier-aware `find` on an `ActiveRecord::Relation` chain. This reverts commit `51512f1522`.	9 years ago
Alex Coles	347f363026	Remove unloadable from controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
peter	6a7ab0edb8	fix invalid response for /api/v2/authentication.json	9 years ago
Alex Coles	8b4be7f749	Indent fix in RepositoriesController for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a3af19a8ff	Indent fix in SysController for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	acd23b8046	Fix missing space around block in MyController Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks `rubocop -a` does not currently normalise formatting consistently (see `ec1bb39f`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	75cecdb21a	Omit extraneous [] in APIv2 CustomFieldsController Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Florian Kraft	f8d69c5212	address hound complaints Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jan Sandbrink	f86e0ef591	uglify order statement at least this one DOES work...	10 years ago
Jan Sandbrink	253785622c	specify order in the Rails 3 way ascending is the default anyway	10 years ago
Jan Sandbrink	9cb9957bbb	also accept auto complete requests without query	10 years ago
Jan Sandbrink	d2eeb27c84	eliminate instance variable	10 years ago
Jan Sandbrink	c9f0fba192	increase readability of wp->hash conversion it might use more lines, but I hope there is a gain in readability	10 years ago
Jan Sandbrink	8897235fa4	rewrite find into where, order and limit	10 years ago
Jan Sandbrink	194f1814e1	always return a valid scope though WorkPackage works like a scope most of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	10 years ago
Jan Sandbrink	e51a4005ff	try to increase readability - extract scopedeterminition into an extra method - always use "outer" if statements in index method	10 years ago
Jan Sandbrink	280e333f18	explain why some code exists	10 years ago
Jan Sandbrink	2854584cb2	use more clear scopes for autocompletion lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	10 years ago
Jan Sandbrink	45815cb9f3	rename query to scope sounds more understandable to me, but I am biased, I guess...	10 years ago
Alex Coles	851f23712f	Prune commented code in TimelinesController [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	8798fe68ad	Teach Experimental API UsersController to pluck Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0942d7335b	Add explicit join references in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2d9cfd97f4	Remove deprecated Relation#all in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	ffd81c4886	Add some polish	10 years ago
Markus Kahl	bcd981df5c	consider X-Authentication-Scheme; opt scoped realm	10 years ago
Markus Kahl	d854df5175	suppress browser prompt on authenticate failure	10 years ago
Alexander Bach	1a52cc1292	Suppress the hound	10 years ago
Alex Coles	0c729dae54	Replace deprecated calls to Model.scoped Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	c687c63c71	Fix some project url building with identifiers This commit was powered by @ulferts	10 years ago
Alex Coles	ecfa05fad9	Rename Project.public scope to public_projects Avoid collision with `public` class method. As of Rails 4.1, `public` is explicitly black-listed as a scope name: https://github.com/rails/rails/pull/14582	10 years ago
Alex Coles	51512f1522	Temp. comment includes in API v2 ProjectController `includes().find` appears to have issues with polymorphic associations in Rails 4.0.x. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e02eb0181d	Migrate AR finder/query methods in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	9eb7cfbe9b	actually allow the status to be set while moving apparently the status_id param was set to expect an array of values while being moved in this commit: `d7f399ab8d` Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	10 years ago
Jan Sandbrink	d3ceffddfc	actually allow the status to be set while moving apparently the status_id param was set to expect an array of values while being moved in this commit: `d7f399ab8d` Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	10 years ago
Jan Sandbrink	b44b0cd2f9	remove details on spent time from project overview	10 years ago
Jan Sandbrink	42ec887384	uglify order statement at least this one DOES work...	10 years ago
Jan Sandbrink	0f868f17e2	specify order in the Rails 3 way ascending is the default anyway	10 years ago
Jan Sandbrink	9ed5480298	also accept auto complete requests without query	10 years ago
Jan Sandbrink	799f3b9b52	eliminate instance variable	10 years ago
Jan Sandbrink	b265ad88db	increase readability of wp->hash conversion it might use more lines, but I hope there is a gain in readability	10 years ago
Jan Sandbrink	b524b0724d	rewrite find into where, order and limit	10 years ago
Jan Sandbrink	dd052d5114	always return a valid scope though WorkPackage works like a scope most of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	10 years ago

... 5 6 7 8 9 ...

3092 Commits (32a78f50b05bc73c652a00ff550dd21bdd63315e)