openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	4d17b19783	[36026] Ensure project filter only searches for active projects https://community.openproject.com/wp/36026	4 years ago
Oliver Günther	e4c9506e56	[36081] Increase max lengths of user/group names (#8948 ) * Unset DB limits for user attributes * Validate groups in synchronized groups * Extend limitations and fix specs	4 years ago
ulferts	ef948465a1	fix atom export (#8952 ) The feed is opened in a new window so that the url can then be copied into a client while the original view persisted. The solution is not optimal as it requires to call the backend twice but as this function should be used very little, it should be enough	4 years ago
Markus Kahl	af48244ffd	make download URL expiry configurable, use safer default	4 years ago
Markus Kahl	51a40c97eb	set content type of attachments in S3 (#8938 ) * set content type of attachments in S3 * refactoring to allow amending and reading given metadata more easily * confirm attachment content type is sent to S3	4 years ago
ulferts	8af2d6e582	fix version links on roadmap (#8936 ) * adds an id to the version link to be anchorable * adds an achor element to the link in the version list * whitelists the possible filter parameters for the version list links The solution has an insufficiency in that the browser unnecessarily reloads the page if the user had filtered before and then clicks on a link. I find that acceptable.	4 years ago
ulferts	2744673ec8	avoid updating the lock version on finishing an attachment upload (#8934 ) If the lock version is increased, it might happen while the user is still editing the description. The user might have added an image to the description and continues typing. In the backend, the FinishDirectUploadJob is run before the user presses the checkmark to send the updated description. In that case, a 409 conflict would be signaled if the lock version were to be updated in the meantime.	4 years ago
ulferts	38cae188ad	Fix/journals on direct uploads (#8933 ) * linting * use Carrierwave's replacement for filename This avoids having the name altered by Carrierwave later on in the Attachments::FinishDirectUploadJob job where the file is fetched and then the attachment is stored. * separate cases for no attachment and no local file * correct journalizing on direct upload In case the container of an attachment is journalized, the container needs to have added a journal to it when an attachment is uploaded. Without that, the attachment is only picked up in the journals once the container is altered again (possibly by a different user). This will then lead to a history which does not reflect the actual upload.	4 years ago
ulferts	4ad9ebc6ee	Fix/filename on direct upload (#8928 ) * linting * use Carrierwave's replacement for filename This avoids having the name altered by Carrierwave later on in the Attachments::FinishDirectUploadJob job where the file is fetched and then the attachment is stored. * separate cases for no attachment and no local file	4 years ago
ulferts	bf6d0c727a	fix scheduling bug if predecessor dates are removed and follower only has due date set	4 years ago
ulferts	69fd5d6d86	avoid pre + code dom structure (#8896 )	4 years ago
Benjamin Bädorf	488cd3eff9	Fix/wysiwyg changes (#8884 ) * Only set styling on code-block when editing * CKEditor fixes Adds op-uc-figure--content fix for tables, Adds op-uc-container to preview, * Left align figure content by default, making the changes in appearance less severe * Revert wrapping table in op-uc-figure--content in edit mdoe * Update CSS Classes spec * Resize figcaption together with image * Add underlines to headings on wiki pages * Remove word breaking from tables * Left align images in editor * Avoid break inside all figures, including images * linting * restrict lines under headings to h1 only * remove ckeditor changes * adapt spec to altered l10n string * revert expected css classes since ckeditor remains unchanged Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	26295af6bd	Chore/replace activemodel mocks (#8892 ) * replace stub_model calls * replace mock_model * remove rspec-activemodel-mocks dependency	4 years ago
ulferts	f453772ed8	avoid duplicate toc numberings (#8891 )	4 years ago
Benjamin Bädorf	7c36920ab8	Only set styling on code-block when editing (#8880 ) * Only set styling on code-block when editing * Only overflow code blocks in view mode * Update code-block styles to wrap text in edit mode * Fixed language indicator for code blocks * Fix spec class	4 years ago
Aleix Suau	53f8e985ff	Fixed: figcaption kept inside the image (#8882 ) * Fixed: figcaption kept inside the image * adapt specs to altered figcaption handling Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	9f6ea0812c	use acts_as_url for new wiki page (#8878 )	4 years ago
ulferts	41590f17cf	handle special case of wiki page consisting of only a dot (#8876 )	4 years ago
ulferts	7a738cebc6	Feature/group fold button (#8863 ) * add fold/unfold groups button * wip * introduce service to communicate fold state * fix colspan on folding/unfolding groups * move state handling into service * refreshAllGroupHeaderCells when allGroupsChanged too * have correct order for states to update * rely on refreshView to trigger collapsedRowRefreshing The refreshView method is called whenever a group is folded/expanded. Therefore, the listeners for the states are just extra and lead to the code being executed twice. * remove code made obsolete by commit before * show group toggle button only when grouping * use plus/minus icon for button * shorten code * remove duplicated code * linting * dropdown for expand/collapse * add icon to button * alter button position and switch icons * remove text from group toggle button * have unique html id on fold button * Rerendering only group rows when grouping changes * Disable unavailable menu collapse option + merge old collapse state * refreshAllGroupHeaderCells when allGroupsChanged too * Disable collapse options handling mixed scenarios * Working with different grouping & updating grouping options disable * Code climate fixes * Fix + Types with headers extracted to service * Test fixes * CodeClimate fixes Co-authored-by: Aleix Suau <info@macrofonoestudio.es>	4 years ago
ulferts	df65b83d81	attempt to stabilize flickering spec	4 years ago
ulferts	2ad215fed1	add milestone type filter for default project gantt query (#8869 )	4 years ago
ulferts	428d23f267	disregard readonly status on project copy (#8873 ) By moving the readonly status restriction into the `reduce_by_writable_permissions` method, that functionality is disabled (as it is overwritten) when copying projects.	4 years ago
ulferts	a112999dcc	fix ruby 2.7 deprecations (#8867 )	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844 ) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit `0d27d28137`. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	25d3ac0a09	attempt to stabilize flickering spec	4 years ago
ulferts	6af7401704	fix ruby 2.7 deprecations (#8866 )	4 years ago
ulferts	ae38be12c9	fix ruby 2.7 deprecations	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	7f34799a33	Chore/reimplement global roles (#8730 ) * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter	4 years ago
ulferts	7b31311713	Chore/rename timestamp on time entry (#8754 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on	4 years ago
ulferts	8c554ba0c9	Feature/mentions rewrite (#8853 ) * update ckeditor * output user-mention link on mention tag * spec revisiting a user mention * amend mention recipients by tag * handle wp mentions	4 years ago
Aleix Suau	459bbcb80a	Feature/32616 show children in row on collapsed parents (#8800 ) * Showing milestones on collapsed project rows * Showing milestone's labels on hover * Milestones adapting to zoom changes + refactor * Refactor to make it applicable to other wp types * Calculate timeline width including wps shown in collapsed rows * Tests * Custom labels for duplicated cells * Custom labels for duplicated cells * Hide empty labels on hover * All tests passing (switched to isMilestone function) * Make up * Showing milestones on collapsed project rows * Showing milestone's labels on hover * Milestones adapting to zoom changes + refactor * Refactor to make it applicable to other wp types * Calculate timeline width including wps shown in collapsed rows * Tests * Custom labels for duplicated cells * Custom labels for duplicated cells * Hide empty labels on hover * All tests passing (switched to isMilestone function) * Make up * Refactor fix * Empty line at the end of the file * Empty line at the end of the file * Hide non hover labels on group rows * Only include header cells for wp with date or startDate * Add group header cells into Autozoom width calculations * Showing labels on group headers * LabelRight's padding reduced * group-row class name changed to modifier -group-row * withCustomLabels moved to WorkPackageCellLabels class * withCustomLabels renamed to withAlternativeLabels * isDuplicatedCell and withAlternativeLabels moved into RenderInfo * Typings improvements * Duplicated code extracted to getWorkPackagesToCalculateTimelineWidthFrom * Conditional flag moved out of manageCollapsedGroupHeaderCells * manageCollapsedGroupHeaderCells setup extracted to a method * manageCollapsedGroupHeaderCells setup extracted to a method * manageCollapsedGroupHeaderCells setup extracted to a method * Group logic extrated to groupTypeFromIdentifier and groupIdFromIdentifier methods * Remove 'project' hardcoded reference from createCollapsedGroupHeaderCells * Common pipes grouped in a getter * Codeclimate fixes	4 years ago
ulferts	c383c5821f	Fix/remove cucumber (#8847 ) * replace very last cuke with spec * remove cuke support files * remove cucumber gems * remove traces of cucumber * remove no longer required route * forcefully clear parallel_test features task * attempt removal of binstub * attempt to stabilize spec	4 years ago
ulferts	3122c00c4c	replace cukes with specs	4 years ago
Benjamin Bädorf	5f45ee07ab	Move development docker-compose file to the main directory (#8798 ) * Move development docker-compose file to the main directory This requires us to move some other files around, like the pullpreview and example docker-compose file for production setups. This commit also does some housekeeping, like removing some old files and deduping configuration. * Updated to selenium grid * Fix in-Docker Selenium tests The Selenium tests now run inside a Docker Chrome Container. Backwards compatability with non-docker setups is not guaranteed, though it should not be hard to implement with a couple of small fixes. * Updated docker development documentation * Improved test timings, changed the documentation * Updated docker testing again * Run npm in the frontend directory * Really run npm in the frontend directory * Also run npm in frontend when setting up travis cache * Change directory for one command only * Change default test driver name * CI test change fixes * Fixed syntax error * Added dev check * Trying to fix firefox resizing * Trying to get tests running * Stop resizing firefox * Fixed apple icon spec * fix host in url helpers for omniauth spec * Fix omniauth specs * Fix docs * Small fixes to docker tests * Added package.json back in * Change env variables Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
ulferts	317d90444f	only embed direct relations in wp representer (#8831 ) * only embed direct relations in wp representer * add integration tests for embedded relations	4 years ago
ulferts	9ddf75848c	replace cuke with spec	4 years ago
ulferts	f511f8d4f5	set default role when copying project as non admin (#8824 )	4 years ago
ulferts	d5e490efda	set the copying user to be the author of attachments (#8822 )	4 years ago
Wieland Lindenthal	c919da0550	Fix: #35132 Activity broken for wiki pages with slashes in title (#8823 )	4 years ago
ulferts	ae2edad19b	Fix/copy project wiki notifications (#8777 ) * rename to convey applicability to all journal notifications * adapt journal completed job to handle wiki content * remove empty module * create wiki_content mail service * introduce copy/create service and contract for wiki pages * specify set attributes and create contract for wiki pages * copy the content attributes * use wiki page create service when copying wiki * introduce specifc service for copying wiki pages The contract disables checks for permissions on the wiki page. The copy_projects permission should suffice to copy everthing in a project * copy wiki pages top down to rewrite hierarchy * limit copied attachments to copied type	4 years ago
ulferts	5a7176e6e1	Fix/search for projects (#8815 ) * fix searching for projects * only provide search options active in the project	4 years ago
Wieland Lindenthal	5b084dccd7	Fix: Always allow custom styles when in BIM edition (#8813 ) This fixes the following bug with BIM Community Editions (in other words: no Enterprise Edition, but BIM Edition). A package based installation in which the "bim" edition was selected did not show the BIM theme. Instead it showed the normal OP theme. This PR - extracts the check if custom styles shall be applied to a helper. - adds a spec for the new helper.	4 years ago
ulferts	8175dc4acd	add language to user api (#8812 ) It is documented and as such, it should be part of the api	4 years ago
ulferts	5b95eb4412	remove outdated member autocompltion code (#8811 )	4 years ago
Markus Kahl	a8f04ae044	make sure API settings controller is loaded by declaring the API acronym (#8792 )	4 years ago
ulferts	33081e1f97	increase performance of scheduling by avoiding paths aggregation It is no longer necessary as we are no using `UNION` and not `UNION ALL` so that even if a path is traversed back again, that will not lead to an infinite loop since the `UNION` will work as a DISTINCT canceling out paths that we have already traversed	4 years ago
ulferts	0e6072aefa	fix accessibility spec expectations	4 years ago
ulferts	d77fa1aeb6	fix date inheritance from parents with only one date available	4 years ago
Wieland Lindenthal	7ee5686373	Fix seeder spec. Cleanup yml.	4 years ago

1 2 3 4 5 ...

6887 Commits (35add6e5e1a99512ed55cfe52171a667fdcbdb7c)