openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Jan Sandbrink	17940bf02c	change validation of WP children - do not add error on a symbol called :#123 (123 is the childrens ID) - this is against the semantics of ActiveRecord::Errors - creating symbols in a loop used to be a bad idea (might be better today) - it breaks error messages in the APIv3 (which is due to APIv3 working beyond the borders of AR errors, not the best of ideas...) - use :base instead, the place for unlocatable errors - include the fact that #123 refers to a child element in the error message Basically I feel that this makes the children validation cleaner and better. But somehow I fear, that there is some code out there that depends on the fact that error keys like :#123 existed...	9 years ago
Jan Sandbrink	218c75e765	fix update_by! user when not providing notes - previously the created Journal Entry would have been made by the specified user or the User.current, dependent whether :notes were provided or not - now the journal entry is always made by the specified user	9 years ago
Alexander Bach	c42dad3270	Correct comment	9 years ago
Alexander Bach	2f9c9178df	Fix regex properly	9 years ago
Alexander Bach	248f11fba8	Correct style	9 years ago
Alexander Bach	1a52cc1292	Suppress the hound	9 years ago
Alexander Bach	851f8bf3d1	Make validation regex comply with hint	9 years ago
Jan Sandbrink	9f4ebc04a5	fix moving of WPs without specifying a status attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	9 years ago
Jan Sandbrink	96d0cf9462	fix moving of WPs without specifying a status attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	9 years ago
Oliver Günther	cb123c83be	Fix and specs for missing plus in login attribute Fixes the merge issue from `105934a5f9`	10 years ago
Jan Sandbrink	9a9d6aca2c	ensure correct file size errors are displayed	10 years ago
Jan Sandbrink	4a69d2505a	replace ternaries returning booleans - foo ? true : false was replaced where foo already was bool - foo ? true : false was kept, when the ternary did a bool conversion - foo ? false : true was replaced by either negation or replacing == with != Note: I intentionally left one occurence that is fixed in another running PR and would cause a conflict	10 years ago
Markus Kahl	8f7d8ef573	avoid unnecessary work	10 years ago
Markus Kahl	2b8848dc8b	don't use deprecated finder	10 years ago
Markus Kahl	6cb6953a07	basic auth for api v3 (WIP)	10 years ago
Jan Sandbrink	f1a93e1cf3	this is why I hate comments	10 years ago
Jan Sandbrink	c075a7b401	only allow simple space in login also add specs to verify that	10 years ago
TribesTom	2910137c03	Added user changement	10 years ago
Alexander Bach	55f5f33456	Changed code readability	10 years ago
Alexander Bach	942f39876f	Removed hard coded id column for pdf export	10 years ago
Alexander Bach	404a5b42e6	Remove hard coded id column for csv export	10 years ago
Jan Sandbrink	88107362b1	enhance PSQL compatibility of cast_value In PSQL a valid boolean can also be represented using other value than '0' and '1' This led to cast_value sometimes returning false, even though it was supposed to return true...	10 years ago
Jan Sandbrink	eb9ef1f2b1	replace occurences of cast_value with typed_value	10 years ago
Alex Coles	54ff7af6e7	Add/update Copyright headers in app code Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	60ca779111	make transform to boolean more database resistant PostgreSQL has many representations for bool: http://www.postgresql.org/docs/9.1/static/datatype-boolean.html	10 years ago
Alex Coles	ef4285bc0c	Kill deprecated Setting.*_cache methods Deprecated in version 2.4.0 (2011). See: `d76fd8e4`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	9f692f6bf1	Use the empty string for absent descriptions	10 years ago
Jan Sandbrink	f9b242884d	let custom values accept their native type - add specs for strategies to parse their typed representation as valid (instead of only their stringly typed counterpart) - add specs to int and float strategy regarding accepting eachother - fix int custom values accepting float inputs (which would work, but omit the fractional part) - fix date custom values not accepting on Date	10 years ago
Alexander Bach	2d2f18b2c5	Remove unused code	10 years ago
Alexander Bach	ee31bc9762	Increased code readability	10 years ago
Alexander Bach	35f9ec6db8	Consider all of the time entries visible to the user	10 years ago
Jan Sandbrink	2bf38a622f	create journal when CF toggles between false + nil the changed? method of the JournalManager did handle false values not correctly and considered them blank. However, a boolean CF that is not required can have (technically) three states: - true - false - nil Thus we can't consider nil and false as the same case	10 years ago
Jan Sandbrink	5f19189e71	create CF journal for CF set to false This is only an issue when the CustomValue.value is actually false. Legacy code uses stringly typing and thus has values like "1" and "0"	10 years ago
Jan Sandbrink	f31dd80acb	add explicit author to more mails neccessary for correct self-mail detection	10 years ago
Jan Sandbrink	93d20011e5	fix more TestUnit tests - also adding author to news_added	10 years ago
Jan Sandbrink	1f3b47f461	test and fix mail delivery - add specs testing the observable behaviour - keep the interceptor mostly intact - use the same hack already known	10 years ago
Jan Sandbrink	05bdba6a29	fix preview of true custom field in form :typed_value would not return true if the internal value was set to true (it only ever expected it to be '1')	10 years ago
Jens Ulferts	13e0940171	only display scm options if they are configured	10 years ago
Jens Ulferts	fce72938e3	prevent path traversal via filesystem scm Setting up a filesystem scm now requires to specify a whitelist via the configuration	10 years ago
Jan Sandbrink	9fbf3864f8	use callable to define scope - Rails 4 compatible - MIGHT fix an issue on travis	10 years ago
Jan Sandbrink	52696b5c98	extract a scope for active priorities	10 years ago
Alexander Bach	15f52bcdc6	Added validation for estimated hours values	10 years ago
Alexander Bach	cac13a8f4d	Simplified validations to their core necessities	10 years ago
Alexander Bach	ed73ab271c	Basic implementation	10 years ago

1 2 3 4 5 ...

2351 Commits (35c78a6acc6b12ec777a5635fb94d107ff0b34e8)