160 Commits (35cf3fbfad652ac58ef4cdc9f7c949ded90a1cad)

Author	SHA1	Message	Date
Jan Sandbrink	218c75e765	fix update_by! user when not providing notes ... - previously the created Journal Entry would have been made by the specified user or the User.current, dependent whether :notes were provided or not - now the journal entry is always made by the specified user	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	822731526b	Use #describe with String arg not symbol ... See core commit: http://github.com/opf/openproject/commit/3785fdc9edb187b9e5239879d6f5e41 1a10ae3df	10 years ago
Jan Sandbrink	88b99db223	only respond to valid custom_field_n accessors ... it is not enough that the CF exists, it actually has to be a CF that can be used on that work package	10 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6cd0cad516	Remove #errors_on usages in specs ... This behaviour would now require `rspec-collection_matchers`. See https://github.com/yujinakayama/transpec#note-about-expectmodelto-havenerrors_onattr Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	857bcf4636	some refactoring around the WP schema ... - schema does not decide anymore whether to include allowed values (solely decided by "form_embedded" of representer) - schema will answer as many "assignable_*" methods as possible - work package does not need those methods anymore (except few cases)	10 years ago
Alex Coles	3785fdc9ed	Use #describe, #context with String arg not symbol ... The semantics of `describe` have changed in RSpec 3: passing a symbol rather than a string will change the value of the described object. See discussion here: https://github.com/rspec/rspec-core/issues/1114 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	944b89d83e	Convert specs to RSpec 3.2.0 syntax with Transpec ... This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 34 conversions from: it { should ... } to: it { is_expected.to ... } * 14 conversions from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: be_true to: be_truthy * 3 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: failure_message_for_should { } to: failure_message { } * 2 conversions from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: Klass.any_instance.stub(:message => value) to: allow_any_instance_of(Klass).to receive_messages(:message => value) * 1 conversion from: be_false to: be_falsey * 1 conversion from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: stub('something') to: double('something') * 1 addition of: RSpec.configure { |c| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Jan Sandbrink	3168182499	"fix" a previously "good" spec	10 years ago
Jan Sandbrink	1aa234ae58	fix another broken spec	10 years ago
Alexander Bach	03494dae0a	Some style improvements	10 years ago
Alexander Bach	92618be3ed	Added tests for category writing	10 years ago
Markus Kahl	96b4f1e99c	fixed broken wp spec ... the current user within the shared example is a different one to the one (anonymous from the outmost spec scope) than the one defined in the 'user with permission to view time entries' context, which, I believe, is unintended and also happens to break the spec with the changes to the journal observer.	10 years ago
Jan Sandbrink	9b54862b53	allow patching of WP priorities ... - allow PATCH - add schema to form - add specs	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Hagen Schink	ca3b33b5be	Test that it is allowed to assign a group as responsible ... There isn't a validation for this yet. But also assignee misses such a validation. I left a TODO, so others are reminded to fix this globally someday.	10 years ago
Hagen Schink	d735ec90ce	Test that it is possible to assign groups as responsibles	10 years ago
Hagen Schink	ce8c1fd1c7	Test that assignable responsibles can contain groups	10 years ago
Hagen Schink	c6ab37e25e	Test WP's spent hours property with read permission	10 years ago
Alex Coles	f95c9d15f3	Prefer #map over #collect in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	a01e7cbb92	fix specs broken by automatic rspec transformation	10 years ago
Alex Coles	714966de5c	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 13 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 4 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 2 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	82489fc5eb	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 14 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 11 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 4 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 2 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	b77334119c	Fix incorrectly converted collection assertions ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	8cd802c0df	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 1.12.0 with the following command: transpec * 234 conversions from: obj.should to: expect(obj).to * 139 conversions from: == expected to: eq(expected) * 25 conversions from: obj.should_not to: expect(obj).not_to * 20 conversions from: be_true to: be_truthy * 19 conversions from: be_false to: be_falsey * 9 conversions from: obj.stub!(:message) to: allow(obj).to receive(:message) * 8 conversions from: =~ [1, 2] to: match_array([1, 2]) * 5 conversions from: it { should ... } to: it { is_expected.to ... } * 2 conversions from: collection.should have(n).items to: expect(collection.size).to eq(n) * 1 conversion from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 1 conversion from: lambda { }.should_not to: expect { }.not_to * 1 conversion from: obj.stub(:message) to: allow(obj).to receive(:message)	11 years ago
Alex Coles	e58fb87517	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 1.12.0 with the following command: transpec * 249 conversions from: obj.should to: expect(obj).to * 38 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 31 conversions from: == expected to: eq(expected) * 31 conversions from: obj.should_not to: expect(obj).not_to * 14 conversions from: be_true to: be_truthy * 12 conversions from: =~ [1, 2] to: match_array([1, 2]) * 8 conversions from: collection.should have(n).items to: expect(collection.size).to eq(n) * 6 conversions from: be_false to: be_falsey * 5 conversions from: it { should ... } to: it { is_expected.to ... } * 1 conversion from: =~ /pattern/ to: match(/pattern/) * 1 conversion from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 1 conversion from: lambda { }.should_not to: expect { }.not_to	11 years ago
Alex Coles	efe24e1049	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 1.12.0 with the following command: transpec * 100 conversions from: it { should ... } to: it { is_expected.to ... } * 17 conversions from: expect(collection).to have(n).items to: expect(collection.size).to eq(n) * 10 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 9 conversions from: be_true to: be_truthy * 9 conversions from: expect(obj).to have(n).errors_on(...) to: expect(obj.errors_on(...).size).to eq(n) * 8 conversions from: obj.should to: expect(obj).to * 4 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 2 conversions from: be_false to: be_falsey * 2 conversions from: expect(obj).to have(n).error_on(...) to: expect(obj.error_on(...).size).to eq(n) * 2 conversions from: pending 'is an example' { } to: skip 'is an example' { } * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: expect(collection).to have_at_least(n).items to: expect(collection.size).to be >= n * 1 conversion from: obj.unstub(:message) to: allow(obj).to receive(:message).and_call_original * 1 conversion from: pending to: skip	11 years ago
Alex Coles	81682a7417	Fix whitespace in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	5cdc438c52	Convert specs to RSpec 2.99.0.beta2 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 402 conversions from: it { should ... } to: it { is_expected.to ... } * 67 conversions from: be_true to: be_truthy * 55 conversions from: be_false to: be_falsey * 35 conversions from: it { should_not ... } to: it { is_expected.not_to ... } * 20 conversions from: == expected to: eq(expected) * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: =~ /pattern/ to: match(/pattern/) * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 1 conversion from: after { example } to: after { |example| example } * 1 conversion from: pending to: skip	11 years ago
Jonas Heinrich	aeb55d8238	refactors spec	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Sebastian Schuster	601dbf6153	Updated copyright notice	11 years ago
Jonas Heinrich	bbf9b20558	fixes the test of the scope with_author	11 years ago
Jonas Heinrich	4ca218a221	refactores displayed number of reported work packages	11 years ago
Ion Biziiac	ef8e02b139	Adds an rspec step that tests WorkPackage 'due_date' field validation	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Sebastian Schuster	7e726ea2a2	Added responsible for work_package summary	11 years ago
Sebastian Schuster	c0f7acafa1	Implemented treating assignees and responsibles differently so there ... are no (non-functional) group responsibles anymore	11 years ago
Hagen Schink	4f4c445581	Adds scope specs	11 years ago
Sebastian Schuster	268567297c	Added copyright notices	11 years ago
Hagen Schink	757067187e	Fixes work package specs	11 years ago
Sebastian Schuster	70bb322e23	Fixed a bug with non-functional validation for work package parents	11 years ago
Sebastian Schuster	4d5cd98244	Fixed copyright headers	11 years ago
Hagen Schink	28f5033d22	Adds copyright headers	11 years ago
Till Breuer	2a27acc187	Add controller spec for cost object updates via context menu	11 years ago