openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	a112999dcc	fix ruby 2.7 deprecations (#8867 )	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844 ) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit `0d27d28137`. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6af7401704	fix ruby 2.7 deprecations (#8866 )	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	7f34799a33	Chore/reimplement global roles (#8730 ) * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter	4 years ago
ulferts	317d90444f	only embed direct relations in wp representer (#8831 ) * only embed direct relations in wp representer * add integration tests for embedded relations	4 years ago
ulferts	8175dc4acd	add language to user api (#8812 ) It is documented and as such, it should be part of the api	4 years ago
ulferts	4dd8e433b4	Fix/bump gems (#8770 ) * bump aws-sdk-core * bump danger * bump parser * bump grape - stream related header setting bug has been fixed * reapply cache headers on stream as grape insists on niling them * bump aws-partitions * bump regexp_parser * bump rubocop * bump webmock	4 years ago
ulferts	05de0a6b3c	employ view_budgets permission check for budgets resource	4 years ago
ulferts	b179f89534	use view time_entries permission on spentTime schema	4 years ago
Oliver Günther	76823ca581	[34446] Fix direct upload with backend-generated resources https://community.openproject.com/wp/34446	4 years ago
ulferts	8969afe617	close time entry modal on enter (#8653 ) * close time entry modal on enter As the time entry is saved anyway once the user saves the form, e.g. by pressing enter in the hours field, we can close the whole modal along with it. The "Save" and "Cancel" buttons do not make sense then anymore * attempt to stabilize flickering spec * fix ruby 2.7.1 hash parameter deprecations	4 years ago
Oliver Günther	af4010b003	[33496] Don't try to lookup custom value by value Only for list types, the value will be an integer to look up by id, but instead use `CustomValue.new(...).typed_value` to use the formatter classes to correctly look up the value. https://community.openproject.com/wp/33496 [ci skip]	4 years ago
Oliver Günther	46741d8579	[33869] Use `auth_source` link for parsing https://community.openproject.com/wp/33869	4 years ago
ulferts	50daff5062	Fix/archived projects via api (#8625 ) * minor code cleanup * allow access to archived projects via api for admins The visibility check will not work in this case as no permission is active on archived projects. We therefore need to return all projects for admins at least	4 years ago
ulferts	87471d9624	remove string_objects and replace deprecated URI.unescape	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
Oliver Günther	86b8ffc326	[30007] Allow users to enable CORS on APIv3 resources Allows a setting and configuration option to allow access to APIV3. Setting allows us to selectively enable this for cloud instances too. https://community.openproject.com/wp/30007	4 years ago
Oliver Günther	e1a88a9a40	[34001] Ensure filters always receive the query context In the mentioned project, the query copy service fails to execute because a filter has lost its context right after `query.save`. There is a hook for `after_commit` which is not relevant here since we're in a transaction, but the context is lost regardless. Instead, we could ensure whenever accessing the filters, the context is set correctly. https://community.openproject.com/wp/34001	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580 ) * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
Markus Kahl	a456537fe2	added missing prepare attachment endpoint for attribute help texts	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557 ) * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
bsatarnejad	3676ead9aa	Change how watchers data is returned to front-end, blocked users are not returned	4 years ago
ulferts	8cb7ed632a	remove watchers embedded in wp representer A client should not rely on embedding and our front end does not appear to	4 years ago
Markus Kahl	b85380f068	handle pending attachment validation errors	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	655f021b92	add derived dates to the work package resource The derived dates are the minimum/maximum of the descendant's dates. As long as the work package is scheduled automatically, the derived and non derived dates should be equal althoug the derived dates will be null in case non descendants exists. But if the user decides to activate manual scheduling the dates can deviate. The derived dates can then help to display the deviation to the user. This commit however does not alter the front end. The dates are eager loaded on the work package index commit using the same mechanims already introduced for spent time. The patched cost attributes, which are also eager loaded, are now eager loaded in the core as well so the patch is removed. As those attributes are now part of the core (although in a different module) it no longer makes sense to rely on patching for this.	4 years ago
Oliver Günther	d43d9e6e00	Add subproject boards and extract common board action class	4 years ago
ulferts	a2a559e553	remove almost duplicate, but faulty, readonly check The writability of the status is already checked at the attribute level	4 years ago
Oliver Günther	2feaec1101	[33678] Priority needs to be a require field Priority was marked non-required for it to turn up in the attribute form configuration. But priority _is actually required_. This results in the frontend adding an optional placeholder `-` value, which makes the resource unsavable. This commit adds priority to the form, but keeps it required as it should be. https://community.openproject.com/wp/33678	4 years ago
Oliver Günther	b1a99353e2	Extend attribute help text for projects and allow images Attribute help text so far could only be added to work packages. This commit adds support for projects and adds the help texts to widget headers for status and description modals in the overview tab as well as extending the attachable mixin to allow uploading images. Uploaded attachments are to be expected to be visible regardless of permissions, thus this also adds an option to make attachments visible to all	4 years ago
ulferts	75b308d154	fix permission checks for edit_own_work_package_notes	4 years ago
ulferts	9fefd297de	use default endpoint for activity api	4 years ago
ulferts	e14679d0b3	avoid loading aggregated journals repeatedly when patching	4 years ago
ulferts	6ed64cddc7	fix activity permission checks	4 years ago
Markus Kahl	9c4d4ebc46	added :schedule_manually attribute to work package	5 years ago
Markus Kahl	ebdd8e0d8a	minor refactoring	5 years ago
ulferts	c546241459	extract into patch	5 years ago
ulferts	801811c6c0	avoid n+1 query for bcf issues on work package list	5 years ago
ulferts	4cb0d0ff91	Feature/delayed bcf export (#8275 ) * delayed bcf export * remove unnecessary eager loading * Update rxjs polling statement with loading indicator * Avoid error handling due to JSON parsing * delay all wp list exports Co-authored-by: Oliver Günther <mail@oliverguenther.de> [ci skip]	5 years ago
Oliver Günther	d55465ecc5	Use prefixed api paths to avoid unloaded class to be used	5 years ago
Oliver Günther	1255aff56a	[32825] Cache external URLs for at max 604799 seconds (#8268 ) Caching the redirect causes AWS links for more than that causes the links to expire if they are still cached by the browser https://community.openproject.com/wp/32825	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	cad1b69a5c	fix reference to i18n keys	5 years ago
Oliver Günther	38ecb6b28c	[32486] Use error response for unauthenticated instead of warden Instead of warden responding with 401 "unauthorized", use our own error response that correctly sets the `WWWW-Authenticat` header. We tripped into the default 401 error that does not output any headers if we're not returning any users. This was caused by another issue: The `session` object may be present, even though no session id exists. Checking `session&.id` instead always yields the anonymous user. This will ensure consumers of APIV3 to always get a JSON / HAL response as well. https://community.openproject.com/wp/32486	5 years ago
ulferts	90d8cbaa15	have filter values ordered by semver	5 years ago
ulferts	9c78d48cea	allow args on scope method	5 years ago
ulferts	c5866298da	Feature/disable bcf creation when lacking permission (#8160 ) * prevent internal key to be visible in json * explicitly check that bcf viewpoints are not supported in some cases * check permission before attempting to create a viewpoint * linting * more linting [ci skip]	5 years ago
ulferts	59f907560e	no mail on empty wp update	5 years ago
ulferts	633a82dff8	display user name as link for non admins The showUser link of the user representer is now used to signal when the link can be followed. That link can only be followed when the user is not logged. The frontend now only checks the availability of the link to determine whether the user name in the work package activity is to be displayed as a link or not	5 years ago

1 2 3 4 5 ...

1796 Commits (371afb4a1ed41fd34a4d6b24a14990846e48e1ee)