openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	b8ca382d34	Group API (#9034 ) * include group members into resource * GET /api/v3/groups endpoint * POST /api/v3/groups * PATCH /api/v3/groups/:id * DELETE /api/v3/groups/:id	4 years ago
Wieland Lindenthal	ffa5ac84a8	Allow deletion of placeholder users when permission of :manage_placeholder_user give (#9018 ) * Refactoring: Rename permission :add_user and :add_placholder_user to :manage_user and :manage_placeholder_user * Add deletion to :manage_placeholder_user permission label * WIP: Check :manage_placeholder_user permission before deletion Specs still missing * In controller rely on authorize_global for deleting placeholder users * Add deletion_info for placeholder users * Extend specs * Set placeholder users to locked when deleting * Review feedback Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	bbeae32698	[35508] Add global permission to manage placeholder users (#9000 ) * Add global permission to manage (but not delete) placeholders https://community.openproject.com/work_packages/35508 * Restore breadcrumbs for non-show routes * Remove permissions to memberships for add_placeholder_user permission * Allow non-admins with global permission to access membership * Remove permissions to memberships for add_placeholder_user permission * Rename shared_examples for admin contract validations Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	5b49b33b21	Prepare for core integration	6 years ago
Oliver Günther	61afac09cc	FactoryGirl => FactoryBot (belongs to opf/openproject#6304 )	7 years ago
Alex Coles	ccb4268793	Normalise syntax with Rubocop Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	16fb352d8d	Use 1.9+ Hash syntax Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	dc7b71a110	Use #describe with String arg not symbol See core commit: `3785fdc9ed` Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	714966de5c	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.1 with the following command: transpec * 13 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 4 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 2 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	8cd802c0df	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 1.12.0 with the following command: transpec * 234 conversions from: obj.should to: expect(obj).to * 139 conversions from: == expected to: eq(expected) * 25 conversions from: obj.should_not to: expect(obj).not_to * 20 conversions from: be_true to: be_truthy * 19 conversions from: be_false to: be_falsey * 9 conversions from: obj.stub!(:message) to: allow(obj).to receive(:message) * 8 conversions from: =~ [1, 2] to: match_array([1, 2]) * 5 conversions from: it { should ... } to: it { is_expected.to ... } * 2 conversions from: collection.should have(n).items to: expect(collection.size).to eq(n) * 1 conversion from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 1 conversion from: lambda { }.should_not to: expect { }.not_to * 1 conversion from: obj.stub(:message) to: allow(obj).to receive(:message)	11 years ago
Sebastian Schuster	268567297c	Added copyright notices	11 years ago
Jens Ulferts	69afb09e70	ports FactoryGirl usage to current schema	12 years ago
Jens Ulferts	b69d6dca86	have a deleted_user_fallback mixin and cost_entry, labor_budget_item and rate using it * deleted_user_fallback will return the deleted user upon asking for user when the user_id of the including model points to a user who no longer exists	13 years ago

1 Commits (37742556a0c9fe940344bea0bf470f5c2516ca10)