openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	ca0629f5cf	Fix service specs	3 years ago
Oliver Günther	b7874852ec	Delete the notification when the WP gets destroyed	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399 ) * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit `e29dced646` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit `1a45c26c1a` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit `0ea21e90c1` Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in `0d6c0b6bc7` * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
ulferts	0c2d87b4eb	choose wp type by position only (#9297 ) There was a misconception in the code related to the `is_default` field. The `is_default` field only governs whether a type is enabled by default in a new project or not.	4 years ago
Oliver Günther	673d8528c3	Reload work package before destruction (#9116 ) https://sentry.openproject.com/sentry/saas-openproject-prod/issues/12403	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043 ) Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	bf6d0c727a	fix scheduling bug if predecessor dates are removed and follower only has due date set	4 years ago
ulferts	26295af6bd	Chore/replace activemodel mocks (#8892 ) * replace stub_model calls * replace mock_model * remove rspec-activemodel-mocks dependency	4 years ago
ulferts	a112999dcc	fix ruby 2.7 deprecations (#8867 )	4 years ago
ulferts	ae2edad19b	Fix/copy project wiki notifications (#8777 ) * rename to convey applicability to all journal notifications * adapt journal completed job to handle wiki content * remove empty module * create wiki_content mail service * introduce copy/create service and contract for wiki pages * specify set attributes and create contract for wiki pages * copy the content attributes * use wiki page create service when copying wiki * introduce specifc service for copying wiki pages The contract disables checks for permissions on the wiki page. The copy_projects permission should suffice to copy everthing in a project * copy wiki pages top down to rewrite hierarchy * limit copied attachments to copied type	4 years ago
ulferts	d77fa1aeb6	fix date inheritance from parents with only one date available	4 years ago
ulferts	05c9e3fca6	Feature/default dates for children (#8605 ) * fix start_date expectation based on setting * extract methods * set dates of parent work package * pass parent on form request * have initial dates displayed correctly in wp create form	4 years ago
Oliver Günther	3b78c25588	Fix spec expecting for start date to be moved back	4 years ago
ulferts	74fe191997	handle switching from manual to automatic	4 years ago
ulferts	7065c162fd	disregard manually scheduled nodes when scheduling work package graphs Instead of fetching all work packages from a subset of the whole graph constructed by hierarchy and follows relationships upon scheduling, only work packages eligible for automatic rescheduling are returned. In order to avoid quering the database multiple times, the whole subgraph is returned at once using a recursive CTE.	4 years ago
Oliver Günther	95d1549858	Move legacy project copy spec to service spec	4 years ago
ulferts	f612752b9a	handle erroneously missing start_date when scheduling	4 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
ulferts	1773a89c5e	return true to signal success	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	24c26702bb	factor in non leaf descendants when calculating the derived hours Before, only the leaves where taken into account to calcluate the derived estimated hours. With the hierarchy of Parent Child Grandchild Only times from "Grandchild" would be propagated to "Parent" with the ones on "Child" being ignored. We now factor in all descendants	5 years ago
ulferts	fa7e469051	also update attributes when parent_id is signaled to be updated	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	fd6d707fa8	adapt specs	5 years ago
ulferts	b9b72f7204	linting	5 years ago
ulferts	4eab6effe1	merge changed_by_system into contract options	5 years ago
ulferts	57f7da4f39	reuse project services in controller	5 years ago
Oliver Günther	edb1fbba79	[30816] Allow moving follower with unset due date https://community.openproject.com/wp/30816	5 years ago
Markus Kahl	cb6d28136d	allow editing estimated time for parents, show derived separately	5 years ago
Oliver Günther	726241bc95	[30532] Don't submit notification mails for parent changes https://community.openproject.com/wp/30532	5 years ago
ulferts	5b758c1419	differentiate between user and system set attributes	6 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299 ) Feature/versions api update [ci skip]	6 years ago
Oliver Günther	38f7461377	[27315] Ensure parent_id is read before it is destroyed When destroying a work package, the `parent_id` virtual attribute may never have been read. If it is accessed afterwards, it will be computed at that time and no longer correct. Then, the WP has `parent_id == nil` and its ancestors will not get updated, even though `parent_id` should actually still be the old value as per Rails defaults. The deleted model has been unchanged, but only marked `destroyed? == true`. https://community.openproject.com/wp/27315	6 years ago
Oliver Günther	353a33df91	[15909] Respect current_date as start_date setting https://community.openproject.com/wp/15909	6 years ago
Oliver Günther	ad43a7ea95	Prepare for core integration	6 years ago
Oliver Günther	3807bc4f7f	[28446] Rename due date to finish date https://community.openproject.com/wp/28446	6 years ago
Oliver Günther	aa9897561b	[28455] Ensure model contracts are initiaited immediately before saving	6 years ago
Jens Ulferts	17d9cba625	do not throw internal error on invalid custom field	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Oliver Günther	ab847b81d7	[27780] Assign default status when type changes and old status does not exist When switching the type, the status is not validated in the target type, resulting in a correctly saved work package whose status can no longer be changed. https://community.openproject.com/wp/27780	7 years ago
Oliver Günther	1cd5be590b	Rename after merge [ci skip]	7 years ago
Oliver Günther	286d862c38	[27746] When validating the contract, ignore the old parent https://community.openproject.com/wp/27746	7 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	ea8daa63af	FactoryGirl => FactoryBot (belongs to opf/openproject#6304 )	7 years ago
Oliver Günther	4d91441dce	[27262] Ensure ID is present in distinct query on leaves https://community.openproject.com/wp/27262	7 years ago

1 2

60 Commits (37742556a0c9fe940344bea0bf470f5c2516ca10)