91 Commits (37ace54ab3ce0732fa03c72a9a9248e47e8b5489)

Author	SHA1	Message	Date
Martin Linkhorst	b42b21185d	we don't need to escape the parameters	11 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	efe24e1049	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 1.12.0 with the following command: transpec * 100 conversions from: it { should ... } to: it { is_expected.to ... } * 17 conversions from: expect(collection).to have(n).items to: expect(collection.size).to eq(n) * 10 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 9 conversions from: be_true to: be_truthy * 9 conversions from: expect(obj).to have(n).errors_on(...) to: expect(obj.errors_on(...).size).to eq(n) * 8 conversions from: obj.should to: expect(obj).to * 4 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 2 conversions from: be_false to: be_falsey * 2 conversions from: expect(obj).to have(n).error_on(...) to: expect(obj.error_on(...).size).to eq(n) * 2 conversions from: pending 'is an example' { } to: skip 'is an example' { } * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: expect(collection).to have_at_least(n).items to: expect(collection.size).to be >= n * 1 conversion from: obj.unstub(:message) to: allow(obj).to receive(:message).and_call_original * 1 conversion from: pending to: skip	11 years ago
Michael Frister	98f81665db	CSRF Protection: Prevent login CSRF	11 years ago
Michael Frister	c91d04981e	Show error on attempt to register with disabled self registration ... This happens for normal registration as well as registration via omniauth. This also changes the redirect to not go to / and go to signin_url instead.	11 years ago
Alex Coles	5cdc438c52	Convert specs to RSpec 2.99.0.beta2 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 402 conversions from: it { should ... } to: it { is_expected.to ... } * 67 conversions from: be_true to: be_truthy * 55 conversions from: be_false to: be_falsey * 35 conversions from: it { should_not ... } to: it { is_expected.not_to ... } * 20 conversions from: == expected to: eq(expected) * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: =~ /pattern/ to: match(/pattern/) * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 1 conversion from: after { example } to: after { |example| example } * 1 conversion from: pending to: skip	11 years ago
Michael Frister	e6df36f2ba	Move omniauth-related AccountController specs to separate file	11 years ago
Philipp Tessenow	4e6a14c8fd	linted AccountControllerSpec	11 years ago
Michael Frister	ca94df7427	Add spec for AccountController#identity_url	11 years ago
Michael Frister	a9315ac6bc	AccountController spec: Use route helpers for MyController	11 years ago
Michael Frister	f3f5306088	Register: Add spec testing back_url is preserved on manual activation	11 years ago
Michael Frister	29a7971e6b	Add spec example testing omniauth_login sets back_url	11 years ago
kgalli	2dbff1fbb2	Log warning if omniauth error occurs but show generic message to user	11 years ago
Michael Frister	66d0324060	Fix AccountController spec ... No idea what I did back then.	11 years ago
kgalli	9e4f84844b	Removal of trailing white spaces	11 years ago
kgalli	0e0fcd3958	Small refactoring of omniauth specs	11 years ago
kgalli	8f0c7cbfcd	bugfix for register method and refactoring of specs ... Bugfix register method was missing user.save for exteranl authentication other than omniauth. Refactoring of omniauth specs to use let method to set omniauth hash.	11 years ago
kgalli	5cb176124a	add omniauth failure callback and specs for omniauth login/registration	11 years ago
Alex Coles	88e8efe12e	Fix failing AccountController#register spec ... With an OpenProject config containing private plugins this spec will fail with the following Error: ActionView::Template::Error: undefined method `allow_password_changes?' for nil:NilClass ./app/models/user.rb:377:in `change_password_allowed?' This failure was most likely previously obscured because `render_views` was not enabled. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	c66b959854	Attempt to work-around an AccountController CI failure ... NoMethodError: undefined method `original_path_set' for nil:NilClass Failure only occurs with a full plugin configuration. See https://github.com/rspec/rspec-rails/issues/860	11 years ago
Martin Linkhorst	a83af510cb	given openproject runs in a subdirectory we cannot allow redirecting to a different subdirectory. also tries to catch shenanigans to circumvent the check like ".." in the path.	11 years ago
Martin Linkhorst	f2feff1cff	convert tests to specs to be able to disable them in plugins	11 years ago
Martin Linkhorst	dc4dd927cc	we don't need to escape the parameters	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Sebastian Schuster	ef179d96ac	Rewrite account test into a spec	11 years ago
Sebastian Schuster	34d6ea150a	Rewrote login unit tests into specs	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Jens Ulferts	f3eb87c3e4	replace deprecated stub! with stub	11 years ago
Christian Rijke	81c1d55c32	Rewrite unit tests as specs so they can be disabled by plugins.	11 years ago
Christian Rijke	2626f0df0d	Stubb settings values in spec instead of persisting them.	11 years ago
Christian Rijke	d30a7458eb	Migrate unit tests to rspec (to be able to disable them in self-registration per mail).	11 years ago
Jens Ulferts	dfc1662434	improve spec and cuke performance	11 years ago
Hagen Schink	501435eb80	Fix rspecs	11 years ago
Michael Frister	7ba90102a7	Add option to force a user to change password on next login ... * Add force_password_reset field to user * Add force_password_reset field to user edit form Also, reindent the form HTML. * Rename force_password_reset to force_password_change * Force password change: Show form on login, allow change * Remove unused step definitions for setting RAILS_ENV * Fix forced password change, add cuke * Don't reveal whether user exists when not authenticated * Also add spec for testing reaction when user is not allowed to change the password. * Improve force password change code after review * Fix MyController password test and change to spec * Fix AccountController force password change spec	12 years ago