2298 Commits (39d8385bd4d7e56645976c9a0f8d06eda0d0c70b)

Author	SHA1	Message	Date
Jan Sandbrink	2bf38a622f	create journal when CF toggles between false + nil ... the changed? method of the JournalManager did handle false values not correctly and considered them blank. However, a boolean CF that is not required can have (technically) three states: - true - false - nil Thus we can't consider nil and false as the same case	10 years ago
Jan Sandbrink	5f19189e71	create CF journal for CF set to false ... This is only an issue when the CustomValue.value is actually false. Legacy code uses stringly typing and thus has values like "1" and "0"	10 years ago
Jan Sandbrink	f31dd80acb	add explicit author to more mails ... neccessary for correct self-mail detection	10 years ago
Jan Sandbrink	93d20011e5	fix more TestUnit tests ... - also adding author to news_added	10 years ago
Jan Sandbrink	1f3b47f461	test and fix mail delivery ... - add specs testing the observable behaviour - keep the interceptor mostly intact - use the same hack already known	10 years ago
Jan Sandbrink	05bdba6a29	fix preview of true custom field in form ... :typed_value would not return true if the internal value was set to true (it only ever expected it to be '1')	10 years ago
Jens Ulferts	13e0940171	only display scm options if they are configured	10 years ago
Jens Ulferts	fce72938e3	prevent path traversal via filesystem scm ... Setting up a filesystem scm now requires to specify a whitelist via the configuration	10 years ago
Jan Sandbrink	9fbf3864f8	use callable to define scope ... - Rails 4 compatible - MIGHT fix an issue on travis	10 years ago
Jan Sandbrink	52696b5c98	extract a scope for active priorities	10 years ago
Alexander Bach	15f52bcdc6	Added validation for estimated hours values	10 years ago
Alexander Bach	cac13a8f4d	Simplified validations to their core necessities	10 years ago
Alexander Bach	ed73ab271c	Basic implementation	10 years ago
Jan Sandbrink	857bcf4636	some refactoring around the WP schema ... - schema does not decide anymore whether to include allowed values (solely decided by "form_embedded" of representer) - schema will answer as many "assignable_*" methods as possible - work package does not need those methods anymore (except few cases)	10 years ago
Jan Sandbrink	348d3c746e	fix submission of "false" as CF value ... it was not possible to set a custom field to false via APIv3. Apparently the way the value is set in other places does not involve "real" boolean types	10 years ago
Jan Sandbrink	53909cbb61	indicate type as editable in schema	10 years ago
Jan Sandbrink	9986466e15	use direct CF accessors in CF injector	10 years ago
Jan Sandbrink	1a25e19c2f	remove 'true?' helper from custom_value	10 years ago
Jan Sandbrink	2e32e120f7	better naming	10 years ago
Jan Sandbrink	943e01c978	use fancy ruby shortcuts	10 years ago
Markus Kahl	21553ea918	avoid 500 upon mail failure when creating issues ... also log the errors with specific tag so they can be found	10 years ago
Jan Sandbrink	3161b9ca7b	remove unneccessary return statements ... this is how ruby style works... apparently	10 years ago
Jan Sandbrink	5ba53b49b9	various small fixes	10 years ago
Jan Sandbrink	2fb0e370ad	only perform validation if it is possible ... IMO the best way to deal with that ugly inter-validation dependency. You just can't meaningfully test whether a value is valid, when you don't know its format.	10 years ago
Jan Sandbrink	25dec31c5a	extract some case statements into fancy strategies ... - 17 new files - lots of new lines of code - specs! - same functionality as before	10 years ago
Jan Sandbrink	05884417f7	let custom values return typed values ... this allows to have type-correct JSON output, e.g.: 12 instead of "12" true instead of "1"	10 years ago
Jan Sandbrink	0be2c94e49	update method doc	10 years ago
Jan Sandbrink	9532c39c5e	add another case to repair list custom fields ... Genius idea to require the parameter of a method to carry totally different information, depending on internal state of the object	10 years ago
Jan Sandbrink	ac655ac789	validate user and version custom fields	10 years ago
Alexander Bach	f403d6aaaa	Increase category validation strictness	10 years ago
Alexander Bach	cf63634444	Appease hound	10 years ago
Alexander Bach	03494dae0a	Some style improvements	10 years ago
Alexander Bach	339a9836ee	Low-hanging fruits of style improvements for work_package.rb	10 years ago
Alexander Bach	41f8f34de5	Set error on category instead of category_id	10 years ago
Alexander Bach	1c84be3dca	Completed basic implementation to write categories via API	10 years ago
Alexander Bach	95721361b9	Incomplete base	10 years ago
Jens Ulferts	a70bbd7045	improve performance of watcher determination	10 years ago
Jens Ulferts	fdd3bd80b6	fix test_unit tests	10 years ago
Florian Kraft	1a2ea133f2	fix tests for wiki and permitted params	10 years ago
Jens Ulferts	c65c60c9b7	style work package form	10 years ago
Jens Ulferts	65de31a7c7	use tabular form builder for project module selection ... * Extends the tabular form builder with the ability to generate check boxes for values that are an array. * Fixes module_enabled? to actually return a boolean * Adapts projects_controller to changed params structure.	10 years ago
Markus Kahl	a90d059841	make sure data is saved after creation already too	10 years ago
Alex Coles	e3913ac8f5	Change {Chili => Open}Project::PrincipalAllowanceEvaluator usage ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	45b75558bb	Change {Chili => Open}Project::Database usages ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	9b54862b53	allow patching of WP priorities ... - allow PATCH - add schema to form - add specs	10 years ago
Markus Kahl	a6d80496db	allow + in user logins	10 years ago
Markus Kahl	0633aa7b1e	created delayed job object for wp update emails	10 years ago
Markus Kahl	ba7d247817	use IDs in CopyProjectJob; send mail synchronously ... also moved the job into the workers directory	10 years ago
Jens Ulferts	0f6357eec6	fixes wp validation for inexistent versions	10 years ago
Markus Kahl	2a8202a1cb	use file column for filename ... the uploader uses that one too, anyway also this way things don't break when the file is missing	10 years ago