openproject

Commit Graph

Author	SHA1	Message	Date
Jens Ulferts	83d4039d26	have labels for all the inplace edit fields The labels are hidden, so they do not disturb. On the other hand, they enable blind users to have the fields properly named for them by a screen reader. It would be better, to have the element to the right of the input element (in the dt) turn into a label. But given the current structure of the directives that would have been way more complicated	9 years ago
Alex Dik	5aeccc2d2c	Reduce fieldController redundancies [ci skip]	9 years ago
Alex Dik	bd86311e26	Refactor inplace-edit directory structure [ci skip]	9 years ago
Jens Ulferts	dbfcfb49b7	Revert "Merge pull request #3646 from furinvader/16364-fullscreen-edit" This reverts commit `cddeebbf43`, reversing changes made to `44ba79e900`.	9 years ago
Alex Dik	b422907206	Reduce fieldController redundancies [ci skip]	9 years ago
Alex Dik	0faeeff74c	Refactor inplace-edit directory structure [ci skip]	9 years ago
Oliver Günther	de96916dac	Minor corrections This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	7cd7697fab	Replace autogrow with angular-elastic angular-elastic provides us with an option to always insert an additional newline to provide smoother animations. This also changes animations to CSS rather than `jQuery.animate`.	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Oliver Günther	f589f565a6	Correct height when expanding inplace textareas with autogrow When using `.-autogrow` on textareas in inplace edit (e.g., description), the height is not correctly set as the selector is not visible. Only when starting to EDIT the textarea, the changes are being picked up and height is set correctly. This commit thus provides a second event listener to `focusin` events that cause the textareas to resize properly.	9 years ago
Henriette Dinger	01d47ea851	Editable comment field This provides the basic functionality to deliver a comment field in the in-place editing style. Adds the `autogrow` plugin This still breaks a number of features currently, such as formatted previewing.	9 years ago
Jan Sandbrink	2c19f97345	centralize knowledge of WP autocomplete url - project information is not needed anymore - the endpoint format was fixed anyway (also accepted parameters)	9 years ago
Jan Sandbrink	cc844c1068	centralize knowledge of WP autocomplete url - project information is not needed anymore - the endpoint format was fixed anyway (also accepted parameters)	10 years ago
Mihail Maxacov	f270d40bfb	required and number validations	10 years ago
Mihail Maxacov	c8e76d8e45	change isBusy to direct binding without watchers	10 years ago
Mihail Maxacov	eadd52aa76	fix preview buttons not hidden	10 years ago
Mihail Maxacov	a537ad0df6	fix focus and lists	10 years ago
Mihail Maxacov	bd0b45696d	most fields display view	10 years ago

6 Commits (3ae36dfaece593d41a597f939e88fcb01348988f)