60 Commits (3ce6aaf070e4f2f5c1d302eb7ab1d8b5b6075b5f)

Author	SHA1	Message	Date
ulferts	5ea185ef66	Placeholder user project members (#8961) ... * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	7b31311713	Chore/rename timestamp on time entry (#8754) ... * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on	4 years ago
ulferts	ae2edad19b	Fix/copy project wiki notifications (#8777) ... * rename to convey applicability to all journal notifications * adapt journal completed job to handle wiki content * remove empty module * create wiki_content mail service * introduce copy/create service and contract for wiki pages * specify set attributes and create contract for wiki pages * copy the content attributes * use wiki page create service when copying wiki * introduce specifc service for copying wiki pages The contract disables checks for permissions on the wiki page. The copy_projects permission should suffice to copy everthing in a project * copy wiki pages top down to rewrite hierarchy * limit copied attachments to copied type	4 years ago
ulferts	5968c0b18a	Fix/replace custom i18n function (#8681) ... * replace custom i18n function calls * remove custom i18n method	4 years ago
ulferts	27b41a313c	replace custom i18n function in views	4 years ago
Oliver Günther	73352fe2d4	[34257] Allow localized input of overridden costs (#8656) ... * [34257] Allow localized input of overridden costs https://community.openproject.com/wp/34257 * Add placeholder to cost-unit-subform * Remove duplicate code from budgets extraction	4 years ago
ulferts	9b8a690cf5	Fix/non integer material budget items (#8646) ... * fix label for budget heading * remove outdated todo * fix fractional number below 1 for material units * extract method to avoid duplicate code * fix some i18n key structure for costs	4 years ago
Oliver Günther	47a07210d5	[33383] Treat number fields as text fields to allow localized input ... The budget parsing use localized numbers to compute the budget costs for the given units. For comma-delimited locales like German, this will break the computation for any decimal value, as the frontend number always sends dot-delimited values in Chrome due to Bug OP#32232 This PR treats the number fields like text fields with a hint on how to enter the correct value. This matches the "rate" field that does this already and should be the expected behavior, so users can use their language for numbers. https://community.openproject.com/wp/33383	4 years ago
Aleix Suau	4a334f0b78	Avoid disabled hidden inputs that generates the not focusable error	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling ... Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557) ... * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
ulferts	655f021b92	add derived dates to the work package resource ... The derived dates are the minimum/maximum of the descendant's dates. As long as the work package is scheduled automatically, the derived and non derived dates should be equal althoug the derived dates will be null in case non descendants exists. But if the user decides to activate manual scheduling the dates can deviate. The derived dates can then help to display the deviation to the user. This commit however does not alter the front end. The dates are eager loaded on the work package index commit using the same mechanims already introduced for spent time. The patched cost attributes, which are also eager loaded, are now eager loaded in the core as well so the patch is removed. As those attributes are now part of the core (although in a different module) it no longer makes sense to rely on patching for this.	4 years ago
Oliver Günther	623f8c772e	Move module assets to frontend	4 years ago
Henriette Darge	8b3bae8bbb	Remove wrong/outdated usage of "box" class and adapt HTML structure to LSG at these places	4 years ago
Henriette Darge	b3dd61946e	[32880] Display scheduling mode in work package view (full, split & table) (#8410) ... * Show icon next to start date depending on the scheduling mode * Show modal when opening date edit fields which shall be able to change the dates and the scheduling mode * Introduce flatpickr as a datepicker for the modal of the dateEditField * Use new datepicker within opDatePickerComponent * Reuse existing Datepicker class for better code abstraction * Set dates only when Instance is ready * Let augmentedDatePicker use generic DatePicker class, too. * Remove jQuery UI datepicker specific styles as they do not apply any more. * Use localized strings in new datepicker * Close datepicker only on click outside * Allow single and multi selection of dates and save changes * Update schedulingMode button correctly && remove unused method * Show combined field for start and end date within the WP single view * Show normal datepicker for most date fields and the modal with the extended datepicker only for startDate * Add datepicker edit field and component helper * Correctly save start and end date * Show correct default value for dateEditFields && Adapt some tests to new datepicker and combined date field * Fix date editor spec * Fix expecting datepicker for start/due date as milestone * Prevent overflow on body by using modal-portal class && make edit input for combinedDates visible again to show something in a create form * Only output one debounced change event for op datepicker * Show combined datepickerModal for dueDate in table, too && save correct scheduling value * Hide modal if the showing component gets destroyed * Correctly check for closed datepicker * Add spec for toggling scheduling mode * Fix setting dates to modal * Avoid too many (unnecessary) close events and use keydown instead * Fix date setting and add custom field date spec * Change layout of combined date picker modal * Switch from a range date picker to a multiple selection in order to be able to set only start or due date && Highlight date field that is changed next * Highlight range manually * Highlight dueDate initially when the user clicked on the due date field && handle special case that one of the values is not set yet. In this case we don't want to keep both values but only the newly clicked. * Move helper functions to own class && Improve the range selection to be able highlight ranges over multiple months && Prevent that a start date > due date can be chosen by setting minDate and maxDate * Adapt test to new way of changing the scheduling mode * Handle case that the user clicks on a already selected date and thus deselects it Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	45250f94bf	fix reference to method	5 years ago
bsatarnejad	e1a11a4839	make a whole container	5 years ago
bsatarnejad	c4c2b6a2f9	add space below each user history rate box	5 years ago
ulferts	64d0f57d85	Feature/aggregated activities (#8221) ... * use cte for aggregated journal * Revert "use cte for aggregated journal" This reverts commit 5fedefefdd. * add another subselect that could later on be provided from the outside * allow passing a nukleous sql to aggregated journals * wip - using aggregated journal for activity * new sql for aggregated journals * start implementing new aggregated query * additional documentation * consolidate activity functionality * simplify by turing into instance methods * move activity fetcher out of redmine * remove verb verification made obsolete Without catchall routes, the dispatching handles it * remove duplicate authorize check * refactor activities controller * refactory activity fetcher * cache avatar file * sort choosable events * remove legacy spec covered by contemporary * speed up aggregated journals via CTE * instance var might never have been set * ensure the event_types are always transmitted * correctly reset the avatar cache * fix avatar fetcher expectation regarding wiki pages * adapt spec [ci skip]	5 years ago
Oliver Günther	812cbf183c	Allow filters to define multiple LDAP synchronized groups	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Oliver Günther	6ded4e6852	Add cron job functionality to delayed_job	5 years ago
ulferts	d44525022b	apply currency_number transformation to hidden field	5 years ago
Oliver Günther	5193dcf7cd	[32822] Fix parsing budget with non-english locale ... https://community.openproject.com/wp/32822	5 years ago
Oliver Günther	c07e44954c	[32760] Use redirect_back url to go to correct module ... https://community.openproject.com/wp/32760	5 years ago
Oliver Günther	54e30cad7d	[32664] Fix trying to parse currency string in costs value ... https://community.openproject.com/wp/32664	5 years ago
ulferts	4dad6a4485	remove attachment unsuccessfully saved warning method ... Attachments are now always uploaded up front, uncontainered, and after a successful upload and save of the intended container, assigned to the container.	5 years ago
ulferts	399e8c3ed9	rename according to zeitwerk	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
ulferts	379f0ed72c	remove currency separator duplicity ... I18n already defines keys for number delimitors and separators. They are also to be used for currencies.	5 years ago
Henriette Dinger	3ebe7f4d52	Add missing breadcrumbs and remove unnecessary ones	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	2e51467913	Hide some buttons on mobile and correct HTML structure	5 years ago
Henriette Dinger	24d019a84e	Correct DOM structur for some toolbars && let the editable toolbars span the complete width on focus via JS and not CSS only	5 years ago
Oliver Günther	616828c0e2	Fix styling of budget buttons ... https://community.openproject.com/wp/31194	5 years ago
Wieland Lindenthal	ca8fcd6f24	Allow vertical overflow for cost object forms	5 years ago
Oliver Günther	b97150f8ff	Correct float formatting in reporting and budgets	5 years ago
Oliver Günther	8e32895ce3	Remove legacy frontend	5 years ago
Oliver Günther	5167f4fca8	Replace costs-subforms with augment service	5 years ago
Oliver Günther	2b4fa38439	[29718] Fix costlog link ... https://community.openproject.com/wp/29718	6 years ago
Oliver Günther	0a9ad12ad5	Replace remote-field-updater	6 years ago
Henriette Dinger	95c34a3fdb	Add missing required classes, correct rendering of „save as“ form on reporting and fix broken test	6 years ago
Inga Mai	8d198202c4	Adding all missing -required classes	6 years ago
Oliver Günther	81c7b40b7e	[29595] Remove cost_entries page when cost reporting is disabled ... This page was broken for some time and is never hit unless cost reporting is disabled, but costs is enabled. https://community.openproject.com/wp/29595	6 years ago
Jens Ulferts	30e398a35f	explicitly cast to arel instead of relying on delegation	6 years ago
Inga Mai	edc3bcc613	Remaining Labels removed; titles for all buttons instead	6 years ago
Inga Mai	de20d43ee3	Delete and edit icon texts in tables removed	6 years ago
Oliver Günther	f86abae9eb	Enforce Arel.sql for string order, pluck	6 years ago
Henriette Dinger	552bc13f13	Add missing classes (& styles) for correct styling on MyPage, Repository, Global Roles, and Admin section	6 years ago