openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973 ) * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Markus Kahl	0a3eb86bd8	show correct number of active users Builtin users must be not counted. Use method from Enterprise module so we only have this logic in one place.	5 years ago
ulferts	5869966f12	relay available_custom_fields call to cacheable class method That way, we avoid n+1 queries for the available custom field especially in scenarios like schemas and api collections where a set of models is queried for their custom fields	5 years ago
Oliver Günther	c791c01628	Prepare for core integration	6 years ago
Jens Ulferts	3897b9f37e	fix merge errors	6 years ago
Markus Kahl	54feb0a812	more user limit specs	6 years ago
Inga Mai	9659285be3	AngularJS in 'mail-notifications.html.erb' replaced by Angular component (#6338 ) * AngularJS in 'mail-notifications.html.erb' replaced by new Angular component 'show-section-dropdown.component.ts'	7 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	3ac4374866	FactoryGirl => FactoryBot (opf/openproject#6304 )	7 years ago
Jens Ulferts	3b850bc833	speedup view specs by stubbed models	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	26dff6132e	Remove default route (#6137 ) * Remove default route * Fix and clean legacy specs * Fix specs * Fix missing ID in request parameters in view specs https://stackoverflow.com/a/21789313 * Fix more invalid routes in specs * Pass parameter to omniauth spec * Add required ID parameter to types controller * Fix invalid omniauth URL * Fix project_id params in repository controller spec * Fix missing project id in projects controller spec * Fix missing params and failure url for omniauth * Fix invalid route name * Temporarily skip broken specs on dev [ci skip]	7 years ago
Oliver Günther	30b471d0ee	Fix invitation wording for resend invitation (#6029 ) On initial registration, no invitation is sent, thus the 'resend' invitation button is confusing. [ci skip]	7 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Markus Kahl	ba20bfab77	updated spec - users may now always be re-invited even when already active	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Markus Kahl	a9382e8802	resend invitation feature	9 years ago
Markus Kahl	7c0a6855e8	made user edit view spec more robust; fixed typos	9 years ago
Jan Sandbrink	c03e1cfee9	replace deprecated :response calls by :rendered	9 years ago
Alex Coles	59b05568e9	Remove deprecated Relation#all in views Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Markus Kahl	c3fa89e5db	disable password choice config	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Markus Kahl	09e8a972f2	disable password choice config	10 years ago
Alex Coles	879fcd49f6	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.6 with the following command: transpec -f * 66 conversions from: it { should ... } to: it { is_expected.to ... } * 53 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 20 conversions from: == expected to: eq(expected) * 19 conversions from: obj.should to: expect(obj).to * 7 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 7 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 7 conversions from: its(:attr) { } to: describe '#attr' do subject { super().attr }; it { } end * 5 conversions from: obj.should_not to: expect(obj).not_to * 4 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 3 conversions from: be_true to: be_truthy * 2 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 2 conversions from: its([:key]) { } to: describe '[:key]' do subject { super()[:key] }; it { } end * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: be_false to: be_falsey * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 1 conversion from: it { should_not ... } to: it { is_expected.not_to ... } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Markus Kahl	ee121560d3	hide auth sources if password login is disabled and also don't show the no-login warning for users with external auth sources	10 years ago
Markus Kahl	a0dc083194	show note when change of password is not supported	10 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { \|example\| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Jens Ulferts	f8e635fca0	rubocopify spec	11 years ago
Jens Ulferts	42691d600e	clarifying spec's intent	11 years ago
Markus Kahl	894a0411cd	fixed copyright	11 years ago
Markus Kahl	7dd5ca190d	don't use url but path for form action URLs are potentially broken (wrong scheme).	11 years ago
Alex Coles	5cdc438c52	Convert specs to RSpec 2.99.0.beta2 syntax with Transpec This conversion is done by Transpec 1.10.4 with the following command: transpec * 402 conversions from: it { should ... } to: it { is_expected.to ... } * 67 conversions from: be_true to: be_truthy * 55 conversions from: be_false to: be_falsey * 35 conversions from: it { should_not ... } to: it { is_expected.not_to ... } * 20 conversions from: == expected to: eq(expected) * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: =~ /pattern/ to: match(/pattern/) * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 1 conversion from: after { example } to: after { \|example\| example } * 1 conversion from: pending to: skip	11 years ago
Alex Coles	a2679b5d35	Convert specs to RSpec 2.14.8 syntax with Transpec This conversion is done by Transpec 1.10.4 with the following command: transpec . * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 3 conversions from: obj.should to: expect(obj).to * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: obj.should_not to: expect(obj).not_to * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message)	11 years ago
Michael Frister	183fb9f408	User edit: Show external authentication provider	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Sebastian Schuster	388af1ea7b	Rewrote a test to a spec and relaxed another test to work with the profile visibility plugin	11 years ago

41 Commits (3e5f0eb935aeaebefd392d9306719d85631ed4dc)