openproject

Commit Graph

Author	SHA1	Message	Date
Benjamin Bädorf	44294ede04	User custom fields in the invite user modal (#9220 ) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Removed projects routes and ruby template * Removed projects routes and dynamic forms from Projects * Revert "Provide DynamicFieldsService in root so it can be used independently" This reverts commit `ab56f3c56f`. * Provide DynamicFieldsService in root so it can be used independently * TODO: test ProjectsComponent * Code climate fixes (remove TODOs) * Default OpFormFieldComponent.inlineLabel to false * Dynamic components tests xkipped * Typing improvements * DynamicFormComponent working as a FormControl * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fixes * noWrapLabel default to false * Started adding user custom fields to the ium * Import the dynamic-forms module into the common module * Refactor edit fields to avoid circular dependencies in the dynamic forms * Using DynamicFormsModule in OpenprojectInviteUserModalModule * Add formly form * Update principal name filter * Dynamic form field is rendering * Handling multi-values (also as links) and passwords * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Moved to FormGroup input for dynamic form * Custom field happy path is done * Add explanatory comment to payload structure transformation * add op-form class to ium steps * Add shrinkwrap back in * Fix test, fix dynamic form resource path * gimme a shirnkwrap * Remove failing tests * Remove another failing test * Remove more failing specs * Fix double loading of principals * Add custom field spec * Fix spec * Reset shrinkwrap * Forbid Factory.build(:user, member_in_project) If you use the trait member_in_project(s), the user is implicitly saved to create the member. This is very confusing if trying to use required custom fields, as this will fail with the Member#user_id foreign key being nil, as the user cannot be saved. Instead, raise an error when trying to use this factory trait * Change additional spec factory Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Aleix Suau	44cf9e0c5e	Epic/placeholder users frontend (#8977 ) * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Open invite user modal from user selection * Remove console and debugger calls * Opening modal from CreateAutocompleterComponent * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Refactor/op modal (#8978) * Initial modal refactoring * Updated modal imports * More modal module imports * Fix one more import * Fixed some styles * Fixed failing modal specs * Fix more spec selectors * Fix more specs * Updated backend modals * Improved code style * Fix export modal styles * Fix wiki export modal * Fix more specs * Fix webhooks modal * Added loading indicator back into modals * Fixed wp preview modal * InviteUserButtonComponent in * InviteUserButtonComponent in * InviteUserButtonComponent in MultiSelectEditFieldComponent and SelectEditFieldComponent * Remove extraneous module * Add Dragula import * Remove empty spec * Fix option-list component * Remove group creation from invite user modal * Write feature spec * Fix TS errors * Add Placeholder and Group apis to the frontend * Better api typing * Remove unnecessary interface * Remove group creation call Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu>	4 years ago
ulferts	9edf745085	Fix/group mention links (#9036 ) * turn group mentioning into link * add profile button to group edit page * Include built ckeditor Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Benjamin Bädorf	7c36920ab8	Only set styling on code-block when editing (#8880 ) * Only set styling on code-block when editing * Only overflow code blocks in view mode * Update code-block styles to wrap text in edit mode * Fixed language indicator for code blocks * Fix spec class	4 years ago
ulferts	df65b83d81	attempt to stabilize flickering spec	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844 ) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit `0d27d28137`. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	8c554ba0c9	Feature/mentions rewrite (#8853 ) * update ckeditor * output user-mention link on mention tag * spec revisiting a user mention * amend mention recipients by tag * handle wp mentions	4 years ago
Benjamin Bädorf	5f45ee07ab	Move development docker-compose file to the main directory (#8798 ) * Move development docker-compose file to the main directory This requires us to move some other files around, like the pullpreview and example docker-compose file for production setups. This commit also does some housekeeping, like removing some old files and deduping configuration. * Updated to selenium grid * Fix in-Docker Selenium tests The Selenium tests now run inside a Docker Chrome Container. Backwards compatability with non-docker setups is not guaranteed, though it should not be hard to implement with a couple of small fixes. * Updated docker development documentation * Improved test timings, changed the documentation * Updated docker testing again * Run npm in the frontend directory * Really run npm in the frontend directory * Also run npm in frontend when setting up travis cache * Change directory for one command only * Change default test driver name * CI test change fixes * Fixed syntax error * Added dev check * Trying to fix firefox resizing * Trying to get tests running * Stop resizing firefox * Fixed apple icon spec * fix host in url helpers for omniauth spec * Fix omniauth specs * Fix docs * Small fixes to docker tests * Added package.json back in * Change env variables Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
Oliver Günther	e2db9e2063	Use firefox headless on the code block	4 years ago
Oliver Günther	8d2da3f6d8	[33648] Add value macros for referencing label and values of project and work packages (#8578 ) * Add macros for attribute values and labels of HAL resources * Implement label macro with help text For that, we need to move help texts out of the work package module. The fields module appears to be best suited for it. * Load the current project for project attributes * Don't render things that only matter in writable situations Such as the project dropdown indicator or the spent time modal * Throw if ID was not correctly provided * Bootstrap the inserted html of a custom text * Expand errors if user cannot see/load expected macro resource * Add text formatting spec * Add feature spec to test both loadable and failing macros * Reference only subjects in the current project if not referenced by id * Extend documentation * Refactor loading switch * Add macro for work package quickinfo (previously ## and ###) * Extend spec to double and triple hash macros * Ensure we allow numeric strings as IDs Was testing for isNumber, which only checks for actual number types * Fix showing the placeholder when not empty * Add error span to the quickinfo macro * Better styling and title help for macros	4 years ago
Oliver Günther	97858b7343	Restrict table width by break-all words This ensures that if you forced a cell width, it breaks apart all words to ensure the width does not increase. https://community.openproject.com/wp/33524	4 years ago
Oliver Günther	d4a7b3e5da	Fix styles on table and figure	4 years ago
Oliver Günther	eb31d5d3b7	Add table styles to CKEditor with sanitization	4 years ago
Oliver Günther	36b3a90648	Add table styles to CKEditor with sanitization	5 years ago
Oliver Günther	686d48c8f4	[32983] Ensure wp-embedded-table-entry does not get bootstrapped twice The embedded table entry was bootstrapped after the `macro.embedded-table` was bootstrapped, causing the table to be re-initialized with empty queryProps, thus loading the defaults The test did not work correctly, since the applied filter was not applied, but the test still succeeded since the work package was there. I added a negative test for a filtered-out value https://community.openproject.com/wp/32983	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Oliver Günther	a2b7fbb395	Fix double newline no longer being contained	5 years ago
Oliver Günther	afeb1a42af	[31859] Save date with confirm button when empty https://community.openproject.com/wp/31859	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	6f92035ccc	Rename EditField classes used for tests and remove WorkPackage reference	5 years ago
Oliver Günther	59bc26a7d4	Fix broken tests due to chromedriver update	5 years ago
ulferts	3f102dd802	show error message for existing macro occurrences	5 years ago
Oliver Günther	7d9a084980	Bump CKEditor to v12.3.1	5 years ago
Oliver Günther	997e410463	Fix autocompletion of groups	6 years ago
Oliver Günther	c0d9bda246	[29742] Fix spaces in CKEditor links https://community.openproject.com/wp/29742	6 years ago
Oliver Günther	c739edb457	Fix mentions to allow #, ##, ###	6 years ago
Oliver Günther	980ba2533d	[29457] Fix escaping of manual table rules We handle our own HTML table implementation instead of turndown's, which doesn't exhibit the decoding of HTML entities. https://github.com/opf/commonmark-ckeditor-build/pull/36 https://community.openproject.com/wp/29457	6 years ago
Wieland Lindenthal	4970471739	Quickly filter by text within normal filters section without showing any operator (#6960 ) * Add quick filter by text * Debounce search filter input [ci skip]	6 years ago
Oliver Günther	586387de51	[28906] Double-encode entities for turndown Turndown uses the raw text value to further output markdown, which will result in escaped input like `<node foo="bar" />` to be output like `<node foo="bar" />` and in turn treated as inline HTML. https://community.openproject.com/wp/28906	6 years ago
Oliver Günther	165475cf2b	[28765] Fix paragraphs in lists in CKEditor https://community.openproject.com/wp/28765	6 years ago
Jens Ulferts	c65b59374f	bump ckeditor to 11.1.1	6 years ago
Oliver Günther	a5b0764638	Revert "bump ckeditor to 11.1.1"	6 years ago
Jens Ulferts	e1ebb4b471	bump ckeditor to 11.1.1	6 years ago
Oliver Günther	01b2655a58	[28609] Fix double newline when editing content with code block https://community.openproject.com/wp/28609/	6 years ago
Oliver Günther	a687ca5ec7	[28177] Fix   breaking markdown formatting in turndown Turndown doesn't replace   before syntax identifiers such as `<strong>foobar </strong>` will result in `foobar ` (with the space being `\u00A0`. We can fix this by replacing all   by CKEeditor beforehand, knowingly modifying the behavior of the spaces. Bug report at turndown: https://github.com/domchristie/turndown/issues/250	6 years ago
Oliver Günther	f39acbce2b	[28350] Fix bound element to pre block to avoid recursive insertion When the outer pre element is not bound to the model code block, it is not consumed for insertion and is thus treated as a container node where we continue to insert _within_. This results in multiple code blocks being nested into one another. https://community.openproject.com/wp/28350	6 years ago
Oliver Günther	d77b3b7d55	[28207] Disable wysiwyg macros in work packages https://community.openproject.com/wp/28207	6 years ago
Oliver Günther	2c98eda4f2	[28167] Allow embedded table macros in WP description This PR renders macros within WP descriptions. This has one drastic side effect when embedded tables are rendered: 1. If the work package (lets asumme that ID #1) is returned in the embedded table results, it is updated in the state/cache service. 2. The updated entry in the cache service results in refreshing the display fields 3. The display field will re-render the embedded table 4. Results are being re-fetched. This results in recursion into step 1 We can avoid that by assumming identical sources returned from the backend to be identical work packages and in turn not updating those. It's a hack, however. https://community.openproject.com/wp/28167	6 years ago
Jens Ulferts	abda9056cd	add attachment on new resource via rails form	6 years ago
Oliver Günther	062f9019d1	[28124] Avoid markdown table output GFM table extension breaks without header rows, and also when newline is contained within a cell. Instead, just output a html table https://community.openproject.com/wp/28124	6 years ago
Oliver Günther	d7e8a8145f	[28120] Set location.href when outside wp-base application When we're not within our routed application, state transitions have no effect other than alterting the URL bar. Instead, move users to the requested page. https://community.openproject.com/wp/28120	6 years ago
Oliver Günther	d4e4d40ae7	[28110] Address issues on wp table configuration modal https://community.openproject.com/wp/28110	6 years ago
Wieland Lindenthal	388afa6aa0	Wrap all macros into one dropdown, getting rid of the icons and being more explanatory.	6 years ago
Wieland Lindenthal	f9ec23a462	Update macro placeholder after changing it's configuration	6 years ago
Oliver Günther	4f859f4ae1	[28041] Allow CKEditor preview functionality to expand macro components Even while we're using AOT, we can dynamically expand known components that are meant for embedding (such as macros) to be dynamically bootstrapped even on dynamic content such as previews. But, we need a listing of what these components and their selectors are. Very similar to how dynamic bootstraping works. To this end, I have refactored the dynamic bootstrapping into a static lookup class. This class can also output all components that are allowed for embedding into dynamic contents. The preview plugin is extended to use the new preview service that bootstraps components within the view. https://community.openproject.com/wp/28041	6 years ago
Wieland Lindenthal	e58cd194d8	Tell Rubocop to ignore FrozenStringLiteralComment	6 years ago

1 2

63 Commits (3f32a43ee0fe66a1c7e5ddab5643d6b359a35c9b)