openproject

Commit Graph

Author	SHA1	Message	Date
Aleix Suau	459bbcb80a	Feature/32616 show children in row on collapsed parents (#8800 ) * Showing milestones on collapsed project rows * Showing milestone's labels on hover * Milestones adapting to zoom changes + refactor * Refactor to make it applicable to other wp types * Calculate timeline width including wps shown in collapsed rows * Tests * Custom labels for duplicated cells * Custom labels for duplicated cells * Hide empty labels on hover * All tests passing (switched to isMilestone function) * Make up * Showing milestones on collapsed project rows * Showing milestone's labels on hover * Milestones adapting to zoom changes + refactor * Refactor to make it applicable to other wp types * Calculate timeline width including wps shown in collapsed rows * Tests * Custom labels for duplicated cells * Custom labels for duplicated cells * Hide empty labels on hover * All tests passing (switched to isMilestone function) * Make up * Refactor fix * Empty line at the end of the file * Empty line at the end of the file * Hide non hover labels on group rows * Only include header cells for wp with date or startDate * Add group header cells into Autozoom width calculations * Showing labels on group headers * LabelRight's padding reduced * group-row class name changed to modifier -group-row * withCustomLabels moved to WorkPackageCellLabels class * withCustomLabels renamed to withAlternativeLabels * isDuplicatedCell and withAlternativeLabels moved into RenderInfo * Typings improvements * Duplicated code extracted to getWorkPackagesToCalculateTimelineWidthFrom * Conditional flag moved out of manageCollapsedGroupHeaderCells * manageCollapsedGroupHeaderCells setup extracted to a method * manageCollapsedGroupHeaderCells setup extracted to a method * manageCollapsedGroupHeaderCells setup extracted to a method * Group logic extrated to groupTypeFromIdentifier and groupIdFromIdentifier methods * Remove 'project' hardcoded reference from createCollapsedGroupHeaderCells * Common pipes grouped in a getter * Codeclimate fixes	4 years ago
Benjamin Bädorf	5f45ee07ab	Move development docker-compose file to the main directory (#8798 ) * Move development docker-compose file to the main directory This requires us to move some other files around, like the pullpreview and example docker-compose file for production setups. This commit also does some housekeeping, like removing some old files and deduping configuration. * Updated to selenium grid * Fix in-Docker Selenium tests The Selenium tests now run inside a Docker Chrome Container. Backwards compatability with non-docker setups is not guaranteed, though it should not be hard to implement with a couple of small fixes. * Updated docker development documentation * Improved test timings, changed the documentation * Updated docker testing again * Run npm in the frontend directory * Really run npm in the frontend directory * Also run npm in frontend when setting up travis cache * Change directory for one command only * Change default test driver name * CI test change fixes * Fixed syntax error * Added dev check * Trying to fix firefox resizing * Trying to get tests running * Stop resizing firefox * Fixed apple icon spec * fix host in url helpers for omniauth spec * Fix omniauth specs * Fix docs * Small fixes to docker tests * Added package.json back in * Change env variables Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
ulferts	f511f8d4f5	set default role when copying project as non admin (#8824 )	4 years ago
Wieland Lindenthal	c919da0550	Fix: #35132 Activity broken for wiki pages with slashes in title (#8823 )	4 years ago
ulferts	5a7176e6e1	Fix/search for projects (#8815 ) * fix searching for projects * only provide search options active in the project	4 years ago
Markus Kahl	a8f04ae044	make sure API settings controller is loaded by declaring the API acronym (#8792 )	4 years ago
ulferts	0e6072aefa	fix accessibility spec expectations	4 years ago
ulferts	a842f44bda	[22048] Destroy journals after destroying journalized * clenaup journal data upon aaj model removal * remove unused methods * simplify aaj options handling * delete orphaned journaled data via migration Existing instances might already have journal data for which the journal itself is deleted. This migration removes them.	4 years ago
ulferts	bf89e934b3	set the default value for newly build custom values Most of the time, the getter #custom_field_values is used with unbeknown to the caller will build custom values for not covered custom values. This method always assigned nil to the value of the newly build custom value when it should have used the default value. Once that is fixed, all models including acts_as_customizable will again have set the default values for custom fields correctly. This is true regardless of wether the custom value is added before or after the creation of the model. Only for work_packages is the additional method #set_default_values! required as the availble_custom_field might change during a request upon a switch in project and/or type.	4 years ago
ulferts	8dfc5e8803	fix touching the customizable on removing custom_values Before the commit, the existing custom_values where attempted to be reused but there was no deterministic behaviour with which reusing them was attempted. Additionally, the existing values where always changed (or they would receive the current value again) whenever values where provided, regardless of whether those values actually changes. There was no explicit flag that a value was removed. This poses a couple of problems: * Even if no new values where provided the order of the custom values as stored in the db might change leading to journal entries that where not actually caused by the user. * If values where only removed, due to the missing explicit removal flag, it became luck whether an existing custom value was actually changed. Only then would the customized object be touched leading to an update of cached fragments, i.e. representers. * Because the values where updated all the time, the performance would suffer. * Removed custom values where removed right away and not only after save. This commit introduces an explicit flag for removal and does not alter existing custom values. This might have the drawback of creating a custom value even when a value, chosen to be removed by the user, could be reused but this should be negligible. It also has the drawback of introducing a flag to be maintained.	4 years ago
Oliver Günther	76823ca581	[34446] Fix direct upload with backend-generated resources https://community.openproject.com/wp/34446	4 years ago
Oliver Günther	d29266f5bd	[34291] Use placeholder for new resource dates https://community.openproject.com/wp/34291	4 years ago
ulferts	8969afe617	close time entry modal on enter (#8653 ) * close time entry modal on enter As the time entry is saved anyway once the user saves the form, e.g. by pressing enter in the hours field, we can close the whole modal along with it. The "Save" and "Cancel" buttons do not make sense then anymore * attempt to stabilize flickering spec * fix ruby 2.7.1 hash parameter deprecations	4 years ago
Oliver Günther	6881f3d347	[33696] Retain autologin cookied request in session https://community.openproject.com/wp/33696	4 years ago
Oliver Günther	2e2f520130	Avoid updating the just created user to retain id information We need to track whether the user was just created to show a different message. For this, avoid any calls that save the user _after_ RegisterUserService.	4 years ago
Oliver Günther	5969d8239b	Correctly continue activation after registration error	4 years ago
Oliver Günther	841e1149c2	Don't show an error when the user just registered In case the user still needs to activate e.g., via mail, it should not be shown an error message, but instead the success message from the registration service	4 years ago
ulferts	245a7ddfcf	Fix/duplicate work packages across pages (#8651 ) * deprecated method * remove apparently unused methods * append id desc sorting to work packages * enforce sorting is applied in query results * ensure deterministic order in base query	4 years ago
Oliver Günther	506ad2e4eb	Use slide toggle on the project boolean filter (#8643 ) * Allow the slide toggle to be used on project as well * Add slide toggle to styleguide * Change spec to test slide toggle filter * Rename filterValue to active	4 years ago
Oliver Günther	a91ab2e686	[33766] Show errors when CF is invalid in project form https://community.openproject.com/wp/33766	4 years ago
Oliver Günther	1774f3fc45	Only filter for active projects	4 years ago
ulferts	a9dfb35150	avoid modifying frozen string from nil	4 years ago
Oliver Günther	3a0020f17a	Add title to explain what the button does and disable if no results	4 years ago
Oliver Günther	2e62fb8b22	Remove matrix in favor of multiselect	4 years ago
Oliver Günther	213153721e	Ensure cache is cleared for settings	4 years ago
ulferts	2562bd6475	Fix/bump gems (#8613 ) * bump em-http-request * bump warden * hopefully stabilize flickering spec	4 years ago
Oliver Günther	4aad0c8b72	Generate URL params for gantt view and insert projects	4 years ago
ulferts	05c9e3fca6	Feature/default dates for children (#8605 ) * fix start_date expectation based on setting * extract methods * set dates of parent work package * pass parent on form request * have initial dates displayed correctly in wp create form	4 years ago
Oliver Günther	becefba1c4	Allow template to set the default advanced settings once selected Previously, advanced settings were simply hidden when project templates were selected. This however prohibits setting/overriding certain attributes, such as the parent project. This commit results in: - Selecting a template will reload the page - When advanced settings were opened, confirms from the user that the page should be reloaded - The template is being applied to the new project to ensure the attributes are being used - The user can then override or delete whatever params she wnats	4 years ago
Oliver Günther	e2db9e2063	Use firefox headless on the code block	4 years ago
Behrokh Satarnejad	c92c750625	[30242] Extend work package autocompleter with more useful information (#8554 ) * WP auto completer changes in global search box * resolve the travis check errors	4 years ago
Oliver Günther	8d2da3f6d8	[33648] Add value macros for referencing label and values of project and work packages (#8578 ) * Add macros for attribute values and labels of HAL resources * Implement label macro with help text For that, we need to move help texts out of the work package module. The fields module appears to be best suited for it. * Load the current project for project attributes * Don't render things that only matter in writable situations Such as the project dropdown indicator or the spent time modal * Throw if ID was not correctly provided * Bootstrap the inserted html of a custom text * Expand errors if user cannot see/load expected macro resource * Add text formatting spec * Add feature spec to test both loadable and failing macros * Reference only subjects in the current project if not referenced by id * Extend documentation * Refactor loading switch * Add macro for work package quickinfo (previously ## and ###) * Extend spec to double and triple hash macros * Ensure we allow numeric strings as IDs Was testing for isNumber, which only checks for actual number types * Fix showing the placeholder when not empty * Add error span to the quickinfo macro * Better styling and title help for macros	4 years ago
Oliver Günther	73a1d29e95	[24760] Enable ckeditor image resize plugin https://community.openproject.com/wp/24760	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580 ) * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
Oliver Günther	c369a71f4d	Allow project help texts on the rails form Renders help texts on a project core attributes and custom fields	4 years ago
Aleix Suau	5ea357c750	Bump CKEditor5 to v21 (#8570 ) * Bump to v21 * Upgraded to v21, really * Todolist spec fixed * Update fixes for child pages macro * Fix code block conversion Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557 ) * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
Oliver Günther	81bd0e34cd	[34025] Allow insecure localhost redirect_uri for OAuth This makes it easier for developing and debugging local OAuth applications https://community.openproject.com/wp/34025	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	3a3a48e267	journalize changes to the scheduling mode	4 years ago
Oliver Günther	ebfd3ce009	[32817] Disable advanced settings in project template (#8537 ) https://community.openproject.com/wp/32817	4 years ago
Oliver Günther	e3471ec69b	Fix calendar initialization and expected class names	4 years ago
Oliver Günther	a3acfdc9fc	Fix changes in upgrade of fullcalendar	4 years ago
Oliver Günther	dfa6bdb456	Extract all access of APIv3 calls into APIv3Service (#8521 ) * Move apiv3 path helper into apiv3 service * Refactor application to use apiv3 service * Allow caching responses within apiv3 endpoints through state cache * Fix reference to root service * Continue refactoring of DM services * Refactor version DM service * Refactor order service into v3 paths * Replace time entry dm and cache service * Replace QueryFormDmService with nested form resource * Replace QueryDmService with api paths * Replace ProjectDM and ProjectCacheService * Move PayloadDmService into static helper class * Replace NewsDmService with api paths * Replace MembershipDmService with api paths * Replace HelpTextDmService with api paths * Replace ConfigurationDmService with apiv3 path * Replace GridDmService with paths * Remove DmListParameters This is now Apiv3ListParameters type * Replace virtual BoardDmService with a virtual path Boards are not actually their own API resource, but a shallow wrapper over a grid resource. To reuse the same API service pattern, we can allow other resources other than HalResource and make the boards path just reference the grids paths. This allows to nicely use the `apiV3Service.boards.id(..).cache` patterns. * Refactor cacheState into single method * Make HalEditingService a v3 cache without loading ability * Replace usages of WorkPackageCacheService with api-integrated cache * Fix accessing grid subpath * Correctly use schema ensureLoaded before inserting into caches * Fix query not having an ID when updating * Fix npm tests after removal of wp cache * Readd missing path helper for APIv3 used from ckeditor * Correctly save query in widget * Fix watcher tab * Fix search path * Use a promise for the updateImmediately link of time entry * Make apiv3 independent cache services depend on the base cache service We had two cache services now, one base service for the apiv3, and the previous one. Both shared a lot of code, so we can unify them * Don't use multiState getter in schemaCache * Correct loading of schema * Correctly fill state with relations * Don't render comment until workPackage ready * Merge the initial loading observable to get error handling If we only return state.values$(), we never get the initial http observable and thus no error handling * Ensure we reload the default query from the current project if any * Use get() instead of stream * Load types correctly * Fix paths in enterprise token urls * Ensure take(1) in requireAndStream toPromise usage * Avoid duplicate StateCacheService definition * Only use project based query when there is no query.id yet There is no endpoint for /api/v3/projects/:projectIdentifier/queries/:id * Add isAvailable to filter out filters incorrectly added The search component always adds a subproject filter when in project scope. This filter however is only valid/existent in schemas if there is a subproject. This ensures we only try to access filters that are available * Refactor embedded table to reuse the loadQueryFromExisting method We had a few duplicate methods on how to look for a query with params basing on an existing (saved or unsaved) query. * Ensure filter schemas are inserted and checked before use * Better matcher for search spec * Ensure correct initialization of query states * Load attribute help text correctly	4 years ago
Oliver Günther	e80fcfbeac	[33901] Disable the button and disallow editing for scheduled parents https://community.openproject.com/wp/33901	4 years ago
Oliver Günther	3b78c25588	Fix spec expecting for start date to be moved back	4 years ago
ulferts	74fe191997	handle switching from manual to automatic	4 years ago
ulferts	4dc11b7240	handle switching from automatic to manual	4 years ago
ulferts	8805ea74c9	Use combined schema for combined date field Introduces a combined property schema for the combined date field of work packages. To that end, the way the schema is referenced is moved from calling the schema on the HalResource (i.e. work package) to fetching it from the SchemaCacheService. As the backend only provides generic Schema resources for all resources (e.g. TimeEntry, WorkPackage), the difference in behaviour (i.e. determining whether a property is editable is performed within a proxy handler. That handler is applied whenever a schema is fetched from the Service.	4 years ago
ulferts	fdcc89f810	allow freely setting the dates of manually scheduled child work packages	4 years ago

1 2 3 4 5 ...

1934 Commits (4020bb22cddfcf175c0c70cadf3b54ad3b22864d)