55 Commits (40225f27329100eb096bb04902f699da7d472179)

Author	SHA1	Message	Date
ulferts	6cda6ad4fd	enforces dependent project modules being active (#9311) ... Project modules, e.g. calendar can define dependencies, e.g. work packages. An error message is now displayed if a user enables a project module without the dependency being active in the project as well. Also fixes a serious bug in the Shared::ServiceContext module. Whenever a failing service result is returned, every change to the database is to be rolled back. This was not true when a model was provided since the changes where carried out within an inner transaction	4 years ago
ulferts	5cb227796c	Fix/hook service to openproject (#9214) ... * move specs from legacy * move Hook into OpenProject namespace * replace class variables	4 years ago
ulferts	ce5e06dde2	Fix/non matching pagination (#9202) ... * fix duplicates returned for wp list on multiple matching attachments/comments LEFT JOIN leads to potentially having multiple records returned if a search string is present in more than one attachment/comment. This is not a problem if we fetch work packages directly out of the query results but becomes problematic if only the id is fetched and then used to get the work packages by a subquery. * attachment filters no longer differentiate on tsv_where concatenation As EXISTS and NOT EXISTS is now used, the full string is always to be searched for so `and` concatenation is now always employed. * adapt spec Work packages that have no attachment at all are now also considered to match the filter if a "doesn`t contain" operator is used * less strict rspec rubocops for feature specs * cleanup code	4 years ago
ulferts	4bf7a26eb1	Capabilities API (#9083) ... * Capabilities API * introduce auxilliary capability model * capability model and query * render in sql * fix pagination * introduce sql representer * extract abstract sql representer class * remove yet unused methods * abstract sql collection representer * contract_actions as part of permissions * filter for capability id - used in GET * id filter validation * remove unused representer * remove unused wp representer * reuse renaming class * add spec for access control * add principal filter to capability * add context filter * extract capability sql into scope * admin gets all capabilities * require to have one filter set to keep performance bearable * consider active project modules for capabilities * limit capability based on principal visiblity and user state * rework capability to be tableless * spec not being allowed to see on request level * add actions to capability representer * add action api * extract sql index endpoint * remove unused class * prepare sending signaling error - not yet frontend exposed * extract show endpoint for sql rendered responses * use UNION for better performance * include navigation links on collections * remove string replacements * extract collection representer into hal sql module * no capabilities when blocked * remove commented out code	4 years ago
Oliver Günther	5f8a9a1868	[35157] Fix backlogs settings validations to disallow task = story (#9009) ... Refactors the settings controller into its own controller to allow checking the parameters before saving. Also removes a JS snippet that is no longer being executed since CSP is enforced. https://community.openproject.com/wp/35157	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937) ... * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
luz paz	e8c2928a12	Fix typo beeing->being in spec/ and modules/	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	7da9b119d0	remove unnecessary asset declaration	4 years ago
ulferts	5968c0b18a	Fix/replace custom i18n function (#8681) ... * replace custom i18n function calls * remove custom i18n method	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580) ... * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557) ... * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
Oliver Günther	fb58ef4e2a	Restore backlogs js assets	4 years ago
Oliver Günther	b38a5e7e83	Move backlogs styles into frontend ... Introduces a hidden div for stuff within an angular layout so that a frontend backlogs component can show stuff rendered by Rails after its css got loaded. This is a workaround until backlogs gets replaced by an actual frontend module, but still allows us to lazily load CSS from angular while rendering the rest in Rails	4 years ago
Henriette Darge	ebc3f6fe18	Prevent that the backend changes the order of filter attributes (sorted by id). Otherwise there is a visible change in the filter attributes in the frontend.	5 years ago
Henriette Darge	a61bcc7132	Rename cost reports module && Correct author_urls	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	bd4b59e321	replace backlogs page overriding by cell	5 years ago
ulferts	7cebf2254c	use extension files for representer patching	5 years ago
ulferts	399e8c3ed9	rename according to zeitwerk	5 years ago
ulferts	24c26702bb	factor in non leaf descendants when calculating the derived hours ... Before, only the leaves where taken into account to calcluate the derived estimated hours. With the hierarchy of Parent Child Grandchild Only times from "Grandchild" would be propagated to "Parent" with the ones on "Child" being ignored. We now factor in all descendants	5 years ago
Henriette Dinger	1907b8745c	Rename backlogs menu entry and move categories to the bottom	5 years ago
ulferts	b581828595	no backlogs settings menu if backlogs is disabled ... Relying on the permissions does not work here as backlogs_settings is tied to the edit_project permission which will always be present in the project (if the user has it).	5 years ago
Henriette Dinger	01111cf091	Add check whether the parent is one of the backlogs type before editing the version is forbidden	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	408661df72	Allow deeplinking in menu hierarchy: Show a parent node with changed url if the user is not allowed to see it, but at least one of the children.	5 years ago
Henriette Dinger	7167a85cb0	Fix specs by correcting the project settings paths and do some minor selector changes	5 years ago
Henriette Dinger	cbc530ca9d	Move project_settings_path to ApplicationHelper to be globally available and start adapting tests to new structure	5 years ago
Henriette Dinger	cb580268f8	Adapt backlogs plugin to new project settings menu structure	5 years ago
Henriette Dinger	a5811fc134	Remove obsolete property `visibility`	5 years ago
Oliver Günther	777f3141f7	Remove join in backlogs filter	5 years ago
ulferts	57131fa32b	continue adapting to altered project properties	5 years ago
Markus Kahl	cb6d28136d	allow editing estimated time for parents, show derived separately	5 years ago
Henriette Dinger	450cc3d63e	Create new admin menu node "Backlogs"	5 years ago
ulferts	64d3091636	replace acts_as_silent_list by acts_as_list touch_on_update: false	5 years ago
ulferts	8b0182adae	add module attributes to wp contract	6 years ago
ulferts	f1142c6654	move AccessControl into OpenProject namespace	6 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308) ... * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299) ... Feature/versions api update [ci skip]	6 years ago
Oliver Günther	33bc6466d5	Fix some sentry issues	6 years ago
Wieland Lindenthal	54a9d754d0	DRY up seed data references	6 years ago
Oliver Günther	8352af2bf7	Remove module versions	6 years ago
Wieland Lindenthal	a2d66aef07	Basic multi edition (Standard, BIM). ... Independent: - seed data - design - logo	6 years ago
Oliver Günther	451331a910	Invalidate session,s extract passwords flow into services	6 years ago
Henriette Dinger	be30a7c302	Remove accessibility switch from columns modal and project menu	6 years ago
Oliver Günther	2c466b99c6	Use the override core paths in the plugin	6 years ago
Oliver Günther	f86abae9eb	Enforce Arel.sql for string order, pluck	6 years ago
Oliver Günther	a94ba2431d	Make module engines refer to core version	6 years ago
Oliver Günther	ad43a7ea95	Prepare for core integration	6 years ago