openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	858aa95560	bump to next planned release	4 years ago
ulferts	30dcafe9f6	Bumped version to 11.0.1 [ci skip]	4 years ago
ulferts	261408aad2	use user locale for background job title	4 years ago
ulferts	a842f44bda	[22048] Destroy journals after destroying journalized * clenaup journal data upon aaj model removal * remove unused methods * simplify aaj options handling * delete orphaned journaled data via migration Existing instances might already have journal data for which the journal itself is deleted. This migration removes them.	4 years ago
Markus Kahl	e475ed99c1	bumped version to 11.1.0	4 years ago
ulferts	bf89e934b3	set the default value for newly build custom values Most of the time, the getter #custom_field_values is used with unbeknown to the caller will build custom values for not covered custom values. This method always assigned nil to the value of the newly build custom value when it should have used the default value. Once that is fixed, all models including acts_as_customizable will again have set the default values for custom fields correctly. This is true regardless of wether the custom value is added before or after the creation of the model. Only for work_packages is the additional method #set_default_values! required as the availble_custom_field might change during a request upon a switch in project and/or type.	4 years ago
ulferts	5968c0b18a	Fix/replace custom i18n function (#8681 ) * replace custom i18n function calls * remove custom i18n method	4 years ago
ulferts	05de0a6b3c	employ view_budgets permission check for budgets resource	4 years ago
ulferts	b179f89534	use view time_entries permission on spentTime schema	4 years ago
Oliver Günther	533d706f4f	Add a CORE_VERSION optional file This allows to set a different hash for core and product versions, such as on saas [ci skip]	4 years ago
ulferts	8dfc5e8803	fix touching the customizable on removing custom_values Before the commit, the existing custom_values where attempted to be reused but there was no deterministic behaviour with which reusing them was attempted. Additionally, the existing values where always changed (or they would receive the current value again) whenever values where provided, regardless of whether those values actually changes. There was no explicit flag that a value was removed. This poses a couple of problems: * Even if no new values where provided the order of the custom values as stored in the db might change leading to journal entries that where not actually caused by the user. * If values where only removed, due to the missing explicit removal flag, it became luck whether an existing custom value was actually changed. Only then would the customized object be touched leading to an update of cached fragments, i.e. representers. * Because the values where updated all the time, the performance would suffer. * Removed custom values where removed right away and not only after save. This commit introduces an explicit flag for removal and does not alter existing custom values. This might have the drawback of creating a custom value even when a value, chosen to be removed by the user, could be reused but this should be negligible. It also has the drawback of introducing a flag to be maintained.	4 years ago
Oliver Günther	76823ca581	[34446] Fix direct upload with backend-generated resources https://community.openproject.com/wp/34446	4 years ago
ulferts	8969afe617	close time entry modal on enter (#8653 ) * close time entry modal on enter As the time entry is saved anyway once the user saves the form, e.g. by pressing enter in the hours field, we can close the whole modal along with it. The "Save" and "Cancel" buttons do not make sense then anymore * attempt to stabilize flickering spec * fix ruby 2.7.1 hash parameter deprecations	4 years ago
ulferts	245a7ddfcf	Fix/duplicate work packages across pages (#8651 ) * deprecated method * remove apparently unused methods * append id desc sorting to work packages * enforce sorting is applied in query results * ensure deterministic order in base query	4 years ago
Oliver Günther	af4010b003	[33496] Don't try to lookup custom value by value Only for list types, the value will be an integer to look up by id, but instead use `CustomValue.new(...).typed_value` to use the formatter classes to correctly look up the value. https://community.openproject.com/wp/33496 [ci skip]	4 years ago
Markus Kahl	939f1d1df7	s3 hosts differ for pre-signed form uploads and downloads the latter include the region in the URL. This can possibly be changed so that we only need one host. Perhaps the region is optional in the carrierwave-generated remote download URLs.	4 years ago
Oliver Günther	90f2b5157a	Remove patches for document links generation and re-add meetings	4 years ago
Oliver Günther	46741d8579	[33869] Use `auth_source` link for parsing https://community.openproject.com/wp/33869	4 years ago
ulferts	50daff5062	Fix/archived projects via api (#8625 ) * minor code cleanup * allow access to archived projects via api for admins The visibility check will not work in this case as no permission is active on archived projects. We therefore need to return all projects for admins at least	4 years ago
ulferts	991bfd25ce	patch declarative-option to avoid barrage of deprecation warnings	4 years ago
ulferts	a9dfb35150	avoid modifying frozen string from nil	4 years ago
ulferts	6a5c22d73d	remove unused nested_set patch	4 years ago
ulferts	87471d9624	remove string_objects and replace deprecated URI.unescape	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
Oliver Günther	86b8ffc326	[30007] Allow users to enable CORS on APIv3 resources Allows a setting and configuration option to allow access to APIV3. Setting allows us to selectively enable this for cloud instances too. https://community.openproject.com/wp/30007	4 years ago
Oliver Günther	8d2da3f6d8	[33648] Add value macros for referencing label and values of project and work packages (#8578 ) * Add macros for attribute values and labels of HAL resources * Implement label macro with help text For that, we need to move help texts out of the work package module. The fields module appears to be best suited for it. * Load the current project for project attributes * Don't render things that only matter in writable situations Such as the project dropdown indicator or the spent time modal * Throw if ID was not correctly provided * Bootstrap the inserted html of a custom text * Expand errors if user cannot see/load expected macro resource * Add text formatting spec * Add feature spec to test both loadable and failing macros * Reference only subjects in the current project if not referenced by id * Extend documentation * Refactor loading switch * Add macro for work package quickinfo (previously ## and ###) * Extend spec to double and triple hash macros * Ensure we allow numeric strings as IDs Was testing for isNumber, which only checks for actual number types * Fix showing the placeholder when not empty * Add error span to the quickinfo macro * Better styling and title help for macros	4 years ago
Oliver Günther	e1a88a9a40	[34001] Ensure filters always receive the query context In the mentioned project, the query copy service fails to execute because a filter has lost its context right after `query.save`. There is a hook for `after_commit` which is not relevant here since we're in a transaction, but the context is lost regardless. Instead, we could ensure whenever accessing the filters, the context is set correctly. https://community.openproject.com/wp/34001	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580 ) * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
Oliver Günther	c369a71f4d	Allow project help texts on the rails form Renders help texts on a project core attributes and custom fields	4 years ago
Markus Kahl	a456537fe2	added missing prepare attachment endpoint for attribute help texts	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557 ) * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
bsatarnejad	3676ead9aa	Change how watchers data is returned to front-end, blocked users are not returned	4 years ago
ulferts	8cb7ed632a	remove watchers embedded in wp representer A client should not rely on embedding and our front end does not appear to	4 years ago
Markus Kahl	b85380f068	handle pending attachment validation errors	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	655f021b92	add derived dates to the work package resource The derived dates are the minimum/maximum of the descendant's dates. As long as the work package is scheduled automatically, the derived and non derived dates should be equal althoug the derived dates will be null in case non descendants exists. But if the user decides to activate manual scheduling the dates can deviate. The derived dates can then help to display the deviation to the user. This commit however does not alter the front end. The dates are eager loaded on the work package index commit using the same mechanims already introduced for spent time. The patched cost attributes, which are also eager loaded, are now eager loaded in the core as well so the patch is removed. As those attributes are now part of the core (although in a different module) it no longer makes sense to rely on patching for this.	4 years ago
Oliver Günther	c9cb9c1de4	Integrate plugin specs / features into common group	4 years ago
ulferts	3a3a48e267	journalize changes to the scheduling mode	4 years ago
Oliver Günther	d43d9e6e00	Add subproject boards and extract common board action class	4 years ago
Aleix Suau	0c2b9e1d60	deleted deprecated test setting /request_headers.rb	4 years ago
ulferts	a2a559e553	remove almost duplicate, but faulty, readonly check The writability of the status is already checked at the attribute level	4 years ago
Oliver Günther	113513d889	Bumped version to 10.6.6 [ci skip]	4 years ago
bsatarnejad	8e42259ac9	improve the display of project member invitation email	4 years ago
Aleix Suau	b19c996ecf	Code climate fixes	4 years ago
Wieland Lindenthal	760cdafe8c	Added Revit test configuration and some tests	4 years ago
Oliver Günther	2feaec1101	[33678] Priority needs to be a require field Priority was marked non-required for it to turn up in the attribute form configuration. But priority _is actually required_. This results in the frontend adding an optional placeholder `-` value, which makes the resource unsavable. This commit adds priority to the form, but keeps it required as it should be. https://community.openproject.com/wp/33678	4 years ago
Oliver Günther	b1a99353e2	Extend attribute help text for projects and allow images Attribute help text so far could only be added to work packages. This commit adds support for projects and adds the help texts to widget headers for status and description modals in the overview tab as well as extending the attachable mixin to allow uploading images. Uploaded attachments are to be expected to be visible regardless of permissions, thus this also adds an option to make attachments visible to all	4 years ago
Oliver Günther	829bf399c6	Ensure reform error merge syntax is compatible with ActiveModel	4 years ago
Oliver Günther	605f6b8355	Refactor copy project into service	4 years ago
Oliver Günther	ad28b96cf3	Bump version to 11.0	4 years ago

1 2 3 4 5 ...

5534 Commits (42920572da7d49dd1373657b02059d467eec65e7)